From: JeffyChen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 09/13] iommu/rockchip: Use iommu_group_get_for_dev() for add_device
Date: Wed, 17 Jan 2018 20:53:32 +0800 [thread overview]
Message-ID: <5A5F474C.8020606@rock-chips.com> (raw)
In-Reply-To: <5A5F45DA.5000104-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
On 01/17/2018 08:47 PM, JeffyChen wrote:
>>>
>>> +static struct iommu_group *rk_iommu_device_group(struct device *dev)
>>> +{
>>> + struct iommu_group *group;
>>> + int ret;
>>> +
>>> + group = iommu_group_get(dev);
>>> + if (!group) {
>>
>> This check is pointless - if dev->iommu_group were non-NULL you wouldn't
>> have been called in the first place.
> right, it's allocated in the probe.
oops, sorry, i see, this is not needed because device_group() is only be
called when iommu_group_get() returns NULL
WARNING: multiple messages have this Message-ID (diff)
From: jeffy.chen@rock-chips.com (JeffyChen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 09/13] iommu/rockchip: Use iommu_group_get_for_dev() for add_device
Date: Wed, 17 Jan 2018 20:53:32 +0800 [thread overview]
Message-ID: <5A5F474C.8020606@rock-chips.com> (raw)
In-Reply-To: <5A5F45DA.5000104@rock-chips.com>
On 01/17/2018 08:47 PM, JeffyChen wrote:
>>>
>>> +static struct iommu_group *rk_iommu_device_group(struct device *dev)
>>> +{
>>> + struct iommu_group *group;
>>> + int ret;
>>> +
>>> + group = iommu_group_get(dev);
>>> + if (!group) {
>>
>> This check is pointless - if dev->iommu_group were non-NULL you wouldn't
>> have been called in the first place.
> right, it's allocated in the probe.
oops, sorry, i see, this is not needed because device_group() is only be
called when iommu_group_get() returns NULL
WARNING: multiple messages have this Message-ID (diff)
From: JeffyChen <jeffy.chen@rock-chips.com>
To: Robin Murphy <robin.murphy@arm.com>, linux-kernel@vger.kernel.org
Cc: jcliang@chromium.org, xxm@rock-chips.com, tfiga@chromium.org,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
iommu@lists.linux-foundation.org, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 09/13] iommu/rockchip: Use iommu_group_get_for_dev() for add_device
Date: Wed, 17 Jan 2018 20:53:32 +0800 [thread overview]
Message-ID: <5A5F474C.8020606@rock-chips.com> (raw)
In-Reply-To: <5A5F45DA.5000104@rock-chips.com>
On 01/17/2018 08:47 PM, JeffyChen wrote:
>>>
>>> +static struct iommu_group *rk_iommu_device_group(struct device *dev)
>>> +{
>>> + struct iommu_group *group;
>>> + int ret;
>>> +
>>> + group = iommu_group_get(dev);
>>> + if (!group) {
>>
>> This check is pointless - if dev->iommu_group were non-NULL you wouldn't
>> have been called in the first place.
> right, it's allocated in the probe.
oops, sorry, i see, this is not needed because device_group() is only be
called when iommu_group_get() returns NULL
next prev parent reply other threads:[~2018-01-17 12:53 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 13:25 [PATCH v2 00/13] iommu/rockchip: Use OF_IOMMU Jeffy Chen
2018-01-16 13:25 ` Jeffy Chen
[not found] ` <20180116132540.18939-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-16 13:25 ` [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe() Jeffy Chen
2018-01-16 13:25 ` Jeffy Chen
[not found] ` <20180116132540.18939-2-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-17 4:21 ` Tomasz Figa
2018-01-17 4:21 ` Tomasz Figa
2018-01-17 4:21 ` Tomasz Figa
[not found] ` <CAAFQd5AO6_GYMs0xac-4ECFH9pn_ssg8jsFVoif0WDQ-daSuRA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-17 7:08 ` JeffyChen
2018-01-17 7:16 ` Tomasz Figa
2018-01-17 7:16 ` Tomasz Figa
[not found] ` <CAAFQd5Bnv3cLJ0wWY4+LJ+0GzDcm0F9QArY+QfFg692hd6UPjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-17 7:45 ` JeffyChen
2018-01-17 7:45 ` JeffyChen
2018-01-17 7:45 ` JeffyChen
2018-01-17 12:18 ` Robin Murphy
2018-01-17 12:18 ` Robin Murphy
2018-01-17 12:18 ` Robin Murphy
2018-01-17 12:46 ` JeffyChen
2018-01-17 12:46 ` JeffyChen
2018-01-16 13:25 ` [PATCH v2 02/13] iommu/rockchip: Suppress unbinding Jeffy Chen
2018-01-16 13:25 ` Jeffy Chen
[not found] ` <20180116132540.18939-3-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-17 4:23 ` Tomasz Figa
2018-01-17 4:23 ` Tomasz Figa
2018-01-17 4:23 ` Tomasz Figa
[not found] ` <CAAFQd5C_d2JW6kPQOMQ=mB6kHMdNZQGFvamjaDhexoPD_4W7+A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-17 5:32 ` Tomasz Figa
2018-01-17 5:32 ` Tomasz Figa
2018-01-17 5:32 ` Tomasz Figa
[not found] ` <CAAFQd5CXH_20649oZNrzFjHoKfpDi6gHF91jd3uCyjyOkH+Ohw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-17 7:16 ` JeffyChen
2018-01-16 13:25 ` [PATCH v2 03/13] iommu/rockchip: Fix error handling in attach Jeffy Chen
2018-01-16 13:25 ` Jeffy Chen
2018-01-16 13:25 ` [PATCH v2 04/13] iommu/rockchip: Fix error handling in probe Jeffy Chen
2018-01-16 13:25 ` Jeffy Chen
[not found] ` <20180116132540.18939-5-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-17 5:22 ` Tomasz Figa
2018-01-17 5:22 ` Tomasz Figa
2018-01-17 5:22 ` Tomasz Figa
2018-01-16 13:25 ` [PATCH v2 05/13] iommu/rockchip: Fix error handling in init Jeffy Chen
2018-01-16 13:25 ` Jeffy Chen
2018-01-17 5:26 ` Tomasz Figa
2018-01-17 5:26 ` Tomasz Figa
[not found] ` <CAAFQd5AFHheE+5Dx=0=BeL2W1EYd=Kmcb8fKcCBFRgP8ViuxgQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-17 7:14 ` JeffyChen
2018-01-17 7:19 ` Tomasz Figa
2018-01-17 7:19 ` Tomasz Figa
2018-01-17 12:27 ` Tomasz Figa
2018-01-17 12:27 ` Tomasz Figa
2018-01-17 11:36 ` Robin Murphy
2018-01-17 11:36 ` Robin Murphy
[not found] ` <e227cf1e-f00a-5cdb-487c-bf0046f3acbb-5wv7dgnIgG8@public.gmane.org>
2018-01-17 12:44 ` JeffyChen
2018-01-16 13:25 ` [PATCH v2 06/13] iommu/rockchip: Use iopoll helpers to wait for hardware Jeffy Chen
2018-01-16 13:25 ` Jeffy Chen
2018-01-16 13:25 ` [PATCH v2 08/13] iommu/rockchip: Control clocks needed to access the IOMMU Jeffy Chen
2018-01-16 13:25 ` Jeffy Chen
2018-01-16 13:25 ` [PATCH v2 09/13] iommu/rockchip: Use iommu_group_get_for_dev() for add_device Jeffy Chen
2018-01-16 13:25 ` Jeffy Chen
[not found] ` <20180116132540.18939-10-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-17 12:31 ` Robin Murphy
2018-01-17 12:31 ` Robin Murphy
2018-01-17 12:31 ` Robin Murphy
[not found] ` <4c1b2469-9a32-c6ca-522f-73143b0fa618-5wv7dgnIgG8@public.gmane.org>
2018-01-17 12:47 ` JeffyChen
2018-01-17 12:47 ` JeffyChen
2018-01-17 12:47 ` JeffyChen
[not found] ` <5A5F45DA.5000104-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-17 12:53 ` JeffyChen [this message]
2018-01-17 12:53 ` JeffyChen
2018-01-17 12:53 ` JeffyChen
2018-01-16 13:25 ` [PATCH v2 10/13] iommu/rockchip: Use IOMMU device for dma mapping operations Jeffy Chen
2018-01-16 13:25 ` Jeffy Chen
[not found] ` <20180116132540.18939-11-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-17 5:37 ` Tomasz Figa
2018-01-17 5:37 ` Tomasz Figa
2018-01-17 5:37 ` Tomasz Figa
2018-01-16 13:25 ` [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically Jeffy Chen
2018-01-16 13:25 ` Jeffy Chen
[not found] ` <20180116132540.18939-12-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-17 5:44 ` Tomasz Figa
2018-01-17 5:44 ` Tomasz Figa
2018-01-17 5:44 ` Tomasz Figa
[not found] ` <CAAFQd5C=SM21CmL8J334HseJ6SJH1wAVzKhrsk_cXMmpf8mK8g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-17 7:20 ` JeffyChen
2018-01-17 7:30 ` Tomasz Figa
2018-01-17 7:30 ` Tomasz Figa
[not found] ` <CAAFQd5AOZ797dNEvr5TbuWK-rw=dTCArUZM53t4_gNRugBd=sg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-17 7:47 ` JeffyChen
2018-01-17 7:47 ` JeffyChen
2018-01-17 7:47 ` JeffyChen
2018-01-16 13:25 ` [PATCH v2 12/13] iommu/rockchip: Add runtime PM support Jeffy Chen
2018-01-16 13:25 ` Jeffy Chen
[not found] ` <20180116132540.18939-13-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-17 6:20 ` Tomasz Figa
2018-01-17 6:20 ` Tomasz Figa
2018-01-17 6:20 ` Tomasz Figa
[not found] ` <CAAFQd5DCxgsL52+5XetV9MRDecL7dN6_QdHysKUOWaEqSf=ijw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-17 7:26 ` JeffyChen
2018-01-17 7:38 ` Tomasz Figa
2018-01-17 7:38 ` Tomasz Figa
2018-01-17 7:52 ` JeffyChen
2018-01-17 7:52 ` JeffyChen
[not found] ` <5A5F00D1.5010506-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-17 8:48 ` JeffyChen
2018-01-17 8:48 ` JeffyChen
2018-01-17 8:48 ` JeffyChen
2018-01-16 13:25 ` [PATCH v2 13/13] iommu/rockchip: Support sharing IOMMU between masters Jeffy Chen
2018-01-16 13:25 ` Jeffy Chen
[not found] ` <20180116132540.18939-14-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-17 13:00 ` Robin Murphy
2018-01-17 13:00 ` Robin Murphy
2018-01-17 13:00 ` Robin Murphy
[not found] ` <1bd5378d-8285-e0d9-8105-f9dd9f8cfdcb-5wv7dgnIgG8@public.gmane.org>
2018-01-17 13:32 ` JeffyChen
2018-01-17 13:32 ` JeffyChen
2018-01-17 13:32 ` JeffyChen
2018-01-16 13:25 ` [PATCH v2 07/13] iommu/rockchip: Fix TLB flush of secondary IOMMUs Jeffy Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A5F474C.8020606@rock-chips.com \
--to=jeffy.chen-tnx95d0mmh7dzftrwevzcw@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.