[LTP] [RFC] [PATCH] lib/tst_test: Use CLOCK_MONOTONIC for -I option.

[LTP] [RFC] [PATCH] lib/tst_test: Use CLOCK_MONOTONIC for -I option.

[Cyril Hrubis]

CLOCK_MONOTONIC has been added to linux in the 2.5 development branch so
this syscall is available in all 2.6 kernels hence it's reasonable to be
used it in the test library at this point it has been 15 years after
all.

Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
---
 lib/tst_test.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/lib/tst_test.c b/lib/tst_test.c
index 1df4b72df..2cf35ed66 100644
--- a/lib/tst_test.c
+++ b/lib/tst_test.c
@@ -24,7 +24,6 @@
 #include <sys/mount.h>
 #include <sys/types.h>
 #include <sys/wait.h>
-#include <sys/time.h>
 
 #define TST_NO_DEFAULT_MAIN
 #include "tst_test.h"
@@ -34,6 +33,8 @@
 #include "tst_ansi_color.h"
 #include "tst_safe_stdio.h"
 #include "tst_timer_test.h"
+#include "tst_clocks.h"
+#include "tst_timer.h"
 
 #include "old_resource.h"
 #include "old_device.h"
@@ -853,11 +854,12 @@ static void run_tests(void)
 
 static unsigned long long get_time_ms(void)
 {
-	struct timeval tv;
+	struct timespec ts;
 
-	gettimeofday(&tv, NULL);
+	if (tst_clock_gettime(CLOCK_MONOTONIC, &ts))
+		tst_brk(TBROK | TERRNO, "tst_clock_gettime()");
 
-	return tv.tv_sec * 1000 + tv.tv_usec / 1000;
+	return tst_timespec_to_ms(ts);
 }
 
 static void add_paths(void)
-- 
2.13.6

[LTP] [RFC] [PATCH] lib/tst_test: Use CLOCK_MONOTONIC for -I option.

[Jan Stancek]

----- Original Message -----
> CLOCK_MONOTONIC has been added to linux in the 2.5 development branch so
> this syscall is available in all 2.6 kernels hence it's reasonable to be
> used it in the test library at this point it has been 15 years after
> all.

LGTM.
Compile tested on rhel59 rhel62 rhel69 rhel7 rhel6i386.

Regards,
Jan

[LTP] [RFC] [PATCH] lib/tst_test: Use CLOCK_MONOTONIC for -I option.

[Cyril Hrubis]

Hi!
> > CLOCK_MONOTONIC has been added to linux in the 2.5 development branch so
> > this syscall is available in all 2.6 kernels hence it's reasonable to be
> > used it in the test library at this point it has been 15 years after
> > all.
> 
> LGTM.
> Compile tested on rhel59 rhel62 rhel69 rhel7 rhel6i386.

After thinking about this yesterday I think that we should do the same
for the old library just to keep testcase behavior consistent.

I will look into that and send follow up patch today.

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] [RFC] [PATCH] lib/tst_test: Use CLOCK_MONOTONIC for -I option.

[Cyril Hrubis]

Hi!
I've pushed both CLOCK_MONOTONIC patches just now.

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] [RFC] [PATCH] lib/tst_test: Use CLOCK_MONOTONIC for -I option.

[Li Wang]

On Mon, Jan 22, 2018 at 10:19 PM, Cyril Hrubis <chrubis@suse.cz> wrote:

> ​...
>
> -       return tv.tv_sec * 1000 + tv.tv_usec / 1000;
> +       return tst_timespec_to_ms(ts);
>


​Both patches(include the old-lib one) looks good.

I just have a small question about function tst_timespec_to_ms(), why the
t.tv_nsec plus 500000 when convert to msec?

static inline long long tst_timespec_to_ms(struct timespec t)
{
    return t.tv_sec * 1000 + (t.tv_nsec + 500000) / 1000000;
}
​


-- 
Li Wang
liwang@redhat.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20180125/3bbef9d1/attachment.html>

[LTP] [RFC] [PATCH] lib/tst_test: Use CLOCK_MONOTONIC for -I option.

[Xiao Yang]

On 2018/01/25 13:50, Li Wang wrote:
>
>
> On Mon, Jan 22, 2018 at 10:19 PM, Cyril Hrubis <chrubis@suse.cz 
> <mailto:chrubis@suse.cz>> wrote:
>
>     ​...
>
>     -       return tv.tv_sec * 1000 + tv.tv_usec / 1000;
>     +       return tst_timespec_to_ms(ts);
>
>
>
> ​Both patches(include the old-lib one) looks good.
>
> I just have a small question about function tst_timespec_to_ms(), why 
> the t.tv_nsec plus 500000 when convert to msec?
Hi Li,

It seems to round up/down the decimal produced by converting nesc to msec.
If the decimal is greater than 0.5,  round up it. If not, round down it.

Thanks,
Xiao Yang

>
> static inline long long tst_timespec_to_ms(struct timespec t)
> {
>     return t.tv_sec * 1000 + (t.tv_nsec + 500000) / 1000000;
> }
> ​
>
>
> -- 
> Li Wang
> liwang@redhat.com <mailto:liwang@redhat.com>
>
>
>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20180125/f9723f6c/attachment.html>

[LTP] [RFC] [PATCH] lib/tst_test: Use CLOCK_MONOTONIC for -I option.

[Li Wang]

On Thu, Jan 25, 2018 at 2:59 PM, Xiao Yang <yangx.jy@cn.fujitsu.com> wrote:

> On 2018/01/25 13:50, Li Wang wrote:
>
>
>
> On Mon, Jan 22, 2018 at 10:19 PM, Cyril Hrubis <chrubis@suse.cz> wrote:
>
>> ​...
>>
>> -       return tv.tv_sec * 1000 + tv.tv_usec / 1000;
>> +       return tst_timespec_to_ms(ts);
>>
>
>
> ​Both patches(include the old-lib one) looks good.
>
> I just have a small question about function tst_timespec_to_ms(), why the
> t.tv_nsec plus 500000 when convert to msec?
>
> Hi Li,
>
> It seems to round up/down the decimal produced by converting nesc to msec.
> If the decimal is greater than 0.5,  round up it. If not, round down it.
>
>
​Ah, yes. Thanks so much!​



-- 
Li Wang
liwang@redhat.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20180125/b399ad79/attachment.html>