* [Ocfs2-devel] [PATCH] ocfs2: unlock bh_state if bg check fails
@ 2018-01-25 1:18 Changwei Ge
2018-01-25 8:03 ` Gang He
2018-01-25 12:49 ` piaojun
0 siblings, 2 replies; 3+ messages in thread
From: Changwei Ge @ 2018-01-25 1:18 UTC (permalink / raw)
To: ocfs2-devel
We should unlock bh_stat if bg->bg_free_bits_count > bg->bg_bits
Suggested-by: Jan Kara <jack@suse.cz>
Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
---
fs/ocfs2/suballoc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c
index 71f22c8..6fee797 100644
--- a/fs/ocfs2/suballoc.c
+++ b/fs/ocfs2/suballoc.c
@@ -2441,6 +2441,8 @@ static int ocfs2_block_group_clear_bits(handle_t *handle,
}
le16_add_cpu(&bg->bg_free_bits_count, num_bits);
if (le16_to_cpu(bg->bg_free_bits_count) > le16_to_cpu(bg->bg_bits)) {
+ if (undo_fn)
+ jbd_unlock_bh_state(group_bh);
return ocfs2_error(alloc_inode->i_sb, "Group descriptor # %llu has bit count %u but claims %u are freed. num_bits %d\n",
(unsigned long long)le64_to_cpu(bg->bg_blkno),
le16_to_cpu(bg->bg_bits),
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: unlock bh_state if bg check fails
2018-01-25 1:18 [Ocfs2-devel] [PATCH] ocfs2: unlock bh_state if bg check fails Changwei Ge
@ 2018-01-25 8:03 ` Gang He
2018-01-25 12:49 ` piaojun
1 sibling, 0 replies; 3+ messages in thread
From: Gang He @ 2018-01-25 8:03 UTC (permalink / raw)
To: ocfs2-devel
Reviewed-by: Gang He <ghe@suse.com>
Thanks
Gang
>>>
> We should unlock bh_stat if bg->bg_free_bits_count > bg->bg_bits
>
> Suggested-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
> ---
> fs/ocfs2/suballoc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c
> index 71f22c8..6fee797 100644
> --- a/fs/ocfs2/suballoc.c
> +++ b/fs/ocfs2/suballoc.c
> @@ -2441,6 +2441,8 @@ static int ocfs2_block_group_clear_bits(handle_t
> *handle,
> }
> le16_add_cpu(&bg->bg_free_bits_count, num_bits);
> if (le16_to_cpu(bg->bg_free_bits_count) > le16_to_cpu(bg->bg_bits)) {
> + if (undo_fn)
> + jbd_unlock_bh_state(group_bh);
> return ocfs2_error(alloc_inode->i_sb, "Group descriptor # %llu has bit count
> %u but claims %u are freed. num_bits %d\n",
> (unsigned long long)le64_to_cpu(bg->bg_blkno),
> le16_to_cpu(bg->bg_bits),
> --
> 2.7.4
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: unlock bh_state if bg check fails
2018-01-25 1:18 [Ocfs2-devel] [PATCH] ocfs2: unlock bh_state if bg check fails Changwei Ge
2018-01-25 8:03 ` Gang He
@ 2018-01-25 12:49 ` piaojun
1 sibling, 0 replies; 3+ messages in thread
From: piaojun @ 2018-01-25 12:49 UTC (permalink / raw)
To: ocfs2-devel
LGTM
On 2018/1/25 9:18, Changwei Ge wrote:
> We should unlock bh_stat if bg->bg_free_bits_count > bg->bg_bits
>
> Suggested-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
Reviewed-by: Jun Piao <piaojun@huawei.com>
> ---
> fs/ocfs2/suballoc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c
> index 71f22c8..6fee797 100644
> --- a/fs/ocfs2/suballoc.c
> +++ b/fs/ocfs2/suballoc.c
> @@ -2441,6 +2441,8 @@ static int ocfs2_block_group_clear_bits(handle_t *handle,
> }
> le16_add_cpu(&bg->bg_free_bits_count, num_bits);
> if (le16_to_cpu(bg->bg_free_bits_count) > le16_to_cpu(bg->bg_bits)) {
> + if (undo_fn)
> + jbd_unlock_bh_state(group_bh);
> return ocfs2_error(alloc_inode->i_sb, "Group descriptor # %llu has bit count %u but claims %u are freed. num_bits %d\n",
> (unsigned long long)le64_to_cpu(bg->bg_blkno),
> le16_to_cpu(bg->bg_bits),
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-25 12:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-25 1:18 [Ocfs2-devel] [PATCH] ocfs2: unlock bh_state if bg check fails Changwei Ge
2018-01-25 8:03 ` Gang He
2018-01-25 12:49 ` piaojun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.