From: Chanwoo Choi <cw00.choi@samsung.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: linux-clk@vger.kernel.org, sboyd@codeaurora.org,
mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, b.zolnierkie@samsung.com,
m.szyprowski@samsung.com
Subject: Re: [PATCH 1/3] clk: exynos5433: Extend list of available AUD_PLL output frequencies
Date: Fri, 09 Feb 2018 16:25:29 +0900 [thread overview]
Message-ID: <5A7D4CE9.6070900@samsung.com> (raw)
In-Reply-To: <086b44d2-6556-fa7c-1a5b-01c243bf0682@samsung.com>
On 2018년 02월 07일 22:04, Sylwester Nawrocki wrote:
> On 02/07/2018 12:24 PM, Chanwoo Choi wrote:
>> Could you share your equation?
>> because your result is a little bit different of my result.
>> - my equation : ((mdiv + kdiv/65535) x 24MHz) / (pdiv x POWER(2,sdiv))
>
> It resembles the code from samsung_pll36xx_recalc_rate():
>
> (24 * 10^6 * (M * 2^16 + K)) / (P * 2^S) / 2^16
>
> and a more accurate one
>
> ROUNDDOWN(ROUNDDOWN(24 * 10^6 * (M * 2^16 + K), 0) / ROUNDDOWN(P * 2^S, 0) / 2^16, 0)
>
> Shouldn't you substitute 65535 with 65536?
65536 is right. It is my mistake using 65535.
Thanks for your share.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] clk: exynos5433: Extend list of available AUD_PLL output frequencies
Date: Fri, 09 Feb 2018 16:25:29 +0900 [thread overview]
Message-ID: <5A7D4CE9.6070900@samsung.com> (raw)
In-Reply-To: <086b44d2-6556-fa7c-1a5b-01c243bf0682@samsung.com>
On 2018? 02? 07? 22:04, Sylwester Nawrocki wrote:
> On 02/07/2018 12:24 PM, Chanwoo Choi wrote:
>> Could you share your equation?
>> because your result is a little bit different of my result.
>> - my equation : ((mdiv + kdiv/65535) x 24MHz) / (pdiv x POWER(2,sdiv))
>
> It resembles the code from samsung_pll36xx_recalc_rate():
>
> (24 * 10^6 * (M * 2^16 + K)) / (P * 2^S) / 2^16
>
> and a more accurate one
>
> ROUNDDOWN(ROUNDDOWN(24 * 10^6 * (M * 2^16 + K), 0) / ROUNDDOWN(P * 2^S, 0) / 2^16, 0)
>
> Shouldn't you substitute 65535 with 65536?
65536 is right. It is my mistake using 65535.
Thanks for your share.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2018-02-09 7:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180205142252epcas1p4471e32e2b513806420c64b323af2ffa6@epcas1p4.samsung.com>
2018-02-05 14:22 ` [PATCH 1/3] clk: exynos5433: Extend list of available AUD_PLL output frequencies Sylwester Nawrocki
2018-02-05 14:22 ` Sylwester Nawrocki
2018-02-05 14:22 ` [PATCH 2/3] clk: exynos5433: Allow audio subsystem clock rate propagation Sylwester Nawrocki
2018-02-05 14:22 ` Sylwester Nawrocki
2018-02-06 4:06 ` Chanwoo Choi
2018-02-06 4:06 ` Chanwoo Choi
2018-02-07 15:18 ` Sylwester Nawrocki
2018-02-07 15:18 ` Sylwester Nawrocki
2018-02-09 7:36 ` Chanwoo Choi
2018-02-09 7:36 ` Chanwoo Choi
2018-02-12 11:45 ` Sylwester Nawrocki
2018-02-12 11:45 ` Sylwester Nawrocki
2018-02-12 21:44 ` Chanwoo Choi
2018-02-12 21:44 ` Chanwoo Choi
2018-02-05 14:22 ` [PATCH 3/3] clk: exynos5433: Add CLK_IGNORE_UNUSED flag to sclk_ioclk_i2s1_bclk Sylwester Nawrocki
2018-02-05 14:22 ` Sylwester Nawrocki
2018-02-06 4:08 ` Chanwoo Choi
2018-02-06 4:08 ` Chanwoo Choi
2018-02-14 14:52 ` Sylwester Nawrocki
2018-02-14 14:52 ` Sylwester Nawrocki
2018-02-06 2:44 ` [PATCH 1/3] clk: exynos5433: Extend list of available AUD_PLL output frequencies Chanwoo Choi
2018-02-06 2:44 ` Chanwoo Choi
2018-02-07 10:29 ` Sylwester Nawrocki
2018-02-07 10:29 ` Sylwester Nawrocki
2018-02-07 11:24 ` Chanwoo Choi
2018-02-07 11:24 ` Chanwoo Choi
2018-02-07 13:04 ` Sylwester Nawrocki
2018-02-07 13:04 ` Sylwester Nawrocki
2018-02-09 7:25 ` Chanwoo Choi [this message]
2018-02-09 7:25 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A7D4CE9.6070900@samsung.com \
--to=cw00.choi@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.