From: Wei Wang <wei.w.wang@intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mst@redhat.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] mm/page_poison: move PAGE_POISON to page_poison.c
Date: Mon, 26 Feb 2018 12:37:58 +0800 [thread overview]
Message-ID: <5A938F26.4040901@intel.com> (raw)
In-Reply-To: <20180213101615.GO3443@dhcp22.suse.cz>
On 02/13/2018 06:16 PM, Michal Hocko wrote:
> On Fri 09-02-18 16:08:14, Wei Wang wrote:
>> The PAGE_POISON macro is used in page_poison.c only, so avoid exporting
>> it. Also remove the "mm/debug-pagealloc.c" related comment, which is
>> obsolete.
> Why is this an improvement? I thought the whole point of poison.h is to
> keep all the poison value at a single place to make them obviously
> unique.
There isn't a comment explaining why they are exposed. We did this
because PAGE_POISON is used by page_poison.c only, it seems not
necessary to expose the private values.
Why would it be not unique if moved to page_poison.c (on condition that
it is only used there)?
Best,
Wei
WARNING: multiple messages have this Message-ID (diff)
From: Wei Wang <wei.w.wang@intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
mst@redhat.com, akpm@linux-foundation.org
Subject: Re: [PATCH] mm/page_poison: move PAGE_POISON to page_poison.c
Date: Mon, 26 Feb 2018 12:37:58 +0800 [thread overview]
Message-ID: <5A938F26.4040901@intel.com> (raw)
In-Reply-To: <20180213101615.GO3443@dhcp22.suse.cz>
On 02/13/2018 06:16 PM, Michal Hocko wrote:
> On Fri 09-02-18 16:08:14, Wei Wang wrote:
>> The PAGE_POISON macro is used in page_poison.c only, so avoid exporting
>> it. Also remove the "mm/debug-pagealloc.c" related comment, which is
>> obsolete.
> Why is this an improvement? I thought the whole point of poison.h is to
> keep all the poison value at a single place to make them obviously
> unique.
There isn't a comment explaining why they are exposed. We did this
because PAGE_POISON is used by page_poison.c only, it seems not
necessary to expose the private values.
Why would it be not unique if moved to page_poison.c (on condition that
it is only used there)?
Best,
Wei
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Wei Wang <wei.w.wang@intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
mst@redhat.com, akpm@linux-foundation.org
Subject: Re: [PATCH] mm/page_poison: move PAGE_POISON to page_poison.c
Date: Mon, 26 Feb 2018 12:37:58 +0800 [thread overview]
Message-ID: <5A938F26.4040901@intel.com> (raw)
In-Reply-To: <20180213101615.GO3443@dhcp22.suse.cz>
On 02/13/2018 06:16 PM, Michal Hocko wrote:
> On Fri 09-02-18 16:08:14, Wei Wang wrote:
>> The PAGE_POISON macro is used in page_poison.c only, so avoid exporting
>> it. Also remove the "mm/debug-pagealloc.c" related comment, which is
>> obsolete.
> Why is this an improvement? I thought the whole point of poison.h is to
> keep all the poison value at a single place to make them obviously
> unique.
There isn't a comment explaining why they are exposed. We did this
because PAGE_POISON is used by page_poison.c only, it seems not
necessary to expose the private values.
Why would it be not unique if moved to page_poison.c (on condition that
it is only used there)?
Best,
Wei
next prev parent reply other threads:[~2018-02-26 4:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 8:08 [PATCH] mm/page_poison: move PAGE_POISON to page_poison.c Wei Wang
2018-02-09 8:08 ` Wei Wang
2018-02-09 16:23 ` Michael S. Tsirkin
2018-02-09 16:23 ` Michael S. Tsirkin
2018-02-09 16:23 ` Michael S. Tsirkin
2018-02-13 10:16 ` Michal Hocko
2018-02-13 10:16 ` Michal Hocko
2018-02-26 4:37 ` Wei Wang [this message]
2018-02-26 4:37 ` Wei Wang
2018-02-26 4:37 ` Wei Wang
2018-02-13 10:16 ` Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2018-02-09 8:08 Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A938F26.4040901@intel.com \
--to=wei.w.wang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.