* [PATCH] rbd: fix spelling mistake: "reregisteration" -> "re-registration"
@ 2018-03-19 13:33 Colin King
2018-03-20 10:35 ` Dongsheng Yang
0 siblings, 1 reply; 6+ messages in thread
From: Colin King @ 2018-03-19 13:33 UTC (permalink / raw)
To: Ilya Dryomov, Sage Weil, Alex Elder, Jens Axboe, ceph-devel,
linux-block
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trivial fix to spelling mistake in rdb_warn message text
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/block/rbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 1e03b04819c8..7b97240ff15e 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -3887,7 +3887,7 @@ static void rbd_reregister_watch(struct work_struct *work)
ret = rbd_dev_refresh(rbd_dev);
if (ret)
- rbd_warn(rbd_dev, "reregisteration refresh failed: %d", ret);
+ rbd_warn(rbd_dev, "re-registration refresh failed: %d", ret);
}
/*
--
2.15.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] rbd: fix spelling mistake: "reregisteration" -> "re-registration"
2018-03-19 13:33 [PATCH] rbd: fix spelling mistake: "reregisteration" -> "re-registration" Colin King
@ 2018-03-20 10:35 ` Dongsheng Yang
0 siblings, 0 replies; 6+ messages in thread
From: Dongsheng Yang @ 2018-03-20 10:35 UTC (permalink / raw)
To: Colin King, Ilya Dryomov, Sage Weil, Alex Elder, Jens Axboe,
ceph-devel, linux-block
Cc: kernel-janitors, linux-kernel
Hi Colin,
On 03/19/2018 09:33 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in rdb_warn message text
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 1e03b04819c8..7b97240ff15e 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -3887,7 +3887,7 @@ static void rbd_reregister_watch(struct work_struct *work)
>
> ret = rbd_dev_refresh(rbd_dev);
> if (ret)
> - rbd_warn(rbd_dev, "reregisteration refresh failed: %d", ret);
> + rbd_warn(rbd_dev, "re-registration refresh failed: %d", ret);
Hmmm, I am not sure is that a spelling mistake, because the function
name is rbd_reregister_watch().
Thanx
Yang
> }
>
> /*
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rbd: fix spelling mistake: "reregisteration" -> "re-registration"
@ 2018-03-20 10:35 ` Dongsheng Yang
0 siblings, 0 replies; 6+ messages in thread
From: Dongsheng Yang @ 2018-03-20 10:35 UTC (permalink / raw)
To: Colin King, Ilya Dryomov, Sage Weil, Alex Elder, Jens Axboe,
ceph-devel, linux-block
Cc: kernel-janitors, linux-kernel
Hi Colin,
On 03/19/2018 09:33 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in rdb_warn message text
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 1e03b04819c8..7b97240ff15e 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -3887,7 +3887,7 @@ static void rbd_reregister_watch(struct work_struct *work)
>
> ret = rbd_dev_refresh(rbd_dev);
> if (ret)
> - rbd_warn(rbd_dev, "reregisteration refresh failed: %d", ret);
> + rbd_warn(rbd_dev, "re-registration refresh failed: %d", ret);
Hmmm, I am not sure is that a spelling mistake, because the function
name is rbd_reregister_watch().
Thanx
Yang
> }
>
> /*
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rbd: fix spelling mistake: "reregisteration" -> "re-registration"
2018-03-20 10:35 ` Dongsheng Yang
(?)
@ 2018-03-20 10:39 ` Colin Ian King
2018-03-20 14:49 ` Ilya Dryomov
-1 siblings, 1 reply; 6+ messages in thread
From: Colin Ian King @ 2018-03-20 10:39 UTC (permalink / raw)
To: Dongsheng Yang, Ilya Dryomov, Sage Weil, Alex Elder, Jens Axboe,
ceph-devel, linux-block
Cc: kernel-janitors, linux-kernel
On 20/03/18 10:35, Dongsheng Yang wrote:
> Hi Colin,
>
> On 03/19/2018 09:33 PM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Trivial fix to spelling mistake in rdb_warn message text
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/block/rbd.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
>> index 1e03b04819c8..7b97240ff15e 100644
>> --- a/drivers/block/rbd.c
>> +++ b/drivers/block/rbd.c
>> @@ -3887,7 +3887,7 @@ static void rbd_reregister_watch(struct
>> work_struct *work)
>> ret = rbd_dev_refresh(rbd_dev);
>> if (ret)
>> - rbd_warn(rbd_dev, "reregisteration refresh failed: %d", ret);
>> + rbd_warn(rbd_dev, "re-registrationrefresh failed: %d", ret);
>
> Hmmm, I am not sure is that a spelling mistake, because the function
> name is rbd_reregister_watch().
OK, well reregisteration should be reregistration then.
Colin
>
> Thanx
> Yang
>> }
>> /*
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rbd: fix spelling mistake: "reregisteration" -> "re-registration"
2018-03-20 10:39 ` Colin Ian King
@ 2018-03-20 14:49 ` Ilya Dryomov
0 siblings, 0 replies; 6+ messages in thread
From: Ilya Dryomov @ 2018-03-20 14:49 UTC (permalink / raw)
To: Colin Ian King
Cc: Dongsheng Yang, Sage Weil, Alex Elder, Jens Axboe,
Ceph Development, linux-block, kernel-janitors, linux-kernel
On Tue, Mar 20, 2018 at 11:39 AM, Colin Ian King
<colin.king@canonical.com> wrote:
> On 20/03/18 10:35, Dongsheng Yang wrote:
>> Hi Colin,
>>
>> On 03/19/2018 09:33 PM, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> Trivial fix to spelling mistake in rdb_warn message text
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> drivers/block/rbd.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
>>> index 1e03b04819c8..7b97240ff15e 100644
>>> --- a/drivers/block/rbd.c
>>> +++ b/drivers/block/rbd.c
>>> @@ -3887,7 +3887,7 @@ static void rbd_reregister_watch(struct
>>> work_struct *work)
>>> ret = rbd_dev_refresh(rbd_dev);
>>> if (ret)
>>> - rbd_warn(rbd_dev, "reregisteration refresh failed: %d", ret);
>>> + rbd_warn(rbd_dev, "re-registrationrefresh failed: %d", ret);
>>
>> Hmmm, I am not sure is that a spelling mistake, because the function
>> name is rbd_reregister_watch().
>
> OK, well reregisteration should be reregistration then.
I went ahead and applied the change to "reregistration".
Thanks,
Ilya
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] rbd: fix spelling mistake: "reregisteration" -> "re-registration"
@ 2018-03-20 14:49 ` Ilya Dryomov
0 siblings, 0 replies; 6+ messages in thread
From: Ilya Dryomov @ 2018-03-20 14:49 UTC (permalink / raw)
To: Colin Ian King
Cc: Dongsheng Yang, Sage Weil, Alex Elder, Jens Axboe,
Ceph Development, linux-block, kernel-janitors, linux-kernel
On Tue, Mar 20, 2018 at 11:39 AM, Colin Ian King
<colin.king@canonical.com> wrote:
> On 20/03/18 10:35, Dongsheng Yang wrote:
>> Hi Colin,
>>
>> On 03/19/2018 09:33 PM, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> Trivial fix to spelling mistake in rdb_warn message text
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> drivers/block/rbd.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
>>> index 1e03b04819c8..7b97240ff15e 100644
>>> --- a/drivers/block/rbd.c
>>> +++ b/drivers/block/rbd.c
>>> @@ -3887,7 +3887,7 @@ static void rbd_reregister_watch(struct
>>> work_struct *work)
>>> ret = rbd_dev_refresh(rbd_dev);
>>> if (ret)
>>> - rbd_warn(rbd_dev, "reregisteration refresh failed: %d", ret);
>>> + rbd_warn(rbd_dev, "re-registrationrefresh failed: %d", ret);
>>
>> Hmmm, I am not sure is that a spelling mistake, because the function
>> name is rbd_reregister_watch().
>
> OK, well reregisteration should be reregistration then.
I went ahead and applied the change to "reregistration".
Thanks,
Ilya
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-20 14:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-19 13:33 [PATCH] rbd: fix spelling mistake: "reregisteration" -> "re-registration" Colin King
2018-03-20 10:35 ` Dongsheng Yang
2018-03-20 10:35 ` Dongsheng Yang
2018-03-20 10:39 ` Colin Ian King
2018-03-20 14:49 ` Ilya Dryomov
2018-03-20 14:49 ` Ilya Dryomov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.