All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/bridge/sii8620: add Kconfig dependency on extcon
       [not found] <CGME20180409062713eucas1p1f714edc1b456d96a829f8884ed5c4694@eucas1p1.samsung.com>
@ 2018-04-09  6:27 ` Andrzej Hajda
  2018-04-09  7:57   ` Chanwoo Choi
  0 siblings, 1 reply; 2+ messages in thread
From: Andrzej Hajda @ 2018-04-09  6:27 UTC (permalink / raw)
  To: Archit Taneja, Laurent Pinchart
  Cc: Marek Szyprowski, Chanwoo Choi, dri-devel,
	Bartlomiej Zolnierkiewicz

The driver can work with or without extcon framework, but if extcon is
build as module, sii8620 should be build as module as well.

Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 drivers/gpu/drm/bridge/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 3aa65bdecb0e..684ac626ac53 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -74,6 +74,7 @@ config DRM_SIL_SII8620
 	tristate "Silicon Image SII8620 HDMI/MHL bridge"
 	depends on OF && RC_CORE
 	select DRM_KMS_HELPER
+	imply EXTCON
 	help
 	  Silicon Image SII8620 HDMI/MHL bridge chip driver.
 
-- 
2.16.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/bridge/sii8620: add Kconfig dependency on extcon
  2018-04-09  6:27 ` [PATCH] drm/bridge/sii8620: add Kconfig dependency on extcon Andrzej Hajda
@ 2018-04-09  7:57   ` Chanwoo Choi
  0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2018-04-09  7:57 UTC (permalink / raw)
  To: Andrzej Hajda, Archit Taneja, Laurent Pinchart
  Cc: Marek Szyprowski, dri-devel, Bartlomiej Zolnierkiewicz

Hi,

On 2018년 04월 09일 15:27, Andrzej Hajda wrote:
> The driver can work with or without extcon framework, but if extcon is
> build as module, sii8620 should be build as module as well.
> 
> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  drivers/gpu/drm/bridge/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 3aa65bdecb0e..684ac626ac53 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -74,6 +74,7 @@ config DRM_SIL_SII8620
>  	tristate "Silicon Image SII8620 HDMI/MHL bridge"
>  	depends on OF && RC_CORE
>  	select DRM_KMS_HELPER
> +	imply EXTCON
>  	help
>  	  Silicon Image SII8620 HDMI/MHL bridge chip driver.
>  
> 

Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-09  7:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20180409062713eucas1p1f714edc1b456d96a829f8884ed5c4694@eucas1p1.samsung.com>
2018-04-09  6:27 ` [PATCH] drm/bridge/sii8620: add Kconfig dependency on extcon Andrzej Hajda
2018-04-09  7:57   ` Chanwoo Choi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.