All of lore.kernel.org
 help / color / mirror / Atom feed
From: Inki Dae <inki.dae@samsung.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
	David Airlie <airlied@linux.ie>,
	kernel-janitors@vger.kernel.org,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Kukjin Kim <kgene@kernel.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/exynos: fimc: signedness bug in fimc_setup_clocks()
Date: Wed, 23 May 2018 00:33:18 +0000	[thread overview]
Message-ID: <5B04B6CE.2010004@samsung.com> (raw)
In-Reply-To: <20180518080445.GB28335@mwanda>



2018년 05월 18일 17:04에 Dan Carpenter 이(가) 쓴 글:
> "id" needs to be signed for the error handling to work.

Applied to exynos-drm-fixes-v4.18-rc1.

Thanks,
Inki Dae

> 
> Fixes: 7a2d5c77c558 ("drm/exynos: fimc: Convert driver to IPP v2 core API")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> index 4dfbfc7f3b84..5ce84025d1cb 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> @@ -1200,7 +1200,7 @@ static int fimc_setup_clocks(struct fimc_context *ctx)
>  
>  int exynos_drm_check_fimc_device(struct device *dev)
>  {
> -	unsigned int id = of_alias_get_id(dev->of_node, "fimc");
> +	int id = of_alias_get_id(dev->of_node, "fimc");
>  
>  	if (id >= 0 && (BIT(id) & fimc_mask))
>  		return 0;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Inki Dae <inki.dae@samsung.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
	David Airlie <airlied@linux.ie>,
	kernel-janitors@vger.kernel.org,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Kukjin Kim <kgene@kernel.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/exynos: fimc: signedness bug in fimc_setup_clocks()
Date: Wed, 23 May 2018 09:33:18 +0900	[thread overview]
Message-ID: <5B04B6CE.2010004@samsung.com> (raw)
In-Reply-To: <20180518080445.GB28335@mwanda>



2018년 05월 18일 17:04에 Dan Carpenter 이(가) 쓴 글:
> "id" needs to be signed for the error handling to work.

Applied to exynos-drm-fixes-v4.18-rc1.

Thanks,
Inki Dae

> 
> Fixes: 7a2d5c77c558 ("drm/exynos: fimc: Convert driver to IPP v2 core API")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> index 4dfbfc7f3b84..5ce84025d1cb 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> @@ -1200,7 +1200,7 @@ static int fimc_setup_clocks(struct fimc_context *ctx)
>  
>  int exynos_drm_check_fimc_device(struct device *dev)
>  {
> -	unsigned int id = of_alias_get_id(dev->of_node, "fimc");
> +	int id = of_alias_get_id(dev->of_node, "fimc");
>  
>  	if (id >= 0 && (BIT(id) & fimc_mask))
>  		return 0;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-05-23  0:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180518080527epcas1p293dfaa13795c92f9239e8c9bd95af9ad@epcas1p2.samsung.com>
2018-05-18  8:04 ` [PATCH] drm/exynos: fimc: signedness bug in fimc_setup_clocks() Dan Carpenter
2018-05-18  8:04   ` Dan Carpenter
2018-05-23  0:33   ` Inki Dae [this message]
2018-05-23  0:33     ` Inki Dae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B04B6CE.2010004@samsung.com \
    --to=inki.dae@samsung.com \
    --cc=airlied@linux.ie \
    --cc=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.