* [PATCH] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE [not found] <CGME20180524070715epcas1p4615ac319be293fd3b456446434f629ed@epcas1p4.samsung.com> @ 2018-05-24 7:07 ` Inki Dae 2018-05-24 8:03 ` Andrzej Hajda 0 siblings, 1 reply; 3+ messages in thread From: Inki Dae @ 2018-05-24 7:07 UTC (permalink / raw) To: dri-devel; +Cc: m.purski, linux-samsung-soc This patch makes RC_CORE to be selected with this driver. sil_sii8620 driver calls remote controller interfaces directly so RC_CORE should be enabled mandatorily. And some boards not using remote controller device don't really need to know that RC_CORE config should be enabled to use sil_sii8620 driver only for HDMI. Signed-off-by: Inki Dae <inki.dae@samsung.com> --- drivers/gpu/drm/bridge/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 3aa65bd..0290fc3 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -72,8 +72,9 @@ config DRM_PARADE_PS8622 config DRM_SIL_SII8620 tristate "Silicon Image SII8620 HDMI/MHL bridge" - depends on OF && RC_CORE + depends on OF select DRM_KMS_HELPER + select RC_CORE help Silicon Image SII8620 HDMI/MHL bridge chip driver. -- 1.9.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE 2018-05-24 7:07 ` [PATCH] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE Inki Dae @ 2018-05-24 8:03 ` Andrzej Hajda 2018-05-24 9:27 ` Inki Dae 0 siblings, 1 reply; 3+ messages in thread From: Andrzej Hajda @ 2018-05-24 8:03 UTC (permalink / raw) To: Inki Dae, dri-devel; +Cc: m.purski, linux-samsung-soc On 24.05.2018 09:07, Inki Dae wrote: > This patch makes RC_CORE to be selected with this driver. > > sil_sii8620 driver calls remote controller interfaces directly > so RC_CORE should be enabled mandatorily. > > And some boards not using remote controller device don't really > need to know that RC_CORE config should be enabled to use sil_sii8620 > driver only for HDMI. > > Signed-off-by: Inki Dae <inki.dae@samsung.com> > --- > drivers/gpu/drm/bridge/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index 3aa65bd..0290fc3 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -72,8 +72,9 @@ config DRM_PARADE_PS8622 > > config DRM_SIL_SII8620 > tristate "Silicon Image SII8620 HDMI/MHL bridge" > - depends on OF && RC_CORE > + depends on OF > select DRM_KMS_HELPER > + select RC_CORE RC_CORE depends on INPUT so it will break compilation if INPUT is not defined. Adding also 'select INPUT' should work: - depends on OF && RC_CORE + depends on OF select DRM_KMS_HELPER + select INPUT + select RC_CORE Regards Andrzej > help > Silicon Image SII8620 HDMI/MHL bridge chip driver. > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE 2018-05-24 8:03 ` Andrzej Hajda @ 2018-05-24 9:27 ` Inki Dae 0 siblings, 0 replies; 3+ messages in thread From: Inki Dae @ 2018-05-24 9:27 UTC (permalink / raw) To: Andrzej Hajda, dri-devel; +Cc: m.purski, linux-samsung-soc 2018년 05월 24일 17:03에 Andrzej Hajda 이(가) 쓴 글: > On 24.05.2018 09:07, Inki Dae wrote: >> This patch makes RC_CORE to be selected with this driver. >> >> sil_sii8620 driver calls remote controller interfaces directly >> so RC_CORE should be enabled mandatorily. >> >> And some boards not using remote controller device don't really >> need to know that RC_CORE config should be enabled to use sil_sii8620 >> driver only for HDMI. >> >> Signed-off-by: Inki Dae <inki.dae@samsung.com> >> --- >> drivers/gpu/drm/bridge/Kconfig | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig >> index 3aa65bd..0290fc3 100644 >> --- a/drivers/gpu/drm/bridge/Kconfig >> +++ b/drivers/gpu/drm/bridge/Kconfig >> @@ -72,8 +72,9 @@ config DRM_PARADE_PS8622 >> >> config DRM_SIL_SII8620 >> tristate "Silicon Image SII8620 HDMI/MHL bridge" >> - depends on OF && RC_CORE >> + depends on OF >> select DRM_KMS_HELPER >> + select RC_CORE > > RC_CORE depends on INPUT so it will break compilation if INPUT is not > defined. > Adding also 'select INPUT' should work: Opps, I will post v2 soon. Thanks, Inki Dae > > - depends on OF && RC_CORE > + depends on OF > select DRM_KMS_HELPER > + select INPUT > + select RC_CORE > > > Regards > Andrzej > > > >> help >> Silicon Image SII8620 HDMI/MHL bridge chip driver. >> > > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-24 9:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180524070715epcas1p4615ac319be293fd3b456446434f629ed@epcas1p4.samsung.com>
2018-05-24 7:07 ` [PATCH] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE Inki Dae
2018-05-24 8:03 ` Andrzej Hajda
2018-05-24 9:27 ` Inki Dae
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.