From: Shannon Zhao <zhaoshenglong@huawei.com>
To: <qemu-devel@nongnu.org>
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, famz@redhat.com,
eric.auger@redhat.com, shannon.zhaosl@gmail.com
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v4 0/2] Fix ARM KVM GICv3 get/put data shift bug
Date: Sat, 26 May 2018 08:41:42 +0800 [thread overview]
Message-ID: <5B08AD46.9020101@huawei.com> (raw)
In-Reply-To: <152724816757.234.340581049808773005@d39dc562802a>
On 2018/5/25 19:36, no-reply@patchew.org wrote:
> /tmp/qemu-test/src/hw/intc/arm_gicv3_common.c: In function 'gicv3_gicd_no_migration_shift_bug_post_load':
> /tmp/qemu-test/src/hw/intc/arm_gicv3_common.c:165:9: error: 'gicd_no_migration_shift_bug' undeclared (first use in this function); did you mean 'gicv3_gicd_no_migration_shift_bug_pre_load'?
> if (gicd_no_migration_shift_bug) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> gicv3_gicd_no_migration_shift_bug_pre_load
After compiling the patches, I add this check while forgot to use
cs->gicd_no_migration_shift_bug. My bad. I'll address this with other
comments in next version.
Thanks,
--
Shannon
WARNING: multiple messages have this Message-ID (diff)
From: Shannon Zhao <zhaoshenglong@huawei.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, qemu-arm@nongnu.org, peter.maydell@linaro.org,
shannon.zhaosl@gmail.com, eric.auger@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 0/2] Fix ARM KVM GICv3 get/put data shift bug
Date: Sat, 26 May 2018 08:41:42 +0800 [thread overview]
Message-ID: <5B08AD46.9020101@huawei.com> (raw)
In-Reply-To: <152724816757.234.340581049808773005@d39dc562802a>
On 2018/5/25 19:36, no-reply@patchew.org wrote:
> /tmp/qemu-test/src/hw/intc/arm_gicv3_common.c: In function 'gicv3_gicd_no_migration_shift_bug_post_load':
> /tmp/qemu-test/src/hw/intc/arm_gicv3_common.c:165:9: error: 'gicd_no_migration_shift_bug' undeclared (first use in this function); did you mean 'gicv3_gicd_no_migration_shift_bug_pre_load'?
> if (gicd_no_migration_shift_bug) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> gicv3_gicd_no_migration_shift_bug_pre_load
After compiling the patches, I add this check while forgot to use
cs->gicd_no_migration_shift_bug. My bad. I'll address this with other
comments in next version.
Thanks,
--
Shannon
next prev parent reply other threads:[~2018-05-26 0:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 11:22 [Qemu-arm] [PATCH v4 0/2] Fix ARM KVM GICv3 get/put data shift bug Shannon Zhao
2018-05-25 11:22 ` [Qemu-devel] " Shannon Zhao
2018-05-25 11:22 ` [Qemu-arm] [PATCH v4 1/2] arm_gicv3_kvm: kvm_dist_get/put_priority: skip the registers banked by GICR_IPRIORITYR Shannon Zhao
2018-05-25 11:22 ` [Qemu-devel] " Shannon Zhao
2018-05-29 14:20 ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2018-05-29 14:20 ` Peter Maydell
2018-05-25 11:22 ` [Qemu-arm] [PATCH v4 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR Shannon Zhao
2018-05-25 11:22 ` [Qemu-devel] " Shannon Zhao
2018-05-29 14:44 ` [Qemu-arm] " Peter Maydell
2018-05-29 14:44 ` [Qemu-devel] " Peter Maydell
2018-05-30 1:42 ` Shannon Zhao
2018-05-30 1:42 ` [Qemu-devel] " Shannon Zhao
2018-05-31 10:02 ` Peter Maydell
2018-05-31 10:02 ` [Qemu-devel] " Peter Maydell
2018-05-25 11:36 ` [Qemu-arm] [Qemu-devel] [PATCH v4 0/2] Fix ARM KVM GICv3 get/put data shift bug no-reply
2018-05-25 11:36 ` no-reply
2018-05-26 0:41 ` Shannon Zhao [this message]
2018-05-26 0:41 ` Shannon Zhao
2018-05-25 11:39 ` [Qemu-arm] " no-reply
2018-05-25 11:39 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B08AD46.9020101@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=eric.auger@redhat.com \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.