From: Wei Xu <xuwei5@hisilicon.com>
To: John Stultz <john.stultz@linaro.org>, Ryan Grachek <ryan@edited.us>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Tony Lindgren <tony@atomide.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Eyal Reizer <eyalr@ti.com>, Rob Herring <robh+dt@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
Valentin Schneider <Valentin.Schneider@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: hikey: Define wl1835 power capabilities
Date: Tue, 26 Jun 2018 09:25:44 +0100 [thread overview]
Message-ID: <5B31F888.7010403@hisilicon.com> (raw)
In-Reply-To: <CALAqxLWjJKsU+XJmANzx-aO2ruszwbBnPV2yV5WoyVStO+5K0A@mail.gmail.com>
Hi John,
On 2018/6/25 22:56, John Stultz wrote:
> On Wed, Jun 13, 2018 at 11:30 AM, John Stultz <john.stultz@linaro.org> wrote:
>> On Wed, Jun 13, 2018 at 8:13 AM, Ryan Grachek <ryan@edited.us> wrote:
>>> These properties are required for compatibility with runtime PM.
>>> Without these properties, MMC host controller will not be aware
>>> of power capabilities. When the wlcore driver attempts to power
>>> on the device, it will erroneously fail with -EACCES.
>>>
>>> Signed-off-by: Ryan Grachek <ryan@edited.us>
>>
>> Fixes: 60f36637bbbd ("wlcore: sdio: allow pm to handle sdio power")
>> Tested-by: John Stultz <john.stultz@linaro.org>
>> Acked-by: John Stultz <john.stultz@linaro.org>
>>
>> Wei Xu: This fixes a functional regression with wifi on the HiKey
>> board that was introduced in 4.18-rc with commit 60f36637bbbd
>> ("wlcore: sdio: allow pm to handle sdio power").
>
> Wei Xu: Just wanted to follow up to make sure this wasn't missed for
> 4.18-rc, as I haven't seen it upstream or in -next, and it fixes a
> recently introduced regression.
Thanks!
I will send out the fix pull request in these two days if no problem.
Best Regards,
Wei
>
> thanks
> -john
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: xuwei5@hisilicon.com (Wei Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: hikey: Define wl1835 power capabilities
Date: Tue, 26 Jun 2018 09:25:44 +0100 [thread overview]
Message-ID: <5B31F888.7010403@hisilicon.com> (raw)
In-Reply-To: <CALAqxLWjJKsU+XJmANzx-aO2ruszwbBnPV2yV5WoyVStO+5K0A@mail.gmail.com>
Hi John,
On 2018/6/25 22:56, John Stultz wrote:
> On Wed, Jun 13, 2018 at 11:30 AM, John Stultz <john.stultz@linaro.org> wrote:
>> On Wed, Jun 13, 2018 at 8:13 AM, Ryan Grachek <ryan@edited.us> wrote:
>>> These properties are required for compatibility with runtime PM.
>>> Without these properties, MMC host controller will not be aware
>>> of power capabilities. When the wlcore driver attempts to power
>>> on the device, it will erroneously fail with -EACCES.
>>>
>>> Signed-off-by: Ryan Grachek <ryan@edited.us>
>>
>> Fixes: 60f36637bbbd ("wlcore: sdio: allow pm to handle sdio power")
>> Tested-by: John Stultz <john.stultz@linaro.org>
>> Acked-by: John Stultz <john.stultz@linaro.org>
>>
>> Wei Xu: This fixes a functional regression with wifi on the HiKey
>> board that was introduced in 4.18-rc with commit 60f36637bbbd
>> ("wlcore: sdio: allow pm to handle sdio power").
>
> Wei Xu: Just wanted to follow up to make sure this wasn't missed for
> 4.18-rc, as I haven't seen it upstream or in -next, and it fixes a
> recently introduced regression.
Thanks!
I will send out the fix pull request in these two days if no problem.
Best Regards,
Wei
>
> thanks
> -john
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: Wei Xu <xuwei5@hisilicon.com>
To: John Stultz <john.stultz@linaro.org>, Ryan Grachek <ryan@edited.us>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Tony Lindgren <tony@atomide.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Eyal Reizer <eyalr@ti.com>, Rob Herring <robh+dt@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
Valentin Schneider <Valentin.Schneider@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: hikey: Define wl1835 power capabilities
Date: Tue, 26 Jun 2018 09:25:44 +0100 [thread overview]
Message-ID: <5B31F888.7010403@hisilicon.com> (raw)
In-Reply-To: <CALAqxLWjJKsU+XJmANzx-aO2ruszwbBnPV2yV5WoyVStO+5K0A@mail.gmail.com>
Hi John,
On 2018/6/25 22:56, John Stultz wrote:
> On Wed, Jun 13, 2018 at 11:30 AM, John Stultz <john.stultz@linaro.org> wrote:
>> On Wed, Jun 13, 2018 at 8:13 AM, Ryan Grachek <ryan@edited.us> wrote:
>>> These properties are required for compatibility with runtime PM.
>>> Without these properties, MMC host controller will not be aware
>>> of power capabilities. When the wlcore driver attempts to power
>>> on the device, it will erroneously fail with -EACCES.
>>>
>>> Signed-off-by: Ryan Grachek <ryan@edited.us>
>>
>> Fixes: 60f36637bbbd ("wlcore: sdio: allow pm to handle sdio power")
>> Tested-by: John Stultz <john.stultz@linaro.org>
>> Acked-by: John Stultz <john.stultz@linaro.org>
>>
>> Wei Xu: This fixes a functional regression with wifi on the HiKey
>> board that was introduced in 4.18-rc with commit 60f36637bbbd
>> ("wlcore: sdio: allow pm to handle sdio power").
>
> Wei Xu: Just wanted to follow up to make sure this wasn't missed for
> 4.18-rc, as I haven't seen it upstream or in -next, and it fixes a
> recently introduced regression.
Thanks!
I will send out the fix pull request in these two days if no problem.
Best Regards,
Wei
>
> thanks
> -john
>
> .
>
next prev parent reply other threads:[~2018-06-26 8:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 15:13 [PATCH] arm64: dts: hikey: Define wl1835 power capabilities Ryan Grachek
2018-06-13 15:13 ` Ryan Grachek
2018-06-13 15:13 ` Ryan Grachek
2018-06-13 17:34 ` Valentin Schneider
2018-06-13 17:34 ` Valentin Schneider
2018-06-13 18:19 ` Ryan Grachek
2018-06-13 18:19 ` Ryan Grachek
2018-06-13 18:30 ` John Stultz
2018-06-13 18:30 ` John Stultz
2018-06-13 18:53 ` Kalle Valo
2018-06-13 18:53 ` Kalle Valo
2018-06-14 6:40 ` [EXTERNAL] " Reizer, Eyal
2018-06-14 6:40 ` Reizer, Eyal
2018-06-14 6:40 ` Reizer, Eyal
2018-06-14 6:40 ` Reizer, Eyal
2018-06-25 21:56 ` John Stultz
2018-06-25 21:56 ` John Stultz
2018-06-26 8:25 ` Wei Xu [this message]
2018-06-26 8:25 ` Wei Xu
2018-06-26 8:25 ` Wei Xu
2018-06-28 20:25 ` Wei Xu
2018-06-28 20:25 ` Wei Xu
2018-06-28 20:25 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B31F888.7010403@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=Valentin.Schneider@arm.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=eyalr@ti.com \
--cc=john.stultz@linaro.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ryan@edited.us \
--cc=tony@atomide.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.