* [PATCH] drm/amdgpu: remove duplicated codes
@ 2018-06-27 6:10 Flora Cui
[not found] ` <1530079813-4012-1-git-send-email-Flora.Cui-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Flora Cui @ 2018-06-27 6:10 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Flora Cui
Change-Id: Ic0dbd693bac093e54eb95b5e547c89b64a5743b8
Signed-off-by: Flora Cui <Flora.Cui@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
index a1c78f9..3a072a7 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
@@ -578,11 +578,6 @@ void amdgpu_vmid_mgr_init(struct amdgpu_device *adev)
list_add_tail(&id_mgr->ids[j].list, &id_mgr->ids_lru);
}
}
-
- adev->vm_manager.fence_context =
- dma_fence_context_alloc(AMDGPU_MAX_RINGS);
- for (i = 0; i < AMDGPU_MAX_RINGS; ++i)
- adev->vm_manager.seqno[i] = 0;
}
/**
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <1530079813-4012-1-git-send-email-Flora.Cui-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm/amdgpu: remove duplicated codes [not found] ` <1530079813-4012-1-git-send-email-Flora.Cui-5C7GfCeVMHo@public.gmane.org> @ 2018-06-27 6:37 ` Zhang, Jerry (Junwei) 2018-06-27 6:38 ` Zhou, David(ChunMing) 1 sibling, 0 replies; 5+ messages in thread From: Zhang, Jerry (Junwei) @ 2018-06-27 6:37 UTC (permalink / raw) To: Flora Cui, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On 06/27/2018 02:10 PM, Flora Cui wrote: > Change-Id: Ic0dbd693bac093e54eb95b5e547c89b64a5743b8 > Signed-off-by: Flora Cui <Flora.Cui@amd.com> Good catch. Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > index a1c78f9..3a072a7 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > @@ -578,11 +578,6 @@ void amdgpu_vmid_mgr_init(struct amdgpu_device *adev) > list_add_tail(&id_mgr->ids[j].list, &id_mgr->ids_lru); > } > } > - > - adev->vm_manager.fence_context = > - dma_fence_context_alloc(AMDGPU_MAX_RINGS); > - for (i = 0; i < AMDGPU_MAX_RINGS; ++i) > - adev->vm_manager.seqno[i] = 0; > } > > /** > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amdgpu: remove duplicated codes [not found] ` <1530079813-4012-1-git-send-email-Flora.Cui-5C7GfCeVMHo@public.gmane.org> 2018-06-27 6:37 ` Zhang, Jerry (Junwei) @ 2018-06-27 6:38 ` Zhou, David(ChunMing) [not found] ` <BY1PR12MB0502442618374EF8822D055CB4480-PicGAnIBOobrCwm+z9iKNgdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 1 sibling, 1 reply; 5+ messages in thread From: Zhou, David(ChunMing) @ 2018-06-27 6:38 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org; +Cc: Cui, Flora Please add patch's comment to describe where and where are duplicated. -----Original Message----- From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf Of Flora Cui Sent: Wednesday, June 27, 2018 2:10 PM To: amd-gfx@lists.freedesktop.org Cc: Cui, Flora <Flora.Cui@amd.com> Subject: [PATCH] drm/amdgpu: remove duplicated codes Change-Id: Ic0dbd693bac093e54eb95b5e547c89b64a5743b8 Signed-off-by: Flora Cui <Flora.Cui@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c index a1c78f9..3a072a7 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c @@ -578,11 +578,6 @@ void amdgpu_vmid_mgr_init(struct amdgpu_device *adev) list_add_tail(&id_mgr->ids[j].list, &id_mgr->ids_lru); } } - - adev->vm_manager.fence_context = - dma_fence_context_alloc(AMDGPU_MAX_RINGS); - for (i = 0; i < AMDGPU_MAX_RINGS; ++i) - adev->vm_manager.seqno[i] = 0; } /** -- 2.7.4 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 5+ messages in thread
[parent not found: <BY1PR12MB0502442618374EF8822D055CB4480-PicGAnIBOobrCwm+z9iKNgdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: [PATCH] drm/amdgpu: remove duplicated codes [not found] ` <BY1PR12MB0502442618374EF8822D055CB4480-PicGAnIBOobrCwm+z9iKNgdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2018-06-27 7:05 ` Flora Cui 2018-06-27 7:28 ` Zhou, David(ChunMing) 0 siblings, 1 reply; 5+ messages in thread From: Flora Cui @ 2018-06-27 7:05 UTC (permalink / raw) To: Zhou, David(ChunMing) Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org the fence_context and seqno is init in amdgpu_vm_manager_init() & amdgpu_vmid_mgr_init(). remove the amdgpu_vmid_mgr_init() copy. Change-Id: Ic0dbd693bac093e54eb95b5e547c89b64a5743b8 Signed-off-by: Flora Cui <Flora.Cui@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c index a1c78f9..3a072a7 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c @@ -578,11 +578,6 @@ void amdgpu_vmid_mgr_init(struct amdgpu_device *adev) list_add_tail(&id_mgr->ids[j].list, &id_mgr->ids_lru); } } - - adev->vm_manager.fence_context = - dma_fence_context_alloc(AMDGPU_MAX_RINGS); - for (i = 0; i < AMDGPU_MAX_RINGS; ++i) - adev->vm_manager.seqno[i] = 0; } /** -- 2.7.4 On Wed, Jun 27, 2018 at 02:38:09PM +0800, Zhou, David(ChunMing) wrote: > Please add patch's comment to describe where and where are duplicated. > > -----Original Message----- > From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf Of Flora Cui > Sent: Wednesday, June 27, 2018 2:10 PM > To: amd-gfx@lists.freedesktop.org > Cc: Cui, Flora <Flora.Cui@amd.com> > Subject: [PATCH] drm/amdgpu: remove duplicated codes > > Change-Id: Ic0dbd693bac093e54eb95b5e547c89b64a5743b8 > Signed-off-by: Flora Cui <Flora.Cui@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > index a1c78f9..3a072a7 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > @@ -578,11 +578,6 @@ void amdgpu_vmid_mgr_init(struct amdgpu_device *adev) > list_add_tail(&id_mgr->ids[j].list, &id_mgr->ids_lru); > } > } > - > - adev->vm_manager.fence_context = > - dma_fence_context_alloc(AMDGPU_MAX_RINGS); > - for (i = 0; i < AMDGPU_MAX_RINGS; ++i) > - adev->vm_manager.seqno[i] = 0; > } > > /** > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amdgpu: remove duplicated codes 2018-06-27 7:05 ` Flora Cui @ 2018-06-27 7:28 ` Zhou, David(ChunMing) 0 siblings, 0 replies; 5+ messages in thread From: Zhou, David(ChunMing) @ 2018-06-27 7:28 UTC (permalink / raw) To: Cui, Flora; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Feel free add my RB on that. Thanks, David Zhou -----Original Message----- From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf Of Flora Cui Sent: Wednesday, June 27, 2018 3:06 PM To: Zhou, David(ChunMing) <David1.Zhou@amd.com> Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: remove duplicated codes the fence_context and seqno is init in amdgpu_vm_manager_init() & amdgpu_vmid_mgr_init(). remove the amdgpu_vmid_mgr_init() copy. Change-Id: Ic0dbd693bac093e54eb95b5e547c89b64a5743b8 Signed-off-by: Flora Cui <Flora.Cui@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c index a1c78f9..3a072a7 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c @@ -578,11 +578,6 @@ void amdgpu_vmid_mgr_init(struct amdgpu_device *adev) list_add_tail(&id_mgr->ids[j].list, &id_mgr->ids_lru); } } - - adev->vm_manager.fence_context = - dma_fence_context_alloc(AMDGPU_MAX_RINGS); - for (i = 0; i < AMDGPU_MAX_RINGS; ++i) - adev->vm_manager.seqno[i] = 0; } /** -- 2.7.4 On Wed, Jun 27, 2018 at 02:38:09PM +0800, Zhou, David(ChunMing) wrote: > Please add patch's comment to describe where and where are duplicated. > > -----Original Message----- > From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf > Of Flora Cui > Sent: Wednesday, June 27, 2018 2:10 PM > To: amd-gfx@lists.freedesktop.org > Cc: Cui, Flora <Flora.Cui@amd.com> > Subject: [PATCH] drm/amdgpu: remove duplicated codes > > Change-Id: Ic0dbd693bac093e54eb95b5e547c89b64a5743b8 > Signed-off-by: Flora Cui <Flora.Cui@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > index a1c78f9..3a072a7 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > @@ -578,11 +578,6 @@ void amdgpu_vmid_mgr_init(struct amdgpu_device *adev) > list_add_tail(&id_mgr->ids[j].list, &id_mgr->ids_lru); > } > } > - > - adev->vm_manager.fence_context = > - dma_fence_context_alloc(AMDGPU_MAX_RINGS); > - for (i = 0; i < AMDGPU_MAX_RINGS; ++i) > - adev->vm_manager.seqno[i] = 0; > } > > /** > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-06-27 7:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-27 6:10 [PATCH] drm/amdgpu: remove duplicated codes Flora Cui
[not found] ` <1530079813-4012-1-git-send-email-Flora.Cui-5C7GfCeVMHo@public.gmane.org>
2018-06-27 6:37 ` Zhang, Jerry (Junwei)
2018-06-27 6:38 ` Zhou, David(ChunMing)
[not found] ` <BY1PR12MB0502442618374EF8822D055CB4480-PicGAnIBOobrCwm+z9iKNgdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-06-27 7:05 ` Flora Cui
2018-06-27 7:28 ` Zhou, David(ChunMing)
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.