* [PATCH] arm64: dts: hikey: Remove keep-power-in-suspend property
@ 2018-07-13 16:02 ` Ryan Grachek
0 siblings, 0 replies; 6+ messages in thread
From: Ryan Grachek @ 2018-07-13 16:02 UTC (permalink / raw)
Cc: john.stultz, Ryan Grachek, Wei Xu, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, linux-arm-kernel, devicetree,
linux-kernel
Remove the keep-power-in-suspend property because it keeps wifi power
on during suspend. This property is only required when enabling WoWLAN
and should only be enabled based on need.
Signed-off-by: Ryan Grachek <ryan@edited.us>
---
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
index 7f12624f6c8e..f4964bee6a1a 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
@@ -323,7 +323,6 @@
bus-width = <0x4>;
non-removable;
cap-power-off-card;
- keep-power-in-suspend;
vmmc-supply = <®_vdd_3v3>;
mmc-pwrseq = <&wl1835_pwrseq>;
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: hikey: Remove keep-power-in-suspend property
@ 2018-07-13 16:02 ` Ryan Grachek
0 siblings, 0 replies; 6+ messages in thread
From: Ryan Grachek @ 2018-07-13 16:02 UTC (permalink / raw)
Cc: john.stultz, Ryan Grachek, Wei Xu, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, linux-arm-kernel, devicetree,
linux-kernel
Remove the keep-power-in-suspend property because it keeps wifi power
on during suspend. This property is only required when enabling WoWLAN
and should only be enabled based on need.
Signed-off-by: Ryan Grachek <ryan@edited.us>
---
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
index 7f12624f6c8e..f4964bee6a1a 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
@@ -323,7 +323,6 @@
bus-width = <0x4>;
non-removable;
cap-power-off-card;
- keep-power-in-suspend;
vmmc-supply = <®_vdd_3v3>;
mmc-pwrseq = <&wl1835_pwrseq>;
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: hikey: Remove keep-power-in-suspend property
2018-07-13 16:02 ` Ryan Grachek
(?)
@ 2018-07-18 15:33 ` Wei Xu
-1 siblings, 0 replies; 6+ messages in thread
From: Wei Xu @ 2018-07-18 15:33 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ryan,
On 2018/7/13 17:02, Ryan Grachek wrote:
> Remove the keep-power-in-suspend property because it keeps wifi power
> on during suspend. This property is only required when enabling WoWLAN
> and should only be enabled based on need.
>
> Signed-off-by: Ryan Grachek <ryan@edited.us>
Thanks!
Applied to the hisilicon dt tree.
Best Regards,
Wei
> ---
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index 7f12624f6c8e..f4964bee6a1a 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -323,7 +323,6 @@
> bus-width = <0x4>;
> non-removable;
> cap-power-off-card;
> - keep-power-in-suspend;
> vmmc-supply = <®_vdd_3v3>;
> mmc-pwrseq = <&wl1835_pwrseq>;
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: hikey: Remove keep-power-in-suspend property
@ 2018-07-18 15:33 ` Wei Xu
0 siblings, 0 replies; 6+ messages in thread
From: Wei Xu @ 2018-07-18 15:33 UTC (permalink / raw)
To: Ryan Grachek
Cc: john.stultz, Rob Herring, Mark Rutland, Catalin Marinas,
Will Deacon, linux-arm-kernel, devicetree, linux-kernel
Hi Ryan,
On 2018/7/13 17:02, Ryan Grachek wrote:
> Remove the keep-power-in-suspend property because it keeps wifi power
> on during suspend. This property is only required when enabling WoWLAN
> and should only be enabled based on need.
>
> Signed-off-by: Ryan Grachek <ryan@edited.us>
Thanks!
Applied to the hisilicon dt tree.
Best Regards,
Wei
> ---
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index 7f12624f6c8e..f4964bee6a1a 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -323,7 +323,6 @@
> bus-width = <0x4>;
> non-removable;
> cap-power-off-card;
> - keep-power-in-suspend;
> vmmc-supply = <®_vdd_3v3>;
> mmc-pwrseq = <&wl1835_pwrseq>;
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: hikey: Remove keep-power-in-suspend property
@ 2018-07-18 15:33 ` Wei Xu
0 siblings, 0 replies; 6+ messages in thread
From: Wei Xu @ 2018-07-18 15:33 UTC (permalink / raw)
To: Ryan Grachek
Cc: john.stultz, Rob Herring, Mark Rutland, Catalin Marinas,
Will Deacon, linux-arm-kernel, devicetree, linux-kernel
Hi Ryan,
On 2018/7/13 17:02, Ryan Grachek wrote:
> Remove the keep-power-in-suspend property because it keeps wifi power
> on during suspend. This property is only required when enabling WoWLAN
> and should only be enabled based on need.
>
> Signed-off-by: Ryan Grachek <ryan@edited.us>
Thanks!
Applied to the hisilicon dt tree.
Best Regards,
Wei
> ---
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index 7f12624f6c8e..f4964bee6a1a 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -323,7 +323,6 @@
> bus-width = <0x4>;
> non-removable;
> cap-power-off-card;
> - keep-power-in-suspend;
> vmmc-supply = <®_vdd_3v3>;
> mmc-pwrseq = <&wl1835_pwrseq>;
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread