* [PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static
@ 2018-08-03 12:40 zhong jiang
2018-08-03 13:21 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: zhong jiang @ 2018-08-03 12:40 UTC (permalink / raw)
To: mingo, peterz, tglx, rostedt; +Cc: linux-kernel
Fix the following warning.
kernel/kthread.c:859:6: warning: symbol '__kthread_queue_delayed_work' was not declared. Should it be static?
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
kernel/kthread.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kthread.c b/kernel/kthread.c
index 087d18d..3c661a0 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -856,7 +856,7 @@ void kthread_delayed_work_timer_fn(struct timer_list *t)
}
EXPORT_SYMBOL(kthread_delayed_work_timer_fn);
-void __kthread_queue_delayed_work(struct kthread_worker *worker,
+static void __kthread_queue_delayed_work(struct kthread_worker *worker,
struct kthread_delayed_work *dwork,
unsigned long delay)
{
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static
2018-08-03 12:40 [PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static zhong jiang
@ 2018-08-03 13:21 ` Steven Rostedt
2018-08-05 13:34 ` zhong jiang
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2018-08-03 13:21 UTC (permalink / raw)
To: zhong jiang; +Cc: mingo, peterz, tglx, linux-kernel, trivial
On Fri, 3 Aug 2018 20:40:02 +0800
zhong jiang <zhongjiang@huawei.com> wrote:
> Fix the following warning.
>
> kernel/kthread.c:859:6: warning: symbol '__kthread_queue_delayed_work' was not declared. Should it be static?
This should go via the trivial tree.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> kernel/kthread.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kthread.c b/kernel/kthread.c
> index 087d18d..3c661a0 100644
> --- a/kernel/kthread.c
> +++ b/kernel/kthread.c
> @@ -856,7 +856,7 @@ void kthread_delayed_work_timer_fn(struct timer_list *t)
> }
> EXPORT_SYMBOL(kthread_delayed_work_timer_fn);
>
> -void __kthread_queue_delayed_work(struct kthread_worker *worker,
> +static void __kthread_queue_delayed_work(struct kthread_worker *worker,
> struct kthread_delayed_work *dwork,
> unsigned long delay)
Although, one could say you should align the parameters too, but that's
not a big deal. Anyway...
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static
2018-08-03 13:21 ` Steven Rostedt
@ 2018-08-05 13:34 ` zhong jiang
0 siblings, 0 replies; 3+ messages in thread
From: zhong jiang @ 2018-08-05 13:34 UTC (permalink / raw)
To: Steven Rostedt; +Cc: mingo, peterz, tglx, linux-kernel, trivial
On 2018/8/3 21:21, Steven Rostedt wrote:
> On Fri, 3 Aug 2018 20:40:02 +0800
> zhong jiang <zhongjiang@huawei.com> wrote:
>
>> Fix the following warning.
>>
>> kernel/kthread.c:859:6: warning: symbol '__kthread_queue_delayed_work' was not declared. Should it be static?
>
> This should go via the trivial tree.
>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>> kernel/kthread.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/kthread.c b/kernel/kthread.c
>> index 087d18d..3c661a0 100644
>> --- a/kernel/kthread.c
>> +++ b/kernel/kthread.c
>> @@ -856,7 +856,7 @@ void kthread_delayed_work_timer_fn(struct timer_list *t)
>> }
>> EXPORT_SYMBOL(kthread_delayed_work_timer_fn);
>>
>> -void __kthread_queue_delayed_work(struct kthread_worker *worker,
>> +static void __kthread_queue_delayed_work(struct kthread_worker *worker,
>> struct kthread_delayed_work *dwork,
>> unsigned long delay)
> Although, one could say you should align the parameters too, but that's
> not a big deal. Anyway...
>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Thanks , I will notice for next time.
> -- Steve
>
>> {
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-05 13:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-03 12:40 [PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static zhong jiang
2018-08-03 13:21 ` Steven Rostedt
2018-08-05 13:34 ` zhong jiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.