From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Peter Oh <peter.oh@bowerswilkins.com>,
Wen Gong <wgong@codeaurora.org>,
ath10k@lists.infradead.org, johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Change sk_pacing_shift in ieee80211_hw for best tx throughput
Date: Thu, 9 Aug 2018 11:32:44 +0200 [thread overview]
Message-ID: <5B6C0A3C.3020908@broadcom.com> (raw)
In-Reply-To: <4dbcc269-1f2b-b165-fe9e-8704fd77d1c5@bowerswilkins.com>
On 8/8/2018 9:00 PM, Peter Oh wrote:
>
>
> On 08/08/2018 03:40 AM, Wen Gong wrote:
>> Add a field for ath10k to adjust the sk_pacing_shift, mac80211 set
>> the default value to 8, and ath10k will change it to 6. Then mac80211
>> will use the changed value 6 as sk_pacing_shift since 6 is the best
>> value for tx throughput by test result.
> I don't think you can convince people with the numbers unless you
> provide latency along with the numbers and also measurement result on
> different chipsets as Michal addressed (QCA4019, QCA9984, etc.) From
> users view point, I also agree on Toke that we cannot scarify latency
> for the small throughput improvement.
Yeah. The wireless industry (admittedly that is me too :-p ) has been
focused on just throughput long enough. All the preaching about
bufferbloat from Dave and others is (just) starting to sink in here and
there.
Now as for the value of the sk_pacing_shift I think we agree it depends
on the specific device so in that sense the api makes sense, but I think
there are a lot of variables so I was wondering if we could introduce a
sysctl parameter for it. Does that make sense?
Regards,
Arend
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Peter Oh <peter.oh@bowerswilkins.com>,
Wen Gong <wgong@codeaurora.org>,
ath10k@lists.infradead.org, johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Change sk_pacing_shift in ieee80211_hw for best tx throughput
Date: Thu, 9 Aug 2018 11:32:44 +0200 [thread overview]
Message-ID: <5B6C0A3C.3020908@broadcom.com> (raw)
In-Reply-To: <4dbcc269-1f2b-b165-fe9e-8704fd77d1c5@bowerswilkins.com>
On 8/8/2018 9:00 PM, Peter Oh wrote:
>
>
> On 08/08/2018 03:40 AM, Wen Gong wrote:
>> Add a field for ath10k to adjust the sk_pacing_shift, mac80211 set
>> the default value to 8, and ath10k will change it to 6. Then mac80211
>> will use the changed value 6 as sk_pacing_shift since 6 is the best
>> value for tx throughput by test result.
> I don't think you can convince people with the numbers unless you
> provide latency along with the numbers and also measurement result on
> different chipsets as Michal addressed (QCA4019, QCA9984, etc.) From
> users view point, I also agree on Toke that we cannot scarify latency
> for the small throughput improvement.
Yeah. The wireless industry (admittedly that is me too :-p ) has been
focused on just throughput long enough. All the preaching about
bufferbloat from Dave and others is (just) starting to sink in here and
there.
Now as for the value of the sk_pacing_shift I think we agree it depends
on the specific device so in that sense the api makes sense, but I think
there are a lot of variables so I was wondering if we could introduce a
sysctl parameter for it. Does that make sense?
Regards,
Arend
next prev parent reply other threads:[~2018-08-09 9:32 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 10:40 [PATCH v2 0/2] Change sk_pacing_shift in ieee80211_hw for best tx throughput Wen Gong
2018-08-08 10:40 ` Wen Gong
2018-08-08 10:40 ` [PATCH v2 1/2] mac80211: Change sk_pacing_shift saved to ieee80211_hw Wen Gong
2018-08-08 10:40 ` Wen Gong
2018-08-08 10:40 ` [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips Wen Gong
2018-08-08 10:40 ` Wen Gong
2018-08-08 10:43 ` Toke Høiland-Jørgensen
2018-08-08 10:43 ` Toke Høiland-Jørgensen
2018-08-10 8:05 ` Wen Gong
2018-08-10 8:05 ` Wen Gong
2018-08-10 13:17 ` Toke Høiland-Jørgensen
2018-08-10 13:17 ` Toke Høiland-Jørgensen
2018-08-13 5:37 ` Wen Gong
2018-08-13 5:37 ` Wen Gong
2018-08-13 11:18 ` Toke Høiland-Jørgensen
2018-08-13 11:18 ` Toke Høiland-Jørgensen
2018-08-14 5:55 ` Wen Gong
2018-08-14 5:55 ` Wen Gong
2018-08-17 11:32 ` Toke Høiland-Jørgensen
2018-08-17 11:32 ` Toke Høiland-Jørgensen
2018-08-30 23:25 ` Peter Oh
2018-08-30 23:25 ` Peter Oh
2018-08-31 15:36 ` Toke Høiland-Jørgensen
2018-08-31 15:36 ` Toke Høiland-Jørgensen
2018-08-30 23:32 ` Grant Grundler
2018-09-03 9:38 ` Johannes Berg
2018-09-03 9:38 ` Johannes Berg
2018-09-03 11:11 ` Toke Høiland-Jørgensen
2018-09-03 11:11 ` Toke Høiland-Jørgensen
2018-09-03 11:47 ` Johannes Berg
2018-09-03 11:47 ` Johannes Berg
2018-09-03 13:35 ` Toke Høiland-Jørgensen
2018-09-03 13:35 ` Toke Høiland-Jørgensen
2018-09-03 14:57 ` Dave Taht
2018-09-03 14:57 ` Dave Taht
2018-09-03 15:35 ` Dave Taht
2018-09-03 15:35 ` Dave Taht
2018-09-04 23:43 ` Grant Grundler
2018-09-04 23:43 ` Grant Grundler
2018-09-05 7:23 ` Wen Gong
2018-09-05 7:23 ` Wen Gong
2018-09-06 10:18 ` Toke Høiland-Jørgensen
2018-09-06 10:18 ` Toke Høiland-Jørgensen
2019-02-20 19:15 ` Grant Grundler
2019-02-20 19:15 ` Grant Grundler
2019-02-21 4:39 ` Kalle Valo
2019-02-21 4:39 ` Kalle Valo
2019-02-21 15:42 ` Toke Høiland-Jørgensen
2019-02-21 15:42 ` Toke Høiland-Jørgensen
2019-02-21 16:10 ` Kalle Valo
2019-02-21 16:10 ` Kalle Valo
2019-02-21 16:22 ` Ben Greear
2019-02-21 16:22 ` Ben Greear
2019-02-21 16:37 ` Toke Høiland-Jørgensen
2019-02-21 16:37 ` Toke Høiland-Jørgensen
2019-02-21 16:57 ` Ben Greear
2019-02-21 16:57 ` Ben Greear
2019-02-21 17:15 ` Toke Høiland-Jørgensen
2019-02-21 17:15 ` Toke Høiland-Jørgensen
2019-02-21 17:29 ` [PATCH] mac80211: Change default tx_sk_pacing_shift to 7 Toke Høiland-Jørgensen
2019-02-21 17:29 ` Toke Høiland-Jørgensen
2019-02-22 12:29 ` Johannes Berg
2019-02-22 13:06 ` Toke Høiland-Jørgensen
2019-02-22 13:06 ` Toke Høiland-Jørgensen
2019-02-22 13:07 ` Johannes Berg
2019-02-22 13:07 ` Johannes Berg
2019-02-22 13:40 ` Toke Høiland-Jørgensen
2019-02-22 13:40 ` Toke Høiland-Jørgensen
2019-02-22 19:10 ` Johannes Berg
2019-02-22 19:10 ` Johannes Berg
2019-02-23 11:49 ` Toke Høiland-Jørgensen
2019-02-23 11:49 ` Toke Høiland-Jørgensen
2019-02-21 17:29 ` [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips Ben Greear
2019-02-21 17:29 ` Ben Greear
2019-02-21 22:50 ` Toke Høiland-Jørgensen
2019-02-21 22:50 ` Toke Høiland-Jørgensen
2019-02-21 16:28 ` Toke Høiland-Jørgensen
2019-02-21 16:28 ` Toke Høiland-Jørgensen
2020-04-23 6:31 ` Kalle Valo
2020-04-23 6:31 ` Kalle Valo
2018-08-08 19:00 ` [PATCH v2 0/2] Change sk_pacing_shift in ieee80211_hw for best tx throughput Peter Oh
2018-08-08 19:00 ` Peter Oh
2018-08-09 9:32 ` Arend van Spriel [this message]
2018-08-09 9:32 ` Arend van Spriel
2018-08-10 13:20 ` Toke Høiland-Jørgensen
2018-08-10 13:20 ` Toke Høiland-Jørgensen
2018-08-10 19:28 ` Arend van Spriel
2018-08-10 19:28 ` Arend van Spriel
2018-08-10 19:52 ` Ben Greear
2018-08-10 19:52 ` Ben Greear
2018-08-11 19:21 ` Arend van Spriel
2018-08-11 19:21 ` Arend van Spriel
2018-08-20 12:46 ` Toke Høiland-Jørgensen
2018-08-20 12:46 ` Toke Høiland-Jørgensen
2018-08-20 15:14 ` Ben Greear
2018-08-20 15:14 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B6C0A3C.3020908@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=ath10k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=peter.oh@bowerswilkins.com \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.