KFD co-maintainership and branch model

KFD co-maintainership and branch model

[Felix Kuehling]

Hi all,

Oded has offered to make me co-maintainer of KFD, as he's super busy at
work and less responsive than he used to be.

At the same time we're about to send out the first patches to merge KFD
and AMDGPU into a single kernel module.

With that in mind I'd like to propose to upstream KFD through Alex's
branch in the future. It would avoid conflicts in shared code
(amdgpu_vm.c is most active at the moment) when merging branches, and
make the code flow and testing easier.

Please let me know what you think?

Regards,
  Felix

-- 
F e l i x   K u e h l i n g
PMTS Software Development Engineer | Linux Compute Kernel
1 Commerce Valley Dr. East, Markham, ON L3T 7X6 Canada
(O) +1(289)695-1597
   _     _   _   _____   _____
  / \   | \ / | |  _  \  \ _  |
 / A \  | \M/ | | |D) )  /|_| |
/_/ \_\ |_| |_| |_____/ |__/ \|   facebook.com/AMD | amd.com

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: KFD co-maintainership and branch model

[David Airlie]

On Thu, Aug 23, 2018 at 8:25 AM, Felix Kuehling <felix.kuehling@amd.com> wrote:
> Hi all,
>
> Oded has offered to make me co-maintainer of KFD, as he's super busy at
> work and less responsive than he used to be.
>
> At the same time we're about to send out the first patches to merge KFD
> and AMDGPU into a single kernel module.
>
> With that in mind I'd like to propose to upstream KFD through Alex's
> branch in the future. It would avoid conflicts in shared code
> (amdgpu_vm.c is most active at the moment) when merging branches, and
> make the code flow and testing easier.
>
> Please let me know what you think?
>

Works for me.

Thanks,
Dave.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: KFD co-maintainership and branch model

[Oded Gabbay]

On Thu, Aug 23, 2018 at 4:34 AM David Airlie <airlied@redhat.com> wrote:
>
> On Thu, Aug 23, 2018 at 8:25 AM, Felix Kuehling <felix.kuehling@amd.com> wrote:
> > Hi all,
> >
> > Oded has offered to make me co-maintainer of KFD, as he's super busy at
> > work and less responsive than he used to be.
> >
> > At the same time we're about to send out the first patches to merge KFD
> > and AMDGPU into a single kernel module.
> >
> > With that in mind I'd like to propose to upstream KFD through Alex's
> > branch in the future. It would avoid conflicts in shared code
> > (amdgpu_vm.c is most active at the moment) when merging branches, and
> > make the code flow and testing easier.
> >
> > Please let me know what you think?
> >
>
> Works for me.
>
> Thanks,
> Dave.

Works for me as well.

Oded
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: KFD co-maintainership and branch model

[Christian König]

Am 23.08.2018 um 08:54 schrieb Oded Gabbay:
> On Thu, Aug 23, 2018 at 4:34 AM David Airlie <airlied@redhat.com> wrote:
>> On Thu, Aug 23, 2018 at 8:25 AM, Felix Kuehling <felix.kuehling@amd.com> wrote:
>>> Hi all,
>>>
>>> Oded has offered to make me co-maintainer of KFD, as he's super busy at
>>> work and less responsive than he used to be.
>>>
>>> At the same time we're about to send out the first patches to merge KFD
>>> and AMDGPU into a single kernel module.
>>>
>>> With that in mind I'd like to propose to upstream KFD through Alex's
>>> branch in the future. It would avoid conflicts in shared code
>>> (amdgpu_vm.c is most active at the moment) when merging branches, and
>>> make the code flow and testing easier.
>>>
>>> Please let me know what you think?
>>>
>> Works for me.
>>
>> Thanks,
>> Dave.
> Works for me as well.

Sounds good to me as well.

Christian.

>
> Oded
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: KFD co-maintainership and branch model

[Deucher, Alexander]

> -----Original Message-----
> From: Christian König <ckoenig.leichtzumerken@gmail.com>
> Sent: Thursday, August 23, 2018 3:01 AM
> To: Oded Gabbay <oded.gabbay@gmail.com>; Dave Airlie
> <airlied@redhat.com>
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Kuehling, Felix
> <Felix.Kuehling@amd.com>; amd-gfx list <amd-gfx@lists.freedesktop.org>
> Subject: Re: KFD co-maintainership and branch model
> 
> Am 23.08.2018 um 08:54 schrieb Oded Gabbay:
> > On Thu, Aug 23, 2018 at 4:34 AM David Airlie <airlied@redhat.com> wrote:
> >> On Thu, Aug 23, 2018 at 8:25 AM, Felix Kuehling
> <felix.kuehling@amd.com> wrote:
> >>> Hi all,
> >>>
> >>> Oded has offered to make me co-maintainer of KFD, as he's super busy
> >>> at work and less responsive than he used to be.
> >>>
> >>> At the same time we're about to send out the first patches to merge
> >>> KFD and AMDGPU into a single kernel module.
> >>>
> >>> With that in mind I'd like to propose to upstream KFD through Alex's
> >>> branch in the future. It would avoid conflicts in shared code
> >>> (amdgpu_vm.c is most active at the moment) when merging branches,
> >>> and make the code flow and testing easier.
> >>>
> >>> Please let me know what you think?
> >>>
> >> Works for me.
> >>
> >> Thanks,
> >> Dave.
> > Works for me as well.
> 
> Sounds good to me as well.

Works for me as well.

Alex

> 
> Christian.
> 
> >
> > Oded
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: KFD co-maintainership and branch model

[Felix Kuehling]

On 2018-08-23 08:38 AM, Deucher, Alexander wrote:
>> -----Original Message-----
>> From: Christian König <ckoenig.leichtzumerken@gmail.com>
>> Sent: Thursday, August 23, 2018 3:01 AM
>> To: Oded Gabbay <oded.gabbay@gmail.com>; Dave Airlie
>> <airlied@redhat.com>
>> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Kuehling, Felix
>> <Felix.Kuehling@amd.com>; amd-gfx list <amd-gfx@lists.freedesktop.org>
>> Subject: Re: KFD co-maintainership and branch model
>>
>> Am 23.08.2018 um 08:54 schrieb Oded Gabbay:
>>> On Thu, Aug 23, 2018 at 4:34 AM David Airlie <airlied@redhat.com> wrote:
>>>> On Thu, Aug 23, 2018 at 8:25 AM, Felix Kuehling
>> <felix.kuehling@amd.com> wrote:
>>>>> Hi all,
>>>>>
>>>>> Oded has offered to make me co-maintainer of KFD, as he's super busy
>>>>> at work and less responsive than he used to be.
>>>>>
>>>>> At the same time we're about to send out the first patches to merge
>>>>> KFD and AMDGPU into a single kernel module.
>>>>>
>>>>> With that in mind I'd like to propose to upstream KFD through Alex's
>>>>> branch in the future. It would avoid conflicts in shared code
>>>>> (amdgpu_vm.c is most active at the moment) when merging branches,
>>>>> and make the code flow and testing easier.
>>>>>
>>>>> Please let me know what you think?
>>>>>
>>>> Works for me.
>>>>
>>>> Thanks,
>>>> Dave.
>>> Works for me as well.
>> Sounds good to me as well.
> Works for me as well.

Thank you. We have agreement.

Right now KFD in amd-staging-drm-next is a bit behind what's drm-next.
Alex, are you planning to rebase amd-staging-drm-next soon? If not, I'd
like to cherry-pick the missing commits before applying anything new.

Regards,
  Felix

>
> Alex
>
>> Christian.
>>
>>> Oded
>>> _______________________________________________
>>> amd-gfx mailing list
>>> amd-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: KFD co-maintainership and branch model

[Deucher, Alexander]

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Felix
> Kuehling
> Sent: Friday, August 24, 2018 5:58 PM
> To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; Oded Gabbay <oded.gabbay@gmail.com>;
> Dave Airlie <airlied@redhat.com>
> Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>
> Subject: Re: KFD co-maintainership and branch model
> 
> On 2018-08-23 08:38 AM, Deucher, Alexander wrote:
> >> -----Original Message-----
> >> From: Christian König <ckoenig.leichtzumerken@gmail.com>
> >> Sent: Thursday, August 23, 2018 3:01 AM
> >> To: Oded Gabbay <oded.gabbay@gmail.com>; Dave Airlie
> >> <airlied@redhat.com>
> >> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Kuehling, Felix
> >> <Felix.Kuehling@amd.com>; amd-gfx list
> >> <amd-gfx@lists.freedesktop.org>
> >> Subject: Re: KFD co-maintainership and branch model
> >>
> >> Am 23.08.2018 um 08:54 schrieb Oded Gabbay:
> >>> On Thu, Aug 23, 2018 at 4:34 AM David Airlie <airlied@redhat.com>
> wrote:
> >>>> On Thu, Aug 23, 2018 at 8:25 AM, Felix Kuehling
> >> <felix.kuehling@amd.com> wrote:
> >>>>> Hi all,
> >>>>>
> >>>>> Oded has offered to make me co-maintainer of KFD, as he's super
> >>>>> busy at work and less responsive than he used to be.
> >>>>>
> >>>>> At the same time we're about to send out the first patches to
> >>>>> merge KFD and AMDGPU into a single kernel module.
> >>>>>
> >>>>> With that in mind I'd like to propose to upstream KFD through
> >>>>> Alex's branch in the future. It would avoid conflicts in shared
> >>>>> code (amdgpu_vm.c is most active at the moment) when merging
> >>>>> branches, and make the code flow and testing easier.
> >>>>>
> >>>>> Please let me know what you think?
> >>>>>
> >>>> Works for me.
> >>>>
> >>>> Thanks,
> >>>> Dave.
> >>> Works for me as well.
> >> Sounds good to me as well.
> > Works for me as well.
> 
> Thank you. We have agreement.
> 
> Right now KFD in amd-staging-drm-next is a bit behind what's drm-next.
> Alex, are you planning to rebase amd-staging-drm-next soon? If not, I'd like
> to cherry-pick the missing commits before applying anything new.
> 

Yes.  I can update it this week.

Alex

> Regards,
>   Felix
> 
> >
> > Alex
> >
> >> Christian.
> >>
> >>> Oded
> >>> _______________________________________________
> >>> amd-gfx mailing list
> >>> amd-gfx@lists.freedesktop.org
> >>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: KFD co-maintainership and branch model

[Zhang, Jerry (Junwei)]

On 08/23/2018 06:25 AM, Felix Kuehling wrote:
> Hi all,
>
> Oded has offered to make me co-maintainer of KFD, as he's super busy at
> work and less responsive than he used to be.
>
> At the same time we're about to send out the first patches to merge KFD
> and AMDGPU into a single kernel module.
>
> With that in mind I'd like to propose to upstream KFD through Alex's
> branch in the future. It would avoid conflicts in shared code
> (amdgpu_vm.c is most active at the moment) when merging branches, and
> make the code flow and testing easier.
>
> Please let me know what you think?

Shall we share the same style as DC upstream in amdgpu?

For the common code like amdgpu_vm.c, it's ideally to work for both KFD and amdgpu gfx.
If a patch impacts gfx performance but improves compute ability, we may reserve that
as a hybrid patch for production release only.

Regards,
Jerry

>
> Regards,
>    Felix
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx