[PATCH 0/3]: iscsi target login fixes

[PATCH 0/3]: iscsi target login fixes

[Mike Christie]

The following patchset is a round up of login fixes that have been
on the list and in Mathew's tree. They fix a couple of bugs in the
iscsi login failure handling path.

The patches were made against Martin's 4.19/scsi-queue branch.

Matthew, the first patch is one that I had sent to you that had a fix
for the idr issue you asked about on the list. There was a conflict so
I had to update the patch. I was not sure if you wanted me to keep
your signed off so to be safe I dropped it.

Also, it sounded like your ida/idr patches were not going to make 4.19,
so hopefully the idr iscsi login fix will be merged already when your
patches get merged for 4.20, so you do not have to carry it anymore.

Re: [PATCH 0/3]: iscsi target login fixes

[Matthew Wilcox]

On Fri, Aug 24, 2018 at 01:37:10PM -0500, Mike Christie wrote:
> The following patchset is a round up of login fixes that have been
> on the list and in Mathew's tree. They fix a couple of bugs in the
> iscsi login failure handling path.
> 
> The patches were made against Martin's 4.19/scsi-queue branch.
> 
> Matthew, the first patch is one that I had sent to you that had a fix
> for the idr issue you asked about on the list. There was a conflict so
> I had to update the patch. I was not sure if you wanted me to keep
> your signed off so to be safe I dropped it.

It should at least have my Reported-by: on it ;-)

But I did review the patch, and it LGTM, so Martin, please include my
Signed-off-by: on patch 1/3.

> Also, it sounded like your ida/idr patches were not going to make 4.19,
> so hopefully the idr iscsi login fix will be merged already when your
> patches get merged for 4.20, so you do not have to carry it anymore.

I'll leave it in my tree for now and drop it again once these fixes are
merged, otherwise I'll have to resolve a marge conflict twice.

Re: [PATCH 0/3]: iscsi target login fixes

[Matthew Wilcox]

On Fri, Aug 24, 2018 at 01:37:10PM -0500, Mike Christie wrote:
> The following patchset is a round up of login fixes that have been
> on the list and in Mathew's tree. They fix a couple of bugs in the
> iscsi login failure handling path.
> 
> The patches were made against Martin's 4.19/scsi-queue branch.
> 
> Matthew, the first patch is one that I had sent to you that had a fix
> for the idr issue you asked about on the list. There was a conflict so
> I had to update the patch. I was not sure if you wanted me to keep
> your signed off so to be safe I dropped it.
> 
> Also, it sounded like your ida/idr patches were not going to make 4.19,
> so hopefully the idr iscsi login fix will be merged already when your
> patches get merged for 4.20, so you do not have to carry it anymore.

Christmas came early, and Linus decided to pull the updated ida patches.

commit 26abc916a898d34c5ad159315a2f683def3c5555
Author: Mike Christie <mchristi@redhat.com>
Date:   Thu Jul 26 12:13:49 2018 -0500

    iscsi target: fix session creation failure handling

so patch 1 does not need to be added to v4.19/scsi-queue

Re: [PATCH 0/3]: iscsi target login fixes

[Mike Christie]

On 08/27/2018 12:03 AM, Matthew Wilcox wrote:
> On Fri, Aug 24, 2018 at 01:37:10PM -0500, Mike Christie wrote:
>> The following patchset is a round up of login fixes that have been
>> on the list and in Mathew's tree. They fix a couple of bugs in the
>> iscsi login failure handling path.
>>
>> The patches were made against Martin's 4.19/scsi-queue branch.
>>
>> Matthew, the first patch is one that I had sent to you that had a fix
>> for the idr issue you asked about on the list. There was a conflict so
>> I had to update the patch. I was not sure if you wanted me to keep
>> your signed off so to be safe I dropped it.
>>
>> Also, it sounded like your ida/idr patches were not going to make 4.19,
>> so hopefully the idr iscsi login fix will be merged already when your
>> patches get merged for 4.20, so you do not have to carry it anymore.
> 
> Christmas came early, and Linus decided to pull the updated ida patches.
> 
> commit 26abc916a898d34c5ad159315a2f683def3c5555
> Author: Mike Christie <mchristi@redhat.com>
> Date:   Thu Jul 26 12:13:49 2018 -0500
> 
>     iscsi target: fix session creation failure handling
> 
> so patch 1 does not need to be added to v4.19/scsi-queue
> 

Martin,

I will remake and resend the last 2 patches against the current Linus
tree, because the second patch does not cleanly apply against the
idr/ida changes.

Re: [PATCH 0/3]: iscsi target login fixes

[Martin K. Petersen]

Mike,

> I will remake and resend the last 2 patches against the current Linus
> tree, because the second patch does not cleanly apply against the
> idr/ida changes.

Sounds good. Just getting the new SCSI trees ready...

-- 
Martin K. Petersen	Oracle Linux Engineering