From: zhong jiang <zhongjiang@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.com, perex@perex.cz, lgirdwood@gmail.com,
bgoswami@codeaurora.org, plai@codeaurora.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] sound: q6core: Use kmemdup to replace kzalloc + memcpy
Date: Tue, 11 Sep 2018 09:13:58 +0800 [thread overview]
Message-ID: <5B9716D6.8020307@huawei.com> (raw)
In-Reply-To: <20180910141928.GI5856@sirena.org.uk>
On 2018/9/10 22:19, Mark Brown wrote:
> On Sat, Sep 08, 2018 at 04:36:19PM +0800, zhong jiang wrote:
>> kmemdup has implemented the function that kzalloc() + memcpy() will
>> do. and we prefer to use the kmemdup rather than the open coded implementation.
> Please submit patches using subject lines reflecting the style for the
> subsystem. This makes it easier for people to identify relevant
> patches. Look at what existing commits in the area you're changing are
> doing and make sure your subject lines visually resemble what they're
> doing.
I will notice this next time. Thanks
Sincerely,
zhong jiang
WARNING: multiple messages have this Message-ID (diff)
From: zhong jiang <zhongjiang@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: <tiwai@suse.com>, <perex@perex.cz>, <lgirdwood@gmail.com>,
<bgoswami@codeaurora.org>, <plai@codeaurora.org>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] sound: q6core: Use kmemdup to replace kzalloc + memcpy
Date: Tue, 11 Sep 2018 09:13:58 +0800 [thread overview]
Message-ID: <5B9716D6.8020307@huawei.com> (raw)
In-Reply-To: <20180910141928.GI5856@sirena.org.uk>
On 2018/9/10 22:19, Mark Brown wrote:
> On Sat, Sep 08, 2018 at 04:36:19PM +0800, zhong jiang wrote:
>> kmemdup has implemented the function that kzalloc() + memcpy() will
>> do. and we prefer to use the kmemdup rather than the open coded implementation.
> Please submit patches using subject lines reflecting the style for the
> subsystem. This makes it easier for people to identify relevant
> patches. Look at what existing commits in the area you're changing are
> doing and make sure your subject lines visually resemble what they're
> doing.
I will notice this next time. Thanks
Sincerely,
zhong jiang
next prev parent reply other threads:[~2018-09-11 1:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 8:36 [PATCH 0/2] sound: Use kmemdup to replace kzalloc + memcpy zhong jiang
2018-09-08 8:36 ` zhong jiang
2018-09-08 8:36 ` [PATCH 1/2] sound: q6core: " zhong jiang
2018-09-08 8:36 ` zhong jiang
2018-09-10 14:19 ` Mark Brown
2018-09-10 14:19 ` Mark Brown
2018-09-11 1:13 ` zhong jiang [this message]
2018-09-11 1:13 ` zhong jiang
2018-09-08 8:36 ` [PATCH 2/2] sound: skl-topology: " zhong jiang
2018-09-08 8:36 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B9716D6.8020307@huawei.com \
--to=zhongjiang@huawei.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.