* [PATCH] gpu: do not double put device node in zx_drm_probe
@ 2018-08-17 2:24 ` zhong jiang
0 siblings, 0 replies; 17+ messages in thread
From: zhong jiang @ 2018-08-17 2:24 UTC (permalink / raw)
To: shawnguo, airlied; +Cc: dri-devel, linux-kernel
for_each_available_child_of_node will get and put the node properly,
the following of_node_put will lead to the double put. So just
remove it.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/gpu/drm/zte/zx_drm_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
index 6f4205e8..d7b9870 100644
--- a/drivers/gpu/drm/zte/zx_drm_drv.c
+++ b/drivers/gpu/drm/zte/zx_drm_drv.c
@@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev)
if (ret)
return ret;
- for_each_available_child_of_node(parent, child) {
+ for_each_available_child_of_node(parent, child)
component_match_add(dev, &match, compare_of, child);
- of_node_put(child);
- }
return component_master_add_with_match(dev, &zx_drm_master_ops, match);
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
2018-08-17 2:24 ` zhong jiang
@ 2018-08-23 11:41 ` zhong jiang
-1 siblings, 0 replies; 17+ messages in thread
From: zhong jiang @ 2018-08-23 11:41 UTC (permalink / raw)
To: shawnguo, airlied; +Cc: dri-devel, linux-kernel
Ping, Anyone has any objections a about the patch?
Best wishes,
zhong jiang
On 2018/8/17 10:24, zhong jiang wrote:
> for_each_available_child_of_node will get and put the node properly,
> the following of_node_put will lead to the double put. So just
> remove it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/gpu/drm/zte/zx_drm_drv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
> index 6f4205e8..d7b9870 100644
> --- a/drivers/gpu/drm/zte/zx_drm_drv.c
> +++ b/drivers/gpu/drm/zte/zx_drm_drv.c
> @@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - for_each_available_child_of_node(parent, child) {
> + for_each_available_child_of_node(parent, child)
> component_match_add(dev, &match, compare_of, child);
> - of_node_put(child);
> - }
>
> return component_master_add_with_match(dev, &zx_drm_master_ops, match);
> }
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
@ 2018-08-23 11:41 ` zhong jiang
0 siblings, 0 replies; 17+ messages in thread
From: zhong jiang @ 2018-08-23 11:41 UTC (permalink / raw)
To: shawnguo, airlied; +Cc: dri-devel, linux-kernel
Ping, Anyone has any objections a about the patch?
Best wishes,
zhong jiang
On 2018/8/17 10:24, zhong jiang wrote:
> for_each_available_child_of_node will get and put the node properly,
> the following of_node_put will lead to the double put. So just
> remove it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/gpu/drm/zte/zx_drm_drv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
> index 6f4205e8..d7b9870 100644
> --- a/drivers/gpu/drm/zte/zx_drm_drv.c
> +++ b/drivers/gpu/drm/zte/zx_drm_drv.c
> @@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - for_each_available_child_of_node(parent, child) {
> + for_each_available_child_of_node(parent, child)
> component_match_add(dev, &match, compare_of, child);
> - of_node_put(child);
> - }
>
> return component_master_add_with_match(dev, &zx_drm_master_ops, match);
> }
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
2018-08-17 2:24 ` zhong jiang
(?)
(?)
@ 2018-08-27 7:18 ` Shawn Guo
2018-09-18 15:19 ` Daniel Vetter
-1 siblings, 1 reply; 17+ messages in thread
From: Shawn Guo @ 2018-08-27 7:18 UTC (permalink / raw)
To: zhong jiang; +Cc: airlied, dri-devel, linux-kernel
On Fri, Aug 17, 2018 at 10:24:06AM +0800, zhong jiang wrote:
> for_each_available_child_of_node will get and put the node properly,
> the following of_node_put will lead to the double put. So just
> remove it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Acked-by: Shawn Guo <shawnguo@kernel.org>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
2018-08-27 7:18 ` Shawn Guo
@ 2018-09-18 15:19 ` Daniel Vetter
0 siblings, 0 replies; 17+ messages in thread
From: Daniel Vetter @ 2018-09-18 15:19 UTC (permalink / raw)
To: Shawn Guo; +Cc: Dave Airlie, zhong jiang, Linux Kernel Mailing List, dri-devel
On Mon, Aug 27, 2018 at 9:18 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Fri, Aug 17, 2018 at 10:24:06AM +0800, zhong jiang wrote:
>> for_each_available_child_of_node will get and put the node properly,
>> the following of_node_put will lead to the double put. So just
>> remove it.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>
> Acked-by: Shawn Guo <shawnguo@kernel.org>
Shawn, I'm assuming you'll push this to drm-misc-next? You're the
maintainer with commit rights after all.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
@ 2018-09-18 15:19 ` Daniel Vetter
0 siblings, 0 replies; 17+ messages in thread
From: Daniel Vetter @ 2018-09-18 15:19 UTC (permalink / raw)
To: Shawn Guo; +Cc: zhong jiang, Dave Airlie, Linux Kernel Mailing List, dri-devel
On Mon, Aug 27, 2018 at 9:18 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Fri, Aug 17, 2018 at 10:24:06AM +0800, zhong jiang wrote:
>> for_each_available_child_of_node will get and put the node properly,
>> the following of_node_put will lead to the double put. So just
>> remove it.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>
> Acked-by: Shawn Guo <shawnguo@kernel.org>
Shawn, I'm assuming you'll push this to drm-misc-next? You're the
maintainer with commit rights after all.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
2018-09-18 15:19 ` Daniel Vetter
(?)
@ 2018-09-19 21:32 ` Shawn Guo
-1 siblings, 0 replies; 17+ messages in thread
From: Shawn Guo @ 2018-09-19 21:32 UTC (permalink / raw)
To: Daniel Vetter
Cc: zhong jiang, Dave Airlie, Linux Kernel Mailing List, dri-devel
On Tue, Sep 18, 2018 at 05:19:09PM +0200, Daniel Vetter wrote:
> On Mon, Aug 27, 2018 at 9:18 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> > On Fri, Aug 17, 2018 at 10:24:06AM +0800, zhong jiang wrote:
> >> for_each_available_child_of_node will get and put the node properly,
> >> the following of_node_put will lead to the double put. So just
> >> remove it.
> >>
> >> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> >
> > Acked-by: Shawn Guo <shawnguo@kernel.org>
>
> Shawn, I'm assuming you'll push this to drm-misc-next? You're the
> maintainer with commit rights after all.
Just pushed to drm-misc-next. Sorry for the delay.
Shawn
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
2018-08-17 2:24 ` zhong jiang
@ 2018-09-06 14:51 ` zhong jiang
-1 siblings, 0 replies; 17+ messages in thread
From: zhong jiang @ 2018-09-06 14:51 UTC (permalink / raw)
To: shawnguo, airlied, noralf, daniel.vetter; +Cc: dri-devel, linux-kernel
+to maintainer.
On 2018/8/17 10:24, zhong jiang wrote:
> for_each_available_child_of_node will get and put the node properly,
> the following of_node_put will lead to the double put. So just
> remove it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>gg
> ---
> drivers/gpu/drm/zte/zx_drm_drv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
> index 6f4205e8..d7b9870 100644
> --- a/drivers/gpu/drm/zte/zx_drm_drv.c
> +++ b/drivers/gpu/drm/zte/zx_drm_drv.c
> @@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - for_each_available_child_of_node(parent, child) {
> + for_each_available_child_of_node(parent, child)
> component_match_add(dev, &match, compare_of, child);
> - of_node_put(child);
> - }
>
> return component_master_add_with_match(dev, &zx_drm_master_ops, match);
> }
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
@ 2018-09-06 14:51 ` zhong jiang
0 siblings, 0 replies; 17+ messages in thread
From: zhong jiang @ 2018-09-06 14:51 UTC (permalink / raw)
To: shawnguo, airlied, noralf, daniel.vetter; +Cc: dri-devel, linux-kernel
+to maintainer.
On 2018/8/17 10:24, zhong jiang wrote:
> for_each_available_child_of_node will get and put the node properly,
> the following of_node_put will lead to the double put. So just
> remove it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>gg
> ---
> drivers/gpu/drm/zte/zx_drm_drv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
> index 6f4205e8..d7b9870 100644
> --- a/drivers/gpu/drm/zte/zx_drm_drv.c
> +++ b/drivers/gpu/drm/zte/zx_drm_drv.c
> @@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - for_each_available_child_of_node(parent, child) {
> + for_each_available_child_of_node(parent, child)
> component_match_add(dev, &match, compare_of, child);
> - of_node_put(child);
> - }
>
> return component_master_add_with_match(dev, &zx_drm_master_ops, match);
> }
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
2018-08-17 2:24 ` zhong jiang
@ 2018-09-18 14:59 ` zhong jiang
-1 siblings, 0 replies; 17+ messages in thread
From: zhong jiang @ 2018-09-18 14:59 UTC (permalink / raw)
To: Greg KH; +Cc: shawnguo, airlied, dri-devel, linux-kernel
Hi, Greg
Can you pick up the patch?
Thanks,
zhong jiang
On 2018/8/17 10:24, zhong jiang wrote:
> for_each_available_child_of_node will get and put the node properly,
> the following of_node_put will lead to the double put. So just
> remove it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/gpu/drm/zte/zx_drm_drv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
> index 6f4205e8..d7b9870 100644
> --- a/drivers/gpu/drm/zte/zx_drm_drv.c
> +++ b/drivers/gpu/drm/zte/zx_drm_drv.c
> @@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - for_each_available_child_of_node(parent, child) {
> + for_each_available_child_of_node(parent, child)
> component_match_add(dev, &match, compare_of, child);
> - of_node_put(child);
> - }
>
> return component_master_add_with_match(dev, &zx_drm_master_ops, match);
> }
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
@ 2018-09-18 14:59 ` zhong jiang
0 siblings, 0 replies; 17+ messages in thread
From: zhong jiang @ 2018-09-18 14:59 UTC (permalink / raw)
To: Greg KH; +Cc: shawnguo, airlied, dri-devel, linux-kernel
Hi, Greg
Can you pick up the patch?
Thanks,
zhong jiang
On 2018/8/17 10:24, zhong jiang wrote:
> for_each_available_child_of_node will get and put the node properly,
> the following of_node_put will lead to the double put. So just
> remove it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/gpu/drm/zte/zx_drm_drv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
> index 6f4205e8..d7b9870 100644
> --- a/drivers/gpu/drm/zte/zx_drm_drv.c
> +++ b/drivers/gpu/drm/zte/zx_drm_drv.c
> @@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - for_each_available_child_of_node(parent, child) {
> + for_each_available_child_of_node(parent, child)
> component_match_add(dev, &match, compare_of, child);
> - of_node_put(child);
> - }
>
> return component_master_add_with_match(dev, &zx_drm_master_ops, match);
> }
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
2018-09-18 14:59 ` zhong jiang
@ 2018-09-18 15:02 ` Greg KH
-1 siblings, 0 replies; 17+ messages in thread
From: Greg KH @ 2018-09-18 15:02 UTC (permalink / raw)
To: zhong jiang; +Cc: airlied, shawnguo, linux-kernel, dri-devel
On Tue, Sep 18, 2018 at 10:59:08PM +0800, zhong jiang wrote:
> Hi, Greg
>
> Can you pick up the patch?
Nope:
$ ./scripts/get_maintainer.pl --file drivers/gpu/drm/zte/zx_drm_drv.c
Shawn Guo <shawnguo@kernel.org> (maintainer:DRM DRIVERS FOR ZTE ZX)
David Airlie <airlied@linux.ie> (maintainer:DRM DRIVERS)
dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR ZTE ZX)
linux-kernel@vger.kernel.org (open list)
why would I take thi when all of those others are the correct
maintainers?
Also, you only posted this 1 day ago. Please relax and give people time
and a chance to review your patch. It is not instant.
thanks,
greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
@ 2018-09-18 15:02 ` Greg KH
0 siblings, 0 replies; 17+ messages in thread
From: Greg KH @ 2018-09-18 15:02 UTC (permalink / raw)
To: zhong jiang; +Cc: shawnguo, airlied, dri-devel, linux-kernel
On Tue, Sep 18, 2018 at 10:59:08PM +0800, zhong jiang wrote:
> Hi, Greg
>
> Can you pick up the patch?
Nope:
$ ./scripts/get_maintainer.pl --file drivers/gpu/drm/zte/zx_drm_drv.c
Shawn Guo <shawnguo@kernel.org> (maintainer:DRM DRIVERS FOR ZTE ZX)
David Airlie <airlied@linux.ie> (maintainer:DRM DRIVERS)
dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR ZTE ZX)
linux-kernel@vger.kernel.org (open list)
why would I take thi when all of those others are the correct
maintainers?
Also, you only posted this 1 day ago. Please relax and give people time
and a chance to review your patch. It is not instant.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
2018-09-18 15:02 ` Greg KH
@ 2018-09-18 15:18 ` zhong jiang
-1 siblings, 0 replies; 17+ messages in thread
From: zhong jiang @ 2018-09-18 15:18 UTC (permalink / raw)
To: Greg KH; +Cc: shawnguo, airlied, dri-devel, linux-kernel
On 2018/9/18 23:02, Greg KH wrote:
> On Tue, Sep 18, 2018 at 10:59:08PM +0800, zhong jiang wrote:
>> Hi, Greg
>>
>> Can you pick up the patch?
> Nope:
> $ ./scripts/get_maintainer.pl --file drivers/gpu/drm/zte/zx_drm_drv.c
> Shawn Guo <shawnguo@kernel.org> (maintainer:DRM DRIVERS FOR ZTE ZX)
> David Airlie <airlied@linux.ie> (maintainer:DRM DRIVERS)
> dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR ZTE ZX)
> linux-kernel@vger.kernel.org (open list)
>
> why would I take thi when all of those others are the correct
> maintainers?
>
> Also, you only posted this 1 day ago. Please relax and give people time
> and a chance to review your patch. It is not instant.
No, I posted the patch a month ago. I have sent a ping. but It do not work. :-( .
Thanks,
zhong jiang
> thanks,
>
> greg k-h
>
> .
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
@ 2018-09-18 15:18 ` zhong jiang
0 siblings, 0 replies; 17+ messages in thread
From: zhong jiang @ 2018-09-18 15:18 UTC (permalink / raw)
To: Greg KH; +Cc: shawnguo, airlied, dri-devel, linux-kernel
On 2018/9/18 23:02, Greg KH wrote:
> On Tue, Sep 18, 2018 at 10:59:08PM +0800, zhong jiang wrote:
>> Hi, Greg
>>
>> Can you pick up the patch?
> Nope:
> $ ./scripts/get_maintainer.pl --file drivers/gpu/drm/zte/zx_drm_drv.c
> Shawn Guo <shawnguo@kernel.org> (maintainer:DRM DRIVERS FOR ZTE ZX)
> David Airlie <airlied@linux.ie> (maintainer:DRM DRIVERS)
> dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR ZTE ZX)
> linux-kernel@vger.kernel.org (open list)
>
> why would I take thi when all of those others are the correct
> maintainers?
>
> Also, you only posted this 1 day ago. Please relax and give people time
> and a chance to review your patch. It is not instant.
No, I posted the patch a month ago. I have sent a ping. but It do not work. :-( .
Thanks,
zhong jiang
> thanks,
>
> greg k-h
>
> .
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] gpu: do not double put device node in zx_drm_probe
2018-09-18 15:02 ` Greg KH
(?)
(?)
@ 2018-09-18 15:20 ` Daniel Vetter
-1 siblings, 0 replies; 17+ messages in thread
From: Daniel Vetter @ 2018-09-18 15:20 UTC (permalink / raw)
To: Greg KH
Cc: zhong jiang, Dave Airlie, Shawn Guo, Linux Kernel Mailing List,
dri-devel
On Tue, Sep 18, 2018 at 5:02 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Sep 18, 2018 at 10:59:08PM +0800, zhong jiang wrote:
>> Hi, Greg
>>
>> Can you pick up the patch?
>
> Nope:
> $ ./scripts/get_maintainer.pl --file drivers/gpu/drm/zte/zx_drm_drv.c
> Shawn Guo <shawnguo@kernel.org> (maintainer:DRM DRIVERS FOR ZTE ZX)
> David Airlie <airlied@linux.ie> (maintainer:DRM DRIVERS)
> dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR ZTE ZX)
> linux-kernel@vger.kernel.org (open list)
>
> why would I take thi when all of those others are the correct
> maintainers?
>
> Also, you only posted this 1 day ago. Please relax and give people time
> and a chance to review your patch. It is not instant.
First submission was in August, acked by Shawn, but somehow they
forgot to actually push the patch out. I pinged Shawn.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 17+ messages in thread