All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhongjiang@huawei.com (zhong jiang)
Subject: [PATCH] staging: erofs: Fix a unused variable 'arg' warning
Date: Wed, 19 Sep 2018 11:16:26 +0800	[thread overview]
Message-ID: <5BA1BF8A.1000807@huawei.com> (raw)
In-Reply-To: <5b3438ac-f4d4-7f66-4be0-1720c1eada98@gmx.com>

On 2018/9/19 11:07, cgxu519 wrote:
> On 09/19/2018 10:16 AM, zhong jiang wrote:
>> I find the following warning when compiling the kernel.
>>
>> drivers/staging/erofs/super.c:195:6: warning: unused variable 'arg' [-Wunused-variable]
>>    int arg = 0;
>>
>> Signed-off-by: zhong jiang <zhongjiang at huawei.com>
>> ---
>>   drivers/staging/erofs/super.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/staging/erofs/super.c b/drivers/staging/erofs/super.c
>> index 6423592..c04313f 100644
>> --- a/drivers/staging/erofs/super.c
>> +++ b/drivers/staging/erofs/super.c
>> @@ -192,7 +192,9 @@ static int parse_options(struct super_block *sb, char *options)
>>   {
>>       substring_t args[MAX_OPT_ARGS];
>>       char *p;
>> +#ifdef CONFIG_EROFS_FAULT_INJECTION
>>       int arg = 0;
>> +#endif
>>         if (!options)
>>           return 0;
>
> Hi,
>
> The fix has already included in my patch series "staging: erofs: option validation for remount and some code cleanups",
> so it will be fixed when the series merge into tree and we do not encourage surrounding the code with macro in option
> parsing for this case.
>
Fine.  Thank you for explaination.

Sincerely,
zhong jiang
> Thanks,
> Chengguang
>
> .
>

WARNING: multiple messages have this Message-ID (diff)
From: zhong jiang <zhongjiang@huawei.com>
To: cgxu519 <cgxu519@gmx.com>
Cc: <gregkh@linuxfoundation.org>, <gaoxiang25@huawei.com>,
	<yuchao0@huawei.com>, <linux-erofs@lists.ozlabs.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: erofs: Fix a unused variable 'arg' warning
Date: Wed, 19 Sep 2018 11:16:26 +0800	[thread overview]
Message-ID: <5BA1BF8A.1000807@huawei.com> (raw)
In-Reply-To: <5b3438ac-f4d4-7f66-4be0-1720c1eada98@gmx.com>

On 2018/9/19 11:07, cgxu519 wrote:
> On 09/19/2018 10:16 AM, zhong jiang wrote:
>> I find the following warning when compiling the kernel.
>>
>> drivers/staging/erofs/super.c:195:6: warning: unused variable 'arg' [-Wunused-variable]
>>    int arg = 0;
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>>   drivers/staging/erofs/super.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/staging/erofs/super.c b/drivers/staging/erofs/super.c
>> index 6423592..c04313f 100644
>> --- a/drivers/staging/erofs/super.c
>> +++ b/drivers/staging/erofs/super.c
>> @@ -192,7 +192,9 @@ static int parse_options(struct super_block *sb, char *options)
>>   {
>>       substring_t args[MAX_OPT_ARGS];
>>       char *p;
>> +#ifdef CONFIG_EROFS_FAULT_INJECTION
>>       int arg = 0;
>> +#endif
>>         if (!options)
>>           return 0;
>
> Hi,
>
> The fix has already included in my patch series "staging: erofs: option validation for remount and some code cleanups",
> so it will be fixed when the series merge into tree and we do not encourage surrounding the code with macro in option
> parsing for this case.
>
Fine.  Thank you for explaination.

Sincerely,
zhong jiang
> Thanks,
> Chengguang
>
> .
>



  reply	other threads:[~2018-09-19  3:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19  2:16 [PATCH] staging: erofs: Fix a unused variable 'arg' warning zhong jiang
2018-09-19  2:16 ` zhong jiang
2018-09-19  3:07 ` cgxu519
2018-09-19  3:07   ` cgxu519
2018-09-19  3:16   ` zhong jiang [this message]
2018-09-19  3:16     ` zhong jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BA1BF8A.1000807@huawei.com \
    --to=zhongjiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.