All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhong jiang <zhongjiang@huawei.com>
To: Baoquan He <bhe@redhat.com>
Cc: kexec@lists.infradead.org, ebiederm@xmission.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: kexec_file: remove some duplicated include file
Date: Fri, 21 Sep 2018 10:27:27 +0800	[thread overview]
Message-ID: <5BA4570F.6050700@huawei.com> (raw)
In-Reply-To: <20180921021524.GP2555@MiWiFi-R3L-srv>

On 2018/9/21 10:15, Baoquan He wrote:
> On 09/20/18 at 01:12pm, zhong jiang wrote:
>> kexec.h and slab.h have duplicated include. hence just remove
>> redundant file.
> They have duplicated include, why do you remove both of them?
because we include the kexec.h and slab.h twice in kexec_file.c. It's unnecessary.

Thanks,
zhong jiang
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>>  kernel/kexec_file.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
>> index c6a3b68..35cf0ad 100644
>> --- a/kernel/kexec_file.c
>> +++ b/kernel/kexec_file.c
>> @@ -25,8 +25,6 @@
>>  #include <linux/elf.h>
>>  #include <linux/elfcore.h>
>>  #include <linux/kernel.h>
>> -#include <linux/kexec.h>
>> -#include <linux/slab.h>
>>  #include <linux/syscalls.h>
>>  #include <linux/vmalloc.h>
>>  #include "kexec_internal.h"
>> -- 
>> 1.7.12.4
>>
>>
>> _______________________________________________
>> kexec mailing list
>> kexec@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/kexec
> .
>



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: zhong jiang <zhongjiang@huawei.com>
To: Baoquan He <bhe@redhat.com>
Cc: <ebiederm@xmission.com>, <kexec@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel: kexec_file: remove some duplicated include file
Date: Fri, 21 Sep 2018 10:27:27 +0800	[thread overview]
Message-ID: <5BA4570F.6050700@huawei.com> (raw)
In-Reply-To: <20180921021524.GP2555@MiWiFi-R3L-srv>

On 2018/9/21 10:15, Baoquan He wrote:
> On 09/20/18 at 01:12pm, zhong jiang wrote:
>> kexec.h and slab.h have duplicated include. hence just remove
>> redundant file.
> They have duplicated include, why do you remove both of them?
because we include the kexec.h and slab.h twice in kexec_file.c. It's unnecessary.

Thanks,
zhong jiang
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>>  kernel/kexec_file.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
>> index c6a3b68..35cf0ad 100644
>> --- a/kernel/kexec_file.c
>> +++ b/kernel/kexec_file.c
>> @@ -25,8 +25,6 @@
>>  #include <linux/elf.h>
>>  #include <linux/elfcore.h>
>>  #include <linux/kernel.h>
>> -#include <linux/kexec.h>
>> -#include <linux/slab.h>
>>  #include <linux/syscalls.h>
>>  #include <linux/vmalloc.h>
>>  #include "kexec_internal.h"
>> -- 
>> 1.7.12.4
>>
>>
>> _______________________________________________
>> kexec mailing list
>> kexec@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/kexec
> .
>



  reply	other threads:[~2018-09-21  2:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20  5:12 [PATCH] kernel: kexec_file: remove some duplicated include file zhong jiang
2018-09-20  5:12 ` zhong jiang
2018-09-21  2:15 ` Baoquan He
2018-09-21  2:15   ` Baoquan He
2018-09-21  2:27   ` zhong jiang [this message]
2018-09-21  2:27     ` zhong jiang
2018-09-21  2:35     ` Baoquan He
2018-09-21  2:35       ` Baoquan He
2018-09-21  2:48       ` zhong jiang
2018-09-21  2:48         ` zhong jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BA4570F.6050700@huawei.com \
    --to=zhongjiang@huawei.com \
    --cc=bhe@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.