From: Chanwoo Choi <cw00.choi@samsung.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>, Sangbeom Kim <sbkim73@samsung.com>
Cc: kernel-janitors@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 6/8] clk: s2mps11: constify clk_ops structure
Date: Mon, 29 Oct 2018 00:43:22 +0000 [thread overview]
Message-ID: <5BD657AA.1080108@samsung.com> (raw)
In-Reply-To: <1540619262-22681-7-git-send-email-Julia.Lawall@lip6.fr>
On 2018년 10월 27일 14:47, Julia Lawall wrote:
> The clk_ops structure is only stored in the ops fields of
> clk_init_data structures. This field is const, so the clk_ops
> structure can be const as well.
>
> Identified and transformed using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/clk/clk-s2mps11.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c
> index 5b419b82f7ca..2ce370c804aa 100644
> --- a/drivers/clk/clk-s2mps11.c
> +++ b/drivers/clk/clk-s2mps11.c
> @@ -71,7 +71,7 @@ static unsigned long s2mps11_clk_recalc_rate(struct clk_hw *hw,
> return 32768;
> }
>
> -static struct clk_ops s2mps11_clk_ops = {
> +static const struct clk_ops s2mps11_clk_ops = {
> .prepare = s2mps11_clk_prepare,
> .unprepare = s2mps11_clk_unprepare,
> .is_prepared = s2mps11_clk_is_prepared,
>
>
>
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>, Sangbeom Kim <sbkim73@samsung.com>
Cc: kernel-janitors@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 6/8] clk: s2mps11: constify clk_ops structure
Date: Mon, 29 Oct 2018 09:43:22 +0900 [thread overview]
Message-ID: <5BD657AA.1080108@samsung.com> (raw)
In-Reply-To: <1540619262-22681-7-git-send-email-Julia.Lawall@lip6.fr>
On 2018년 10월 27일 14:47, Julia Lawall wrote:
> The clk_ops structure is only stored in the ops fields of
> clk_init_data structures. This field is const, so the clk_ops
> structure can be const as well.
>
> Identified and transformed using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/clk/clk-s2mps11.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c
> index 5b419b82f7ca..2ce370c804aa 100644
> --- a/drivers/clk/clk-s2mps11.c
> +++ b/drivers/clk/clk-s2mps11.c
> @@ -71,7 +71,7 @@ static unsigned long s2mps11_clk_recalc_rate(struct clk_hw *hw,
> return 32768;
> }
>
> -static struct clk_ops s2mps11_clk_ops = {
> +static const struct clk_ops s2mps11_clk_ops = {
> .prepare = s2mps11_clk_prepare,
> .unprepare = s2mps11_clk_unprepare,
> .is_prepared = s2mps11_clk_is_prepared,
>
>
>
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2018-10-29 0:43 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 5:47 [PATCH 0/8] constify clk_ops structure Julia Lawall
2018-10-27 5:47 ` Julia Lawall
2018-10-27 5:47 ` Julia Lawall
2018-10-27 5:47 ` Julia Lawall
2018-10-27 5:47 ` [PATCH 1/8] clk: max77686: " Julia Lawall
2018-10-27 5:47 ` Julia Lawall
2018-10-29 7:49 ` Krzysztof Kozlowski
2018-10-29 7:49 ` Krzysztof Kozlowski
2018-11-06 17:41 ` Stephen Boyd
2018-11-06 17:41 ` Stephen Boyd
2018-10-27 5:47 ` [PATCH 2/8] ARM: vexpress/spc: " Julia Lawall
2018-10-27 5:47 ` Julia Lawall
2018-10-27 5:47 ` Julia Lawall
2018-10-29 9:17 ` Liviu Dudau
2018-10-29 9:17 ` Liviu Dudau
2018-10-29 9:17 ` Liviu Dudau
2018-10-29 9:34 ` Julia Lawall
2018-10-29 9:34 ` Julia Lawall
2018-10-29 9:34 ` Julia Lawall
2018-10-27 5:47 ` [PATCH 3/8] clk: palmas: " Julia Lawall
2018-10-27 5:47 ` Julia Lawall
2018-11-06 17:42 ` Stephen Boyd
2018-11-06 17:42 ` Stephen Boyd
2018-10-27 5:47 ` [PATCH 4/8] clk: pistachio: constify clk_ops structures Julia Lawall
2018-10-27 5:47 ` Julia Lawall
2018-11-06 17:42 ` Stephen Boyd
2018-11-06 17:42 ` Stephen Boyd
2018-10-27 5:47 ` [PATCH 5/8] clk: pxa: " Julia Lawall
2018-10-27 5:47 ` Julia Lawall
2018-11-06 17:42 ` Stephen Boyd
2018-11-06 17:42 ` Stephen Boyd
2018-10-27 5:47 ` [PATCH 6/8] clk: s2mps11: constify clk_ops structure Julia Lawall
2018-10-27 5:47 ` Julia Lawall
2018-10-29 0:43 ` Chanwoo Choi [this message]
2018-10-29 0:43 ` Chanwoo Choi
2018-11-06 17:43 ` Stephen Boyd
2018-11-06 17:43 ` Stephen Boyd
2018-10-27 5:47 ` [PATCH 7/8] drm/imx: imx-tve: " Julia Lawall
2018-10-27 5:47 ` Julia Lawall
2018-10-27 5:47 ` Julia Lawall
2018-10-30 8:57 ` Philipp Zabel
2018-10-30 8:57 ` Philipp Zabel
2018-10-27 5:47 ` [PATCH 8/8] drm/msm/hdmi: " Julia Lawall
2018-10-27 5:47 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BD657AA.1080108@samsung.com \
--to=cw00.choi@samsung.com \
--cc=Julia.Lawall@lip6.fr \
--cc=b.zolnierkie@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sbkim73@samsung.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.