From: Roger Quadros <rogerq@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: devicetree@vger.kernel.org, vigneshr@ti.com, nsekhar@ti.com,
linux-kernel@vger.kernel.org, t-kristo@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] arm64: dts: ti: k3-am6: add USB support
Date: Wed, 16 Jan 2019 12:54:40 +0200 [thread overview]
Message-ID: <5C3F0D70.4050903@ti.com> (raw)
In-Reply-To: <20190115143641.m2cvwljr7rbtayi2@kahuna>
On 15/01/19 16:36, Nishanth Menon wrote:
> On 12:01-20190111, Roger Quadros wrote:
>> Adds support for USB0 and USB1 instances on the AM6 SoC.
>> USB0 is limited to high-speed for now.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 80 ++++++++++++++++++++++++++++++++
>> 1 file changed, 80 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> index 8b55108..680cbc7 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> @@ -199,4 +199,84 @@
>> #size-cells = <1>;
>> ranges = <0x0 0x0 0x00100000 0x1c000>;
>> };
>> +
>> + dwc3_0: dwc3@4000000 {
>> + compatible = "ti,am654-dwc3";
>> + reg = <0x0 0x4000000 0x0 0x4000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x0 0x4000000 0x20000>;
>> + interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
>> + dma-coherent;
>> + status = "disabled";
>
> NAK. -> in ARMV8, we dont do default disabled. Instead, please disable
> nodes in the board dts or overlay as necessary.
got it.
>
>> + power-domains = <&k3_pds 151>;
>> + assigned-clocks = <&k3_clks 151 2>, <&k3_clks 151 7>;
>> + assigned-clock-parents = <&k3_clks 151 4>, /* set REF_CLK to 20MHz i.e. PER0_PLL/48 */
>> + <&k3_clks 151 9>; /* set PIPE3_TXB_CLK to CLK_12M_RC/256 (for HS only) */
>> +
>> + usb0: usb@10000 {
>> + compatible = "snps,dwc3";
>> + reg = <0x10000 0x10000>;
>> + interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "peripheral",
>> + "host",
>> + "otg";
>> + maximum-speed = "high-speed";
>> + dr_mode = "otg";
>> + phys = <&usb0_phy>;
>> + phy-names = "usb2-phy";
>> + snps,dis_u3_susphy_quirk;
>> + };
>> + };
>> +
>> + usb0_phy: phy@4100000 {
>> + compatible = "ti,am654-usb2", "ti,omap-usb2";
>> + reg = <0x0 0x4100000 0x0 0x54>;
>> + syscon-phy-power = <&scm_conf 0x4000>;
>
> Just curious, dont we need a power domain as well?
Not for USB2.0 PHYs. Those are part of USB3SSn power domains.
>
>> + clocks = <&k3_clks 151 0>, <&k3_clks 151 1>;
>> + clock-names = "wkupclk", "refclk";
>> + #phy-cells = <0>;
>> + status = "disabled";
>
> same here -> please drop
>
>> + };
>> +
>> + dwc3_1: dwc3@4020000 {
>> + compatible = "ti,am654-dwc3";
>> + reg = <0x0 0x4020000 0x0 0x4000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x0 0x4020000 0x20000>;
>> + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
>> + dma-coherent;
>> + status = "disabled";
>
> same here -> please drop
>
>> + power-domains = <&k3_pds 152>;
>> + assigned-clocks = <&k3_clks 152 2>;
>> + assigned-clock-parents = <&k3_clks 152 4>; /* set REF_CLK to 20MHz i.e. PER0_PLL/48 */
>> +
>> + usb1: usb@10000 {
>> + compatible = "snps,dwc3";
>> + reg = <0x10000 0x10000>;
>> + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "peripheral",
>> + "host",
>> + "otg";
>> + maximum-speed = "high-speed";
>> + dr_mode = "otg";
>> + phys = <&usb1_phy>;
>> + phy-names = "usb2-phy";
>> + };
>> + };
>> +
>> + usb1_phy: phy@4110000 {
>> + compatible = "ti,am654-usb2", "ti,omap-usb2";
>> + reg = <0x0 0x4110000 0x0 0x54>;
>> + syscon-phy-power = <&scm_conf 0x4020>;
>
> Same question on power domain..
>
>> + clocks = <&k3_clks 152 0>, <&k3_clks 152 1>;
>> + clock-names = "wkupclk", "refclk";
>> + #phy-cells = <0>;
>> + status = "disabled";
>
> same here -> please drop
>
>> + };
>> };
>> --
>> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
>> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>>
>
cheers,
-roger
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: devicetree@vger.kernel.org, vigneshr@ti.com, nsekhar@ti.com,
linux-kernel@vger.kernel.org, t-kristo@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] arm64: dts: ti: k3-am6: add USB support
Date: Wed, 16 Jan 2019 12:54:40 +0200 [thread overview]
Message-ID: <5C3F0D70.4050903@ti.com> (raw)
In-Reply-To: <20190115143641.m2cvwljr7rbtayi2@kahuna>
On 15/01/19 16:36, Nishanth Menon wrote:
> On 12:01-20190111, Roger Quadros wrote:
>> Adds support for USB0 and USB1 instances on the AM6 SoC.
>> USB0 is limited to high-speed for now.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 80 ++++++++++++++++++++++++++++++++
>> 1 file changed, 80 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> index 8b55108..680cbc7 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> @@ -199,4 +199,84 @@
>> #size-cells = <1>;
>> ranges = <0x0 0x0 0x00100000 0x1c000>;
>> };
>> +
>> + dwc3_0: dwc3@4000000 {
>> + compatible = "ti,am654-dwc3";
>> + reg = <0x0 0x4000000 0x0 0x4000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x0 0x4000000 0x20000>;
>> + interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
>> + dma-coherent;
>> + status = "disabled";
>
> NAK. -> in ARMV8, we dont do default disabled. Instead, please disable
> nodes in the board dts or overlay as necessary.
got it.
>
>> + power-domains = <&k3_pds 151>;
>> + assigned-clocks = <&k3_clks 151 2>, <&k3_clks 151 7>;
>> + assigned-clock-parents = <&k3_clks 151 4>, /* set REF_CLK to 20MHz i.e. PER0_PLL/48 */
>> + <&k3_clks 151 9>; /* set PIPE3_TXB_CLK to CLK_12M_RC/256 (for HS only) */
>> +
>> + usb0: usb@10000 {
>> + compatible = "snps,dwc3";
>> + reg = <0x10000 0x10000>;
>> + interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "peripheral",
>> + "host",
>> + "otg";
>> + maximum-speed = "high-speed";
>> + dr_mode = "otg";
>> + phys = <&usb0_phy>;
>> + phy-names = "usb2-phy";
>> + snps,dis_u3_susphy_quirk;
>> + };
>> + };
>> +
>> + usb0_phy: phy@4100000 {
>> + compatible = "ti,am654-usb2", "ti,omap-usb2";
>> + reg = <0x0 0x4100000 0x0 0x54>;
>> + syscon-phy-power = <&scm_conf 0x4000>;
>
> Just curious, dont we need a power domain as well?
Not for USB2.0 PHYs. Those are part of USB3SSn power domains.
>
>> + clocks = <&k3_clks 151 0>, <&k3_clks 151 1>;
>> + clock-names = "wkupclk", "refclk";
>> + #phy-cells = <0>;
>> + status = "disabled";
>
> same here -> please drop
>
>> + };
>> +
>> + dwc3_1: dwc3@4020000 {
>> + compatible = "ti,am654-dwc3";
>> + reg = <0x0 0x4020000 0x0 0x4000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x0 0x4020000 0x20000>;
>> + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
>> + dma-coherent;
>> + status = "disabled";
>
> same here -> please drop
>
>> + power-domains = <&k3_pds 152>;
>> + assigned-clocks = <&k3_clks 152 2>;
>> + assigned-clock-parents = <&k3_clks 152 4>; /* set REF_CLK to 20MHz i.e. PER0_PLL/48 */
>> +
>> + usb1: usb@10000 {
>> + compatible = "snps,dwc3";
>> + reg = <0x10000 0x10000>;
>> + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "peripheral",
>> + "host",
>> + "otg";
>> + maximum-speed = "high-speed";
>> + dr_mode = "otg";
>> + phys = <&usb1_phy>;
>> + phy-names = "usb2-phy";
>> + };
>> + };
>> +
>> + usb1_phy: phy@4110000 {
>> + compatible = "ti,am654-usb2", "ti,omap-usb2";
>> + reg = <0x0 0x4110000 0x0 0x54>;
>> + syscon-phy-power = <&scm_conf 0x4020>;
>
> Same question on power domain..
>
>> + clocks = <&k3_clks 152 0>, <&k3_clks 152 1>;
>> + clock-names = "wkupclk", "refclk";
>> + #phy-cells = <0>;
>> + status = "disabled";
>
> same here -> please drop
>
>> + };
>> };
>> --
>> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
>> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>>
>
cheers,
-roger
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: <t-kristo@ti.com>, <nsekhar@ti.com>, <vigneshr@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] arm64: dts: ti: k3-am6: add USB support
Date: Wed, 16 Jan 2019 12:54:40 +0200 [thread overview]
Message-ID: <5C3F0D70.4050903@ti.com> (raw)
In-Reply-To: <20190115143641.m2cvwljr7rbtayi2@kahuna>
On 15/01/19 16:36, Nishanth Menon wrote:
> On 12:01-20190111, Roger Quadros wrote:
>> Adds support for USB0 and USB1 instances on the AM6 SoC.
>> USB0 is limited to high-speed for now.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 80 ++++++++++++++++++++++++++++++++
>> 1 file changed, 80 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> index 8b55108..680cbc7 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>> @@ -199,4 +199,84 @@
>> #size-cells = <1>;
>> ranges = <0x0 0x0 0x00100000 0x1c000>;
>> };
>> +
>> + dwc3_0: dwc3@4000000 {
>> + compatible = "ti,am654-dwc3";
>> + reg = <0x0 0x4000000 0x0 0x4000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x0 0x4000000 0x20000>;
>> + interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
>> + dma-coherent;
>> + status = "disabled";
>
> NAK. -> in ARMV8, we dont do default disabled. Instead, please disable
> nodes in the board dts or overlay as necessary.
got it.
>
>> + power-domains = <&k3_pds 151>;
>> + assigned-clocks = <&k3_clks 151 2>, <&k3_clks 151 7>;
>> + assigned-clock-parents = <&k3_clks 151 4>, /* set REF_CLK to 20MHz i.e. PER0_PLL/48 */
>> + <&k3_clks 151 9>; /* set PIPE3_TXB_CLK to CLK_12M_RC/256 (for HS only) */
>> +
>> + usb0: usb@10000 {
>> + compatible = "snps,dwc3";
>> + reg = <0x10000 0x10000>;
>> + interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "peripheral",
>> + "host",
>> + "otg";
>> + maximum-speed = "high-speed";
>> + dr_mode = "otg";
>> + phys = <&usb0_phy>;
>> + phy-names = "usb2-phy";
>> + snps,dis_u3_susphy_quirk;
>> + };
>> + };
>> +
>> + usb0_phy: phy@4100000 {
>> + compatible = "ti,am654-usb2", "ti,omap-usb2";
>> + reg = <0x0 0x4100000 0x0 0x54>;
>> + syscon-phy-power = <&scm_conf 0x4000>;
>
> Just curious, dont we need a power domain as well?
Not for USB2.0 PHYs. Those are part of USB3SSn power domains.
>
>> + clocks = <&k3_clks 151 0>, <&k3_clks 151 1>;
>> + clock-names = "wkupclk", "refclk";
>> + #phy-cells = <0>;
>> + status = "disabled";
>
> same here -> please drop
>
>> + };
>> +
>> + dwc3_1: dwc3@4020000 {
>> + compatible = "ti,am654-dwc3";
>> + reg = <0x0 0x4020000 0x0 0x4000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x0 0x4020000 0x20000>;
>> + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
>> + dma-coherent;
>> + status = "disabled";
>
> same here -> please drop
>
>> + power-domains = <&k3_pds 152>;
>> + assigned-clocks = <&k3_clks 152 2>;
>> + assigned-clock-parents = <&k3_clks 152 4>; /* set REF_CLK to 20MHz i.e. PER0_PLL/48 */
>> +
>> + usb1: usb@10000 {
>> + compatible = "snps,dwc3";
>> + reg = <0x10000 0x10000>;
>> + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "peripheral",
>> + "host",
>> + "otg";
>> + maximum-speed = "high-speed";
>> + dr_mode = "otg";
>> + phys = <&usb1_phy>;
>> + phy-names = "usb2-phy";
>> + };
>> + };
>> +
>> + usb1_phy: phy@4110000 {
>> + compatible = "ti,am654-usb2", "ti,omap-usb2";
>> + reg = <0x0 0x4110000 0x0 0x54>;
>> + syscon-phy-power = <&scm_conf 0x4020>;
>
> Same question on power domain..
>
>> + clocks = <&k3_clks 152 0>, <&k3_clks 152 1>;
>> + clock-names = "wkupclk", "refclk";
>> + #phy-cells = <0>;
>> + status = "disabled";
>
> same here -> please drop
>
>> + };
>> };
>> --
>> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
>> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>>
>
cheers,
-roger
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-01-16 10:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 10:00 [PATCH 0/3] arm64: ti: k3-am654: USB support Roger Quadros
2019-01-11 10:00 ` Roger Quadros
2019-01-11 10:00 ` Roger Quadros
2019-01-11 10:00 ` [PATCH 1/3] arm64: dts: ti: am654: Add Main System Control Module node Roger Quadros
2019-01-11 10:00 ` Roger Quadros
2019-01-11 10:00 ` Roger Quadros
2019-01-15 14:33 ` Nishanth Menon
2019-01-15 14:33 ` Nishanth Menon
2019-01-15 14:33 ` Nishanth Menon
2019-01-16 10:52 ` Roger Quadros
2019-01-16 10:52 ` Roger Quadros
2019-01-16 10:52 ` Roger Quadros
2019-01-11 10:01 ` [PATCH 2/3] arm64: dts: ti: k3-am6: add USB support Roger Quadros
2019-01-11 10:01 ` Roger Quadros
2019-01-11 10:01 ` Roger Quadros
2019-01-15 14:36 ` Nishanth Menon
2019-01-15 14:36 ` Nishanth Menon
2019-01-15 14:36 ` Nishanth Menon
2019-01-16 10:54 ` Roger Quadros [this message]
2019-01-16 10:54 ` Roger Quadros
2019-01-16 10:54 ` Roger Quadros
2019-01-11 10:01 ` [PATCH 3/3] arm64: dts: ti: k3-am654-base-board: enable USB1 Roger Quadros
2019-01-11 10:01 ` Roger Quadros
2019-01-11 10:01 ` Roger Quadros
2019-01-15 14:37 ` Nishanth Menon
2019-01-15 14:37 ` Nishanth Menon
2019-01-15 14:37 ` Nishanth Menon
2019-01-15 14:33 ` [PATCH 0/3] arm64: ti: k3-am654: USB support Nishanth Menon
2019-01-15 14:33 ` Nishanth Menon
2019-01-15 14:33 ` Nishanth Menon
2019-01-16 11:00 ` Roger Quadros
2019-01-16 11:00 ` Roger Quadros
2019-01-16 11:00 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C3F0D70.4050903@ti.com \
--to=rogerq@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=t-kristo@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.