All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pascal PAILLET-LME <p.paillet@st.com>
To: kbuild test robot <lkp@intel.com>
Cc: Alexandre TORGUE <alexandre.torgue@st.com>,
	"yuehaibing@huawei.com" <yuehaibing@huawei.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	"kbuild-all@01.org" <kbuild-all@01.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH regulator] regulator: ready_mask_table[] can be static
Date: Tue, 16 Apr 2019 15:32:46 +0000	[thread overview]
Message-ID: <5CB5F59E.6050905@st.com> (raw)
In-Reply-To: <20190415165238.GA71613@lkp-sb05>

The same patch was proposed by YueHaibing

Acked-by: Pascal Paillet <p.paillet@st.com>

thank you,
pascal


Le 04/15/2019 06:52 PM, kbuild test robot a écrit :
> Fixes: 6cdae8173f67 ("regulator: Add support for stm32 power regulators")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>   stm32-pwr.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/stm32-pwr.c b/drivers/regulator/stm32-pwr.c
> index e434b26..222d593 100644
> --- a/drivers/regulator/stm32-pwr.c
> +++ b/drivers/regulator/stm32-pwr.c
> @@ -32,7 +32,7 @@ enum {
>   	STM32PWR_REG_NUM_REGS
>   };
>   
> -u32 ready_mask_table[STM32PWR_REG_NUM_REGS] = {
> +static u32 ready_mask_table[STM32PWR_REG_NUM_REGS] = {
>   	[PWR_REG11] = REG_1_1_RDY,
>   	[PWR_REG18] = REG_1_8_RDY,
>   	[PWR_USB33] = USB_3_3_RDY,
> @@ -44,7 +44,7 @@ struct stm32_pwr_reg {
>   	u32 ready_mask;
>   };
>   
> -int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
> +static int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
>   {
>   	struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev);
>   	u32 val;
> @@ -54,7 +54,7 @@ int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
>   	return (val & priv->ready_mask);
>   }
>   
> -int stm32_pwr_reg_is_enabled(struct regulator_dev *rdev)
> +static int stm32_pwr_reg_is_enabled(struct regulator_dev *rdev)
>   {
>   	struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev);
>   	u32 val;
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Pascal PAILLET-LME <p.paillet@st.com>
To: kbuild test robot <lkp@intel.com>
Cc: "kbuild-all@01.org" <kbuild-all@01.org>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-stm32@st-md-mailman.stormreply.com" 
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"yuehaibing@huawei.com" <yuehaibing@huawei.com>
Subject: Re: [RFC PATCH regulator] regulator: ready_mask_table[] can be static
Date: Tue, 16 Apr 2019 15:32:46 +0000	[thread overview]
Message-ID: <5CB5F59E.6050905@st.com> (raw)
In-Reply-To: <20190415165238.GA71613@lkp-sb05>

The same patch was proposed by YueHaibing

Acked-by: Pascal Paillet <p.paillet@st.com>

thank you,
pascal


Le 04/15/2019 06:52 PM, kbuild test robot a écrit :
> Fixes: 6cdae8173f67 ("regulator: Add support for stm32 power regulators")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>   stm32-pwr.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/stm32-pwr.c b/drivers/regulator/stm32-pwr.c
> index e434b26..222d593 100644
> --- a/drivers/regulator/stm32-pwr.c
> +++ b/drivers/regulator/stm32-pwr.c
> @@ -32,7 +32,7 @@ enum {
>   	STM32PWR_REG_NUM_REGS
>   };
>   
> -u32 ready_mask_table[STM32PWR_REG_NUM_REGS] = {
> +static u32 ready_mask_table[STM32PWR_REG_NUM_REGS] = {
>   	[PWR_REG11] = REG_1_1_RDY,
>   	[PWR_REG18] = REG_1_8_RDY,
>   	[PWR_USB33] = USB_3_3_RDY,
> @@ -44,7 +44,7 @@ struct stm32_pwr_reg {
>   	u32 ready_mask;
>   };
>   
> -int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
> +static int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
>   {
>   	struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev);
>   	u32 val;
> @@ -54,7 +54,7 @@ int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
>   	return (val & priv->ready_mask);
>   }
>   
> -int stm32_pwr_reg_is_enabled(struct regulator_dev *rdev)
> +static int stm32_pwr_reg_is_enabled(struct regulator_dev *rdev)
>   {
>   	struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev);
>   	u32 val;
>

  reply	other threads:[~2019-04-16 15:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15 16:52 [regulator:for-next 103/105] drivers/regulator/stm32-pwr.c:35:5: sparse: symbol 'ready_mask_table' was not declared. Should it be static? kbuild test robot
2019-04-15 16:52 ` kbuild test robot
2019-04-15 16:52 ` [RFC PATCH regulator] regulator: ready_mask_table[] can be static kbuild test robot
2019-04-15 16:52   ` kbuild test robot
2019-04-16 15:32   ` Pascal PAILLET-LME [this message]
2019-04-16 15:32     ` Pascal PAILLET-LME
2019-04-17 16:42   ` Applied "regulator: ready_mask_table[] can be static" to the regulator tree Mark Brown
2019-04-17 16:42     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5CB5F59E.6050905@st.com \
    --to=p.paillet@st.com \
    --cc=alexandre.torgue@st.com \
    --cc=broonie@kernel.org \
    --cc=kbuild-all@01.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=lkp@intel.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.