[LTP] [PATCH] file01.sh: Fix in was not recognized

[LTP] [PATCH] file01.sh: Fix in was not recognized

[zhe.he]

From: He Zhe <zhe.he@windriver.com>

Some file may have "pie" and possible other things appending after LSB or MSB,
which causes mismatch and the following error.

"file01 10 TFAIL: in: was not recognized"
..."ELF 64-bit LSB pie executable"...

This patches tunes the regulation expression to match those cases.

Signed-off-by: He Zhe <zhe.he@windriver.com>
---
 testcases/commands/file/file01.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/commands/file/file01.sh b/testcases/commands/file/file01.sh
index 0a8119e..34274c3 100755
--- a/testcases/commands/file/file01.sh
+++ b/testcases/commands/file/file01.sh
@@ -90,8 +90,8 @@ do_test()
 			    "[pP]ython3\{0,1\} script text executable";;
 	 9) file_test in.m4 "M4 macro processor script, ASCII text" \
 			    "ASCII M4 macro language pre-processor text";;
-	10) file_test in "ELF .*-bit $TEST_ARCH executable, .*" \
-			 "ELF .*-bit $TEST_ARCH shared object, .*";;
+	10) file_test in "ELF .*-bit $TEST_ARCH .* executable, .*" \
+			 "ELF .*-bit $TEST_ARCH .* shared object, .*";;
 	11) file_test in.ar "current ar archive";;
 	12) file_test in.tar "tar archive";;
 	13) file_test in.tar.gz "gzip compressed data, .*";;
-- 
2.7.4

[LTP] [PATCH] file01.sh: Fix in was not recognized

[Xiao Yang]

On 2019/04/22 9:29, zhe.he@windriver.com wrote:
> From: He Zhe<zhe.he@windriver.com>
>
> Some file may have "pie" and possible other things appending after LSB or MSB,
> which causes mismatch and the following error.
>
> "file01 10 TFAIL: in: was not recognized"
> ..."ELF 64-bit LSB pie executable"...
>
> This patches tunes the regulation expression to match those cases.
Hi He,

Your patch doesn't match original output(e.g. "...ELF 64-bit LSB 
executable...").

Besides, could you tell me what kind of environment or operation can 
reproduce
above unrecognized output?

Best Regards,
Xiao Yang
> Signed-off-by: He Zhe<zhe.he@windriver.com>
> ---
>   testcases/commands/file/file01.sh | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/commands/file/file01.sh b/testcases/commands/file/file01.sh
> index 0a8119e..34274c3 100755
> --- a/testcases/commands/file/file01.sh
> +++ b/testcases/commands/file/file01.sh
> @@ -90,8 +90,8 @@ do_test()
>   			    "[pP]ython3\{0,1\} script text executable";;
>   	 9) file_test in.m4 "M4 macro processor script, ASCII text" \
>   			    "ASCII M4 macro language pre-processor text";;
> -	10) file_test in "ELF .*-bit $TEST_ARCH executable, .*" \
> -			 "ELF .*-bit $TEST_ARCH shared object, .*";;
> +	10) file_test in "ELF .*-bit $TEST_ARCH .* executable, .*" \
> +			 "ELF .*-bit $TEST_ARCH .* shared object, .*";;
>   	11) file_test in.ar "current ar archive";;
>   	12) file_test in.tar "tar archive";;
>   	13) file_test in.tar.gz "gzip compressed data, .*";;

[LTP] [PATCH] file01.sh: Fix in was not recognized

[He Zhe]

On 4/22/19 10:55 AM, Xiao Yang wrote:
> On 2019/04/22 9:29, zhe.he@windriver.com wrote:
>> From: He Zhe<zhe.he@windriver.com>
>>
>> Some file may have "pie" and possible other things appending after LSB or MSB,
>> which causes mismatch and the following error.
>>
>> "file01 10 TFAIL: in: was not recognized"
>> ..."ELF 64-bit LSB pie executable"...
>>
>> This patches tunes the regulation expression to match those cases.
> Hi He,
>
> Your patch doesn't match original output(e.g. "...ELF 64-bit LSB executable...").
>
> Besides, could you tell me what kind of environment or operation can reproduce
> above unrecognized output?

Thanks, I'll send v2.

And file v5.36 would give "pie" for program compiled with "-pie".

Zhe

>
> Best Regards,
> Xiao Yang
>> Signed-off-by: He Zhe<zhe.he@windriver.com>
>> ---
>>   testcases/commands/file/file01.sh | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/testcases/commands/file/file01.sh b/testcases/commands/file/file01.sh
>> index 0a8119e..34274c3 100755
>> --- a/testcases/commands/file/file01.sh
>> +++ b/testcases/commands/file/file01.sh
>> @@ -90,8 +90,8 @@ do_test()
>>                   "[pP]ython3\{0,1\} script text executable";;
>>        9) file_test in.m4 "M4 macro processor script, ASCII text" \
>>                   "ASCII M4 macro language pre-processor text";;
>> -    10) file_test in "ELF .*-bit $TEST_ARCH executable, .*" \
>> -             "ELF .*-bit $TEST_ARCH shared object, .*";;
>> +    10) file_test in "ELF .*-bit $TEST_ARCH .* executable, .*" \
>> +             "ELF .*-bit $TEST_ARCH .* shared object, .*";;
>>       11) file_test in.ar "current ar archive";;
>>       12) file_test in.tar "tar archive";;
>>       13) file_test in.tar.gz "gzip compressed data, .*";;
>
>
>
>