* [PATCH] ext4/035: skip this test if DAX is in use
@ 2019-06-10 2:42 Theodore Ts'o
2019-06-10 2:53 ` Theodore Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Theodore Ts'o @ 2019-06-10 2:42 UTC (permalink / raw)
To: fstests; +Cc: Theodore Ts'o, Yang Xu
This test creates a file system with a 1k block size. Since there are
no architectures with a 1k page size, test file system can never be
mounted with DAX enabled, causing the test to fail.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
tests/ext4/035 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/ext4/035 b/tests/ext4/035
index ac5f38e0..05867402 100755
--- a/tests/ext4/035
+++ b/tests/ext4/035
@@ -36,6 +36,7 @@ _cleanup()
_supported_fs ext4
_supported_os Linux
_require_scratch
+_exclude_scratch_mount_option dax
_require_command "$RESIZE2FS_PROG" resize2fs
rm -f $seqres.full
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4/035: skip this test if DAX is in use
2019-06-10 2:42 [PATCH] ext4/035: skip this test if DAX is in use Theodore Ts'o
@ 2019-06-10 2:53 ` Theodore Ts'o
2019-06-10 5:34 ` Yang Xu
0 siblings, 1 reply; 3+ messages in thread
From: Theodore Ts'o @ 2019-06-10 2:53 UTC (permalink / raw)
To: fstests; +Cc: Yang Xu
On Sun, Jun 09, 2019 at 10:42:54PM -0400, Theodore Ts'o wrote:
> This test creates a file system with a 1k block size. Since there are
> no architectures with a 1k page size, test file system can never be
s/test file system/the test file system/
> mounted with DAX enabled, causing the test to fail.
Sorry, typo.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4/035: skip this test if DAX is in use
2019-06-10 2:53 ` Theodore Ts'o
@ 2019-06-10 5:34 ` Yang Xu
0 siblings, 0 replies; 3+ messages in thread
From: Yang Xu @ 2019-06-10 5:34 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: fstests
on 2019/06/10 10:53, Theodore Ts'o wrote:
> On Sun, Jun 09, 2019 at 10:42:54PM -0400, Theodore Ts'o wrote:
>> This test creates a file system with a 1k block size. Since there are
>> no architectures with a 1k page size, test file system can never be
> s/test file system/the test file system/
>
>> mounted with DAX enabled, causing the test to fail.
Looks good to me. Feel free to add:
Reviewed-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com>
> Sorry, typo.
>
> - Ted
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-10 5:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-10 2:42 [PATCH] ext4/035: skip this test if DAX is in use Theodore Ts'o
2019-06-10 2:53 ` Theodore Ts'o
2019-06-10 5:34 ` Yang Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.