From: walter harms <wharms@bfs.de>
To: Colin King <colin.king@canonical.com>
Cc: Shuah Khan <shuah@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kselftest@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL"
Date: Mon, 01 Jul 2019 13:12:46 +0000 [thread overview]
Message-ID: <5D1A06CE.6000405@bfs.de> (raw)
In-Reply-To: <20190701130431.13391-1-colin.king@canonical.com>
Am 01.07.2019 15:04, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is an spelling mistake in an a test error message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> tools/testing/selftests/x86/test_vsyscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/x86/test_vsyscall.c b/tools/testing/selftests/x86/test_vsyscall.c
> index 4602326b8f5b..a4f4d4cf22c3 100644
> --- a/tools/testing/selftests/x86/test_vsyscall.c
> +++ b/tools/testing/selftests/x86/test_vsyscall.c
> @@ -451,7 +451,7 @@ static int test_vsys_x(void)
> printf("[OK]\tExecuting the vsyscall page failed: #PF(0x%lx)\n",
> segv_err);
> } else {
> - printf("[FAILT]\tExecution failed with the wrong error: #PF(0x%lx)\n",
> + printf("[FAIL]\tExecution failed with the wrong error: #PF(0x%lx)\n",
> segv_err);
> return 1;
> }
"wrong error" sounds like scratching table, perhaps "error" is here sufficient ?
Bomus points when user is expected to report this.
re,
wh
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Colin King <colin.king@canonical.com>
Cc: Shuah Khan <shuah@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kselftest@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL"
Date: Mon, 01 Jul 2019 15:12:46 +0200 [thread overview]
Message-ID: <5D1A06CE.6000405@bfs.de> (raw)
In-Reply-To: <20190701130431.13391-1-colin.king@canonical.com>
Am 01.07.2019 15:04, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is an spelling mistake in an a test error message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> tools/testing/selftests/x86/test_vsyscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/x86/test_vsyscall.c b/tools/testing/selftests/x86/test_vsyscall.c
> index 4602326b8f5b..a4f4d4cf22c3 100644
> --- a/tools/testing/selftests/x86/test_vsyscall.c
> +++ b/tools/testing/selftests/x86/test_vsyscall.c
> @@ -451,7 +451,7 @@ static int test_vsys_x(void)
> printf("[OK]\tExecuting the vsyscall page failed: #PF(0x%lx)\n",
> segv_err);
> } else {
> - printf("[FAILT]\tExecution failed with the wrong error: #PF(0x%lx)\n",
> + printf("[FAIL]\tExecution failed with the wrong error: #PF(0x%lx)\n",
> segv_err);
> return 1;
> }
"wrong error" sounds like scratching table, perhaps "error" is here sufficient ?
Bomus points when user is expected to report this.
re,
wh
next prev parent reply other threads:[~2019-07-01 13:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 13:04 [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL" Colin King
2019-07-01 13:04 ` Colin King
2019-07-01 13:12 ` walter harms [this message]
2019-07-01 13:12 ` walter harms
2019-07-01 17:59 ` shuah
2019-07-01 17:59 ` shuah
2019-07-01 17:48 ` Andy Lutomirski
2019-07-01 17:48 ` Andy Lutomirski
2019-07-02 14:22 ` shuah
2019-07-02 14:22 ` shuah
2019-07-02 19:25 ` shuah
2019-07-02 19:25 ` shuah
2019-07-02 22:42 ` Colin Ian King
2019-07-02 22:42 ` Colin Ian King
2019-07-02 22:48 ` shuah
2019-07-02 22:48 ` shuah
2019-07-02 22:50 ` Colin Ian King
2019-07-02 22:50 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D1A06CE.6000405@bfs.de \
--to=wharms@bfs.de \
--cc=colin.king@canonical.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.