All of lore.kernel.org
 help / color / mirror / Atom feed
From: piaojun <piaojun@huawei.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Virtio-fs] [Qemu-devel] [PATCH 0/4] virtiofsd: multithreading preparation part 3
Date: Mon, 5 Aug 2019 17:40:26 +0800	[thread overview]
Message-ID: <5D47F98A.5060807@huawei.com> (raw)
In-Reply-To: <20190805080156.GA22337@stefanha-x1.localdomain>

Hi Stefan,

On 2019/8/5 16:01, Stefan Hajnoczi wrote:
> On Mon, Aug 05, 2019 at 10:52:21AM +0800, piaojun wrote:
>> # fio -direct=1 -time_based -iodepth=1 -rw=randwrite -ioengine=libaio -bs=1M -size=1G -numjob=1 -runtime=30 -group_reporting -name=file -filename=/mnt/9pshare/file
> 
> This benchmark configuration (--iodepth=1 --numjobs=1) cannot benefit
> from virtiofsd multithreading.  Have you measured a regression when this
> patch series is applied?
> 
> If your benchmark is unrelated to this patch series, let's discuss it in
> a separate email thread.  fuse_buf_copy() can be optimized to use
> pwritev().
> 
> Thanks,
> Stefan

Yes, I have not applied your patch series and test. As you said, I will
discuss *pwritev* in another email.

Thanks,
Jun

> 


WARNING: multiple messages have this Message-ID (diff)
From: piaojun <piaojun@huawei.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3
Date: Mon, 5 Aug 2019 17:40:26 +0800	[thread overview]
Message-ID: <5D47F98A.5060807@huawei.com> (raw)
In-Reply-To: <20190805080156.GA22337@stefanha-x1.localdomain>

Hi Stefan,

On 2019/8/5 16:01, Stefan Hajnoczi wrote:
> On Mon, Aug 05, 2019 at 10:52:21AM +0800, piaojun wrote:
>> # fio -direct=1 -time_based -iodepth=1 -rw=randwrite -ioengine=libaio -bs=1M -size=1G -numjob=1 -runtime=30 -group_reporting -name=file -filename=/mnt/9pshare/file
> 
> This benchmark configuration (--iodepth=1 --numjobs=1) cannot benefit
> from virtiofsd multithreading.  Have you measured a regression when this
> patch series is applied?
> 
> If your benchmark is unrelated to this patch series, let's discuss it in
> a separate email thread.  fuse_buf_copy() can be optimized to use
> pwritev().
> 
> Thanks,
> Stefan

Yes, I have not applied your patch series and test. As you said, I will
discuss *pwritev* in another email.

Thanks,
Jun

> 


  reply	other threads:[~2019-08-05  9:40 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01 16:54 [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3 Stefan Hajnoczi
2019-08-01 16:54 ` [Qemu-devel] " Stefan Hajnoczi
2019-08-01 16:54 ` [Virtio-fs] [PATCH 1/4] virtiofsd: process requests in a thread pool Stefan Hajnoczi
2019-08-01 16:54   ` [Qemu-devel] " Stefan Hajnoczi
2019-08-05 12:02   ` [Virtio-fs] " Dr. David Alan Gilbert
2019-08-05 12:02     ` [Qemu-devel] " Dr. David Alan Gilbert
2019-08-07  9:35     ` [Virtio-fs] " Stefan Hajnoczi
2019-08-07  9:35       ` [Qemu-devel] " Stefan Hajnoczi
2019-08-01 16:54 ` [Virtio-fs] [PATCH 2/4] virtiofsd: prevent FUSE_INIT/FUSE_DESTROY races Stefan Hajnoczi
2019-08-01 16:54   ` [Qemu-devel] " Stefan Hajnoczi
2019-08-05 12:26   ` [Virtio-fs] " Dr. David Alan Gilbert
2019-08-05 12:26     ` [Qemu-devel] " Dr. David Alan Gilbert
2019-08-01 16:54 ` [Virtio-fs] [PATCH 3/4] virtiofsd: fix lo_destroy() resource leaks Stefan Hajnoczi
2019-08-01 16:54   ` [Qemu-devel] " Stefan Hajnoczi
2019-08-05 15:17   ` [Virtio-fs] " Dr. David Alan Gilbert
2019-08-05 15:17     ` [Qemu-devel] " Dr. David Alan Gilbert
2019-08-05 18:57     ` [Virtio-fs] " Dr. David Alan Gilbert
2019-08-05 18:57       ` [Qemu-devel] " Dr. David Alan Gilbert
2019-08-06 18:58       ` [Virtio-fs] " Dr. David Alan Gilbert
2019-08-06 18:58         ` [Qemu-devel] " Dr. David Alan Gilbert
2019-08-07  9:41       ` [Virtio-fs] " Stefan Hajnoczi
2019-08-07  9:41         ` [Qemu-devel] " Stefan Hajnoczi
2019-08-01 16:54 ` [Virtio-fs] [PATCH 4/4] virtiofsd: add --thread-pool-size=NUM option Stefan Hajnoczi
2019-08-01 16:54   ` [Qemu-devel] " Stefan Hajnoczi
2019-08-05  2:52 ` [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3 piaojun
2019-08-05  2:52   ` [Qemu-devel] " piaojun
2019-08-05  8:01   ` [Virtio-fs] [Qemu-devel] " Stefan Hajnoczi
2019-08-05  8:01     ` [Qemu-devel] [Virtio-fs] " Stefan Hajnoczi
2019-08-05  9:40     ` piaojun [this message]
2019-08-05  9:40       ` piaojun
2019-08-07 18:03 ` Stefan Hajnoczi
2019-08-07 18:03   ` [Qemu-devel] " Stefan Hajnoczi
2019-08-07 20:57   ` [Virtio-fs] " Vivek Goyal
2019-08-07 20:57     ` [Qemu-devel] " Vivek Goyal
2019-08-08  9:02     ` Stefan Hajnoczi
2019-08-08  9:02       ` [Qemu-devel] " Stefan Hajnoczi
2019-08-08  9:53       ` Dr. David Alan Gilbert
2019-08-08  9:53         ` [Qemu-devel] " Dr. David Alan Gilbert
2019-08-08 12:53         ` Vivek Goyal
2019-08-08 12:53           ` [Qemu-devel] " Vivek Goyal
2019-08-09  8:23           ` Stefan Hajnoczi
2019-08-09  8:23             ` [Qemu-devel] " Stefan Hajnoczi
2019-08-10 21:35           ` Liu Bo
2019-08-10 21:35             ` [Qemu-devel] " Liu Bo
2019-08-09  8:21         ` Stefan Hajnoczi
2019-08-09  8:21           ` [Qemu-devel] " Stefan Hajnoczi
2019-08-10 21:34           ` Liu Bo
2019-08-10 21:34             ` [Qemu-devel] " Liu Bo
2019-08-11  2:26           ` piaojun
2019-08-11  2:26             ` [Qemu-devel] " piaojun
2019-08-12 10:05             ` Stefan Hajnoczi
2019-08-12 10:05               ` [Qemu-devel] " Stefan Hajnoczi
2019-08-12 11:58               ` piaojun
2019-08-12 11:58                 ` [Qemu-devel] " piaojun
2019-08-12 12:51                 ` Dr. David Alan Gilbert
2019-08-12 12:51                   ` [Qemu-devel] " Dr. David Alan Gilbert
2019-08-08  8:10   ` piaojun
2019-08-08  8:10     ` [Qemu-devel] " piaojun
2019-08-08  9:53     ` Stefan Hajnoczi
2019-08-08  9:53       ` [Qemu-devel] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5D47F98A.5060807@huawei.com \
    --to=piaojun@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.