From: Mike Christie <mchristi@redhat.com>
To: target-devel@vger.kernel.org
Subject: Re: [RFC PATCH v2] target: tcmu: clean the nl_cmd of the udev when nl send fails
Date: Mon, 05 Aug 2019 17:15:50 +0000 [thread overview]
Message-ID: <5D486446.8010807@redhat.com> (raw)
In-Reply-To: <20190805004336.16181-1-lizhongfs@gmail.com>
On 08/04/2019 07:43 PM, Li Zhong wrote:
> If the userspace process crashes while we send the nl msg, it is possible
> that the cmd in curr_nl_cmd of tcmu_dev never gets reset to 0, and
> and returns busy for other commands after the userspace process is
> restartd.
>
> More details below:
>
> /backstores/user:file/file> set attribute dev_size 48
> Cannot set attribute dev_size: [Errno 3] No such process
> /backstores/user:file/file> set attribute dev_size 48
> Cannot set attribute dev_size: [Errno 16] Device or resource busy
>
> with following kernel messages:
> [173605.747169] Unable to reconfigure device
> [173616.686674] tcmu daemon: command reply support 1.
> [173623.866978] netlink cmd 3 already executing on file
> [173623.866984] Unable to reconfigure device
>
> Also, it is not safe to leave the nl_cmd in the list, and not get
> deleted.
>
> This patch removes the nl_cmd from the list, and clear its data if
> it is not sent successfully.
>
> Signed-off-by: Li Zhong <lizhongfs@gmail.com>
Acked-by: Mike Christie <mchristi@redhat.com>
next prev parent reply other threads:[~2019-08-05 17:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 10:38 [RFC PATCH] target: tcmu: clean the nl_cmd of the udev when nl send fails Li Zhong
2019-08-02 16:58 ` Mike Christie
2019-08-05 0:43 ` [RFC PATCH v2] " Li Zhong
2019-08-05 17:15 ` Mike Christie [this message]
2019-08-08 1:52 ` Martin K. Petersen
2019-08-08 1:52 ` Martin K. Petersen
2019-08-05 0:36 ` [RFC PATCH] " Li Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D486446.8010807@redhat.com \
--to=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.