All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Li Zhong <lizhongfs@gmail.com>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
	martin.petersen@oracle.com, mchristi@redhat.com
Subject: Re: [RFC PATCH v2] target: tcmu: clean the nl_cmd of the udev when nl send fails
Date: Wed, 07 Aug 2019 21:52:36 -0400	[thread overview]
Message-ID: <yq1sgqcctjv.fsf@oracle.com> (raw)
In-Reply-To: <20190805004336.16181-1-lizhongfs@gmail.com> (Li Zhong's message of "Mon, 5 Aug 2019 08:43:36 +0800")


Li,

> If the userspace process crashes while we send the nl msg, it is
> possible that the cmd in curr_nl_cmd of tcmu_dev never gets reset to
> 0, and and returns busy for other commands after the userspace process
> is restartd.

Applied to 5.4/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Li Zhong <lizhongfs@gmail.com>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
	martin.petersen@oracle.com, mchristi@redhat.com
Subject: Re: [RFC PATCH v2] target: tcmu: clean the nl_cmd of the udev when nl send fails
Date: Thu, 08 Aug 2019 01:52:36 +0000	[thread overview]
Message-ID: <yq1sgqcctjv.fsf@oracle.com> (raw)
In-Reply-To: <20190805004336.16181-1-lizhongfs@gmail.com> (Li Zhong's message of "Mon, 5 Aug 2019 08:43:36 +0800")


Li,

> If the userspace process crashes while we send the nl msg, it is
> possible that the cmd in curr_nl_cmd of tcmu_dev never gets reset to
> 0, and and returns busy for other commands after the userspace process
> is restartd.

Applied to 5.4/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

  parent reply	other threads:[~2019-08-08  1:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02 10:38 [RFC PATCH] target: tcmu: clean the nl_cmd of the udev when nl send fails Li Zhong
2019-08-02 16:58 ` Mike Christie
2019-08-05  0:43   ` [RFC PATCH v2] " Li Zhong
2019-08-05 17:15     ` Mike Christie
2019-08-08  1:52     ` Martin K. Petersen [this message]
2019-08-08  1:52       ` Martin K. Petersen
2019-08-05  0:36 ` [RFC PATCH] " Li Zhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1sgqcctjv.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lizhongfs@gmail.com \
    --cc=mchristi@redhat.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.