[PATCH 0/1] drm/hisilicon/hibmc: Make CONFIG_DRM_HISI_HIBMC depend on ARM64

[PATCH 0/1] drm/hisilicon/hibmc: Make CONFIG_DRM_HISI_HIBMC depend on ARM64

[Matthew Ruffell]

Hi,

amd64 based Huawei servers have problems where the display output of their iBMC 
chips is broken, resulting in a "blurry" screen when viewed from their in house 
remote kvm-like console.

Example:

https://launchpadlibrarian.net/365907668/creen_picture_for_blur.png

The issue is caused by the hibmc_drm kernel module being loaded. The PCI ID for 
the iBMC chips on amd64 hardware is the same as arm64 hardware, but the
hibmc_drm driver was developed only for use on arm64 hardware, most notably for 
the Huawei D05 development board.

The impact to Huawei is that their customers cannot use Ubuntu server install
media as the screen goes "blurry" when the d-i install media or subuqity
installer loads the hibmc_drm kernel module after language selection.

The only workaround for their customers is to press the "E" key during the very 
first installer menu and adding "modprobe.blacklist=hibmc_drm" to the kernel 
command line in the grub menu. This is not good for customer experience with 
their servers.

Huawei help site on the matter:

https://support.huawei.com/enterprise/en/knowledge/EKB1100015521

Other problems exist for the hibmc_drm driver on amd64, such as working on
bios, but not uefi, and not being wayland compatible, making the screen "blurry" 
whenever a desktop session is started and gdm loaded.

More information about the above can be found on Launchpad:

https://bugs.launchpad.net/bugs/1762940

Huawei have asked us to remove hibmc_drm from all architectures except arm64,
and this aligns with advice from Hisilicon.

Hibmc maintainers, can you please review the status of hibmc_drm on amd64 and
confirm that these issues exist, and consider merging the patch to update
Kconfig to set CONFIG_DRM_HISI_HIBMC arm64 only.

Matthew Ruffell (1):
  drm/hisilicon/hibmc: Make CONFIG_DRM_HISI_HIBMC depend on ARM64

 drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/1] drm/hisilicon/hibmc: Make CONFIG_DRM_HISI_HIBMC depend on ARM64

[Matthew Ruffell]

Hisilicon developed hibmc_drm for their arm64 based soc and did not
intend for this driver to be used on any other architecture than arm64.

Using it on amd64 leads to incorrect video modes being used, making
the screen unreadable, forcing users to manually blacklist the module
on the kernel command line to use the d-i server installer or any
graphical sessions.

Make CONFIG_DRM_HISI_HIBMC firmly depend on ARM64 to ensure it is not
built for other architectures.

Signed-off-by: Matthew Ruffell <matthew.ruffell@canonical.com>
---
 drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/Kconfig b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
index f20eedf0073a..35a3c5f0c38c 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/Kconfig
+++ b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_HISI_HIBMC
 	tristate "DRM Support for Hisilicon Hibmc"
-	depends on DRM && PCI && MMU
+	depends on DRM && PCI && MMU && ARM64
 	select DRM_KMS_HELPER
 	select DRM_VRAM_HELPER
 
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/1] drm/hisilicon/hibmc: Make CONFIG_DRM_HISI_HIBMC depend on ARM64

[xinliang]

On 2019/8/15 12:26, Matthew Ruffell wrote:
> Hi,
>
> amd64 based Huawei servers have problems where the display output of their iBMC
> chips is broken, resulting in a "blurry" screen when viewed from their in house
> remote kvm-like console.
>
> Example:
>
> https://launchpadlibrarian.net/365907668/creen_picture_for_blur.png
>
> The issue is caused by the hibmc_drm kernel module being loaded. The PCI ID for
> the iBMC chips on amd64 hardware is the same as arm64 hardware, but the
> hibmc_drm driver was developed only for use on arm64 hardware, most notably for
> the Huawei D05 development board.
>
> The impact to Huawei is that their customers cannot use Ubuntu server install
> media as the screen goes "blurry" when the d-i install media or subuqity
> installer loads the hibmc_drm kernel module after language selection.
>
> The only workaround for their customers is to press the "E" key during the very
> first installer menu and adding "modprobe.blacklist=hibmc_drm" to the kernel
> command line in the grub menu. This is not good for customer experience with
> their servers.
>
> Huawei help site on the matter:
>
> https://support.huawei.com/enterprise/en/knowledge/EKB1100015521
>
> Other problems exist for the hibmc_drm driver on amd64, such as working on
> bios, but not uefi, and not being wayland compatible, making the screen "blurry"
> whenever a desktop session is started and gdm loaded.
>
> More information about the above can be found on Launchpad:
>
> https://bugs.launchpad.net/bugs/1762940
>
> Huawei have asked us to remove hibmc_drm from all architectures except arm64,
> and this aligns with advice from Hisilicon.
>
> Hibmc maintainers, can you please review the status of hibmc_drm on amd64 and
> confirm that these issues exist, and consider merging the patch to update
> Kconfig to set CONFIG_DRM_HISI_HIBMC arm64 only.
>
> Matthew Ruffell (1):
>    drm/hisilicon/hibmc: Make CONFIG_DRM_HISI_HIBMC depend on ARM64
>
>   drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Matthew for the patch.
For the patch,
Acked-by: Xinliang Liu <z.liuxinliang@hisilicon.com>
And applied and will push to drm maintainer soon.

Thanks,
Xinliang

>


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel