From: zhong jiang <zhongjiang@huawei.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Arvid Brodin <arvid.brodin@alten.se>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: net: hsr: remove a redundant null check before kfree_skb
Date: Wed, 04 Sep 2019 15:21:01 +0000 [thread overview]
Message-ID: <5D6FD65D.1060507@huawei.com> (raw)
In-Reply-To: <ce4f53c1-fd91-af5b-7f0a-4746c3ad8de1@web.de>
On 2019/9/4 19:55, Markus Elfring wrote:
>> kfree_skb has taken the null pointer into account.
> I suggest to take another look also at information around
> a similar update suggestion.
>
> net-hsr: Delete unnecessary checks before the function call "kfree_skb"
> https://lkml.org/lkml/2015/11/14/120
> https://lore.kernel.org/patchwork/patch/617878/
> https://lore.kernel.org/r/5647A77E.6040501@users.sourceforge.net/
>
> https://lkml.org/lkml/2015/11/24/433
> https://lore.kernel.org/r/56546951.9080101@alten.se/
Thanks you for explaination. I miss the similar patch before sending it.
Sincerely,
zhong jiang
> Regards,
> Markus
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: zhong jiang <zhongjiang@huawei.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Arvid Brodin <arvid.brodin@alten.se>,
"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: net: hsr: remove a redundant null check before kfree_skb
Date: Wed, 4 Sep 2019 23:21:01 +0800 [thread overview]
Message-ID: <5D6FD65D.1060507@huawei.com> (raw)
In-Reply-To: <ce4f53c1-fd91-af5b-7f0a-4746c3ad8de1@web.de>
On 2019/9/4 19:55, Markus Elfring wrote:
>> kfree_skb has taken the null pointer into account.
> I suggest to take another look also at information around
> a similar update suggestion.
>
> net-hsr: Delete unnecessary checks before the function call "kfree_skb"
> https://lkml.org/lkml/2015/11/14/120
> https://lore.kernel.org/patchwork/patch/617878/
> https://lore.kernel.org/r/5647A77E.6040501@users.sourceforge.net/
>
> https://lkml.org/lkml/2015/11/24/433
> https://lore.kernel.org/r/56546951.9080101@alten.se/
Thanks you for explaination. I miss the similar patch before sending it.
Sincerely,
zhong jiang
> Regards,
> Markus
>
> .
>
next prev parent reply other threads:[~2019-09-04 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 3:09 [PATCH] net: hsr: remove an redundant null check before kfree_skb zhong jiang
2019-09-04 11:55 ` net: hsr: remove a " Markus Elfring
2019-09-04 11:55 ` Markus Elfring
2019-09-04 15:21 ` zhong jiang [this message]
2019-09-04 15:21 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D6FD65D.1060507@huawei.com \
--to=zhongjiang@huawei.com \
--cc=Markus.Elfring@web.de \
--cc=arvid.brodin@alten.se \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.