From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] fsx: Add '-a' option to skip unsupported keep size automatically
Date: Tue, 7 Jan 2020 15:44:17 +0800 [thread overview]
Message-ID: <5E1436D1.9030601@cn.fujitsu.com> (raw)
In-Reply-To: <CAOQ4uxijoQugy_qqpfmyFmF4GcCOenbL7eX8d2aEEGknfe_UQg@mail.gmail.com>
On 2020/1/7 14:47, Amir Goldstein wrote:
> No it is not wrong, but this is different than skipping keep_size.
> My point is that when fsx is run with some parameters and
> produces a replay-ops log. If that replay-ops log is replayed with
> exact same parameters it should produce the exact same sequence.
>
> In the case of punch/zero/collapse, if those are skipped when recording
> the ops log, then ops log includes the keyword "skip ..." explicitly, but
> but for skipped keep_size, keep_size will simply not be in the log.
Hi Amir,
If keep_size is not supported, ops log can also includes the keyword
"skip ..." by Eryu's patch:
https://lore.kernel.org/fstests/20191022123115.12250-1-eguan@linux.alibaba.com/
Do you want to add require support for keep_size/punch/zero/collapse and
accept Eryu's patch as well?
Thanks,
Xiao Yang
>
> IOW, the fsxops logs that are hardcoded in the 4 tests that you changed
> have all been created*with* keep_size support and*with* punch/zero/collapse
> support, so should also be replayed the same way, because otherwise the test
> is simply not doing what it was intended to do.
next prev parent reply other threads:[~2020-01-07 7:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 7:06 [PATCH v2 1/2] ltp/fsx.c: Add FALLOC_FL_KEEP_SIZE flag and '-K' option Xiao Yang
2020-01-06 7:06 ` [PATCH v2 2/2] fsx: Add '-a' option to skip unsupported keep size automatically Xiao Yang
2020-01-06 11:24 ` Amir Goldstein
2020-01-07 2:10 ` Xiao Yang
2020-01-07 6:47 ` Amir Goldstein
2020-01-07 7:44 ` Xiao Yang [this message]
2020-01-07 8:49 ` Amir Goldstein
2020-01-13 2:06 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5E1436D1.9030601@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.