From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Eryu Guan <eguan@linux.alibaba.com>
Cc: fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] fsx: Add '-a' option to skip unsupported keep size automatically
Date: Mon, 13 Jan 2020 10:06:56 +0800 [thread overview]
Message-ID: <5E1BD0C0.4040704@cn.fujitsu.com> (raw)
In-Reply-To: <CAOQ4uxjYmGXsRhGe76KSqfS3k-aMsad=bGdmm-wwMOXyDKFRyA@mail.gmail.com>
On 2020/1/7 16:49, Amir Goldstein wrote:
>> > If keep_size is not supported, ops log can also includes the keyword
>> > "skip ..." by Eryu's patch:
>> > https://lore.kernel.org/fstests/20191022123115.12250-1-eguan@linux.alibaba.com/
>> >
>> > Do you want to add require support for keep_size/punch/zero/collapse and
>> > accept Eryu's patch as well?
>> >
> I am perfectly fine with Eryu's patch and I think it is correct to merge it,
> but it is completely independent to fixing the 4 tests.
Hi Eryu,
These 4 tests need the exact operations to reproduce some issues by
--replay-ops so Amir perfer to skip tests rather than one operation
if a required operation/flag in tests is not supported.
I think it is reasonable to skip these tests in the case so I have sent
v3 patch set[1][2]:
https://www.spinics.net/lists/fstests/msg13290.html
https://www.spinics.net/lists/fstests/msg13291.html
With my v3 patch set, it seems that these 4 tests have no chance to fall
into the condition described by your patch:
https://lore.kernel.org/fstests/20191022123115.12250-1-eguan@linux.alibaba.com/
Best Regards,
Xiao Yang
prev parent reply other threads:[~2020-01-13 2:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 7:06 [PATCH v2 1/2] ltp/fsx.c: Add FALLOC_FL_KEEP_SIZE flag and '-K' option Xiao Yang
2020-01-06 7:06 ` [PATCH v2 2/2] fsx: Add '-a' option to skip unsupported keep size automatically Xiao Yang
2020-01-06 11:24 ` Amir Goldstein
2020-01-07 2:10 ` Xiao Yang
2020-01-07 6:47 ` Amir Goldstein
2020-01-07 7:44 ` Xiao Yang
2020-01-07 8:49 ` Amir Goldstein
2020-01-13 2:06 ` Xiao Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5E1BD0C0.4040704@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=eguan@linux.alibaba.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.