All of lore.kernel.org
 help / color / mirror / Atom feed
* [Virtio-fs] [PATCH] virtiofsd/helper: Add shared/no_shared options to help message
@ 2020-02-10 10:44 Xiao Yang
  2020-02-24  2:42   ` Xiao Yang
  2020-03-04 18:54 ` [Virtio-fs] " Dr. David Alan Gilbert
  0 siblings, 2 replies; 5+ messages in thread
From: Xiao Yang @ 2020-02-10 10:44 UTC (permalink / raw)
  To: virtio-fs

From: Xiao Yang <yangx.jy@cn.fujitsu.com>

Also add a hint that user should start 'ireg' daemon before using shared cache.

Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
 tools/virtiofsd/helper.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
index 819c2bc13c..0aa02b99b0 100644
--- a/tools/virtiofsd/helper.c
+++ b/tools/virtiofsd/helper.c
@@ -171,6 +171,10 @@ void fuse_cmdline_help(void)
            "                               default: no_writeback\n"
            "    -o xattr|no_xattr          enable/disable xattr\n"
            "                               default: no_xattr\n"
+           "    -o shared|no_shared        enable/disable shared cache\n"
+           "                               default: no_shared\n"
+           "                               please start 'ireg' daemon before "
+           "using shared cache\n"
            );
 }
 
-- 
2.21.0




^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Virtio-fs] [PATCH] virtiofsd/helper: Add shared/no_shared options to help message
  2020-02-10 10:44 [Virtio-fs] [PATCH] virtiofsd/helper: Add shared/no_shared options to help message Xiao Yang
@ 2020-02-24  2:42   ` Xiao Yang
  2020-03-04 18:54 ` [Virtio-fs] " Dr. David Alan Gilbert
  1 sibling, 0 replies; 5+ messages in thread
From: Xiao Yang @ 2020-02-24  2:42 UTC (permalink / raw)
  To: Dr. David Alan Gilbert; +Cc: virtio-fs, qemu-devel

Hi David,

Do you have any comment on this patch? :-)
Cc qemu-devel@nongnu.org

Best Regards,
Xiao Yang

On 2020/2/10 18:44, Xiao Yang wrote:
> From: Xiao Yang <yangx.jy@cn.fujitsu.com>
>
> Also add a hint that user should start 'ireg' daemon before using shared cache.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
>  tools/virtiofsd/helper.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
> index 819c2bc13c..0aa02b99b0 100644
> --- a/tools/virtiofsd/helper.c
> +++ b/tools/virtiofsd/helper.c
> @@ -171,6 +171,10 @@ void fuse_cmdline_help(void)
>             "                               default: no_writeback\n"
>             "    -o xattr|no_xattr          enable/disable xattr\n"
>             "                               default: no_xattr\n"
> +           "    -o shared|no_shared        enable/disable shared cache\n"
> +           "                               default: no_shared\n"
> +           "                               please start 'ireg' daemon before "
> +           "using shared cache\n"
>             );
>  }
>  





^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] virtiofsd/helper: Add shared/no_shared options to help message
@ 2020-02-24  2:42   ` Xiao Yang
  0 siblings, 0 replies; 5+ messages in thread
From: Xiao Yang @ 2020-02-24  2:42 UTC (permalink / raw)
  To: Dr. David Alan Gilbert; +Cc: virtio-fs, qemu-devel

Hi David,

Do you have any comment on this patch? :-)
Cc qemu-devel@nongnu.org

Best Regards,
Xiao Yang

On 2020/2/10 18:44, Xiao Yang wrote:
> From: Xiao Yang <yangx.jy@cn.fujitsu.com>
>
> Also add a hint that user should start 'ireg' daemon before using shared cache.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
>  tools/virtiofsd/helper.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
> index 819c2bc13c..0aa02b99b0 100644
> --- a/tools/virtiofsd/helper.c
> +++ b/tools/virtiofsd/helper.c
> @@ -171,6 +171,10 @@ void fuse_cmdline_help(void)
>             "                               default: no_writeback\n"
>             "    -o xattr|no_xattr          enable/disable xattr\n"
>             "                               default: no_xattr\n"
> +           "    -o shared|no_shared        enable/disable shared cache\n"
> +           "                               default: no_shared\n"
> +           "                               please start 'ireg' daemon before "
> +           "using shared cache\n"
>             );
>  }
>  





^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Virtio-fs] [PATCH] virtiofsd/helper: Add shared/no_shared options to help message
  2020-02-10 10:44 [Virtio-fs] [PATCH] virtiofsd/helper: Add shared/no_shared options to help message Xiao Yang
  2020-02-24  2:42   ` Xiao Yang
@ 2020-03-04 18:54 ` Dr. David Alan Gilbert
  2020-03-05  1:52   ` Xiao Yang
  1 sibling, 1 reply; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2020-03-04 18:54 UTC (permalink / raw)
  To: Xiao Yang; +Cc: virtio-fs

* Xiao Yang (ice_yangxiao@163.com) wrote:
> From: Xiao Yang <yangx.jy@cn.fujitsu.com>
> 
> Also add a hint that user should start 'ireg' daemon before using shared cache.

Apologies for the delay; I've squashed that into 'add initial support
for shared versions'.

Dave

> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
>  tools/virtiofsd/helper.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
> index 819c2bc13c..0aa02b99b0 100644
> --- a/tools/virtiofsd/helper.c
> +++ b/tools/virtiofsd/helper.c
> @@ -171,6 +171,10 @@ void fuse_cmdline_help(void)
>             "                               default: no_writeback\n"
>             "    -o xattr|no_xattr          enable/disable xattr\n"
>             "                               default: no_xattr\n"
> +           "    -o shared|no_shared        enable/disable shared cache\n"
> +           "                               default: no_shared\n"
> +           "                               please start 'ireg' daemon before "
> +           "using shared cache\n"
>             );
>  }
>  
> -- 
> 2.21.0
> 
> 
> 
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Virtio-fs] [PATCH] virtiofsd/helper: Add shared/no_shared options to help message
  2020-03-04 18:54 ` [Virtio-fs] " Dr. David Alan Gilbert
@ 2020-03-05  1:52   ` Xiao Yang
  0 siblings, 0 replies; 5+ messages in thread
From: Xiao Yang @ 2020-03-05  1:52 UTC (permalink / raw)
  To: Dr. David Alan Gilbert; +Cc: virtio-fs

On 2020/3/5 2:54, Dr. David Alan Gilbert wrote:
> * Xiao Yang (ice_yangxiao@163.com) wrote:
>> From: Xiao Yang<yangx.jy@cn.fujitsu.com>
>>
>> Also add a hint that user should start 'ireg' daemon before using shared cache.
>
> Apologies for the delay; I've squashed that into 'add initial support
> for shared versions'.
Hi Dave,

Thanks for your reply.  Your change is ok for me.

Thanks,
Xiao Yang

>
> Dave
>
>> Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
>> ---
>>   tools/virtiofsd/helper.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
>> index 819c2bc13c..0aa02b99b0 100644
>> --- a/tools/virtiofsd/helper.c
>> +++ b/tools/virtiofsd/helper.c
>> @@ -171,6 +171,10 @@ void fuse_cmdline_help(void)
>>              "                               default: no_writeback\n"
>>              "    -o xattr|no_xattr          enable/disable xattr\n"
>>              "                               default: no_xattr\n"
>> +           "    -o shared|no_shared        enable/disable shared cache\n"
>> +           "                               default: no_shared\n"
>> +           "                               please start 'ireg' daemon before "
>> +           "using shared cache\n"
>>              );
>>   }
>>
>> --
>> 2.21.0
>>
>>
>>
>> _______________________________________________
>> Virtio-fs mailing list
>> Virtio-fs@redhat.com
>> https://www.redhat.com/mailman/listinfo/virtio-fs
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
>
>
>
> .
>





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-03-05  1:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-10 10:44 [Virtio-fs] [PATCH] virtiofsd/helper: Add shared/no_shared options to help message Xiao Yang
2020-02-24  2:42 ` Xiao Yang
2020-02-24  2:42   ` Xiao Yang
2020-03-04 18:54 ` [Virtio-fs] " Dr. David Alan Gilbert
2020-03-05  1:52   ` Xiao Yang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.