From: Wei Xu <xuwei5@hisilicon.com>
To: Andre Przywara <andre.przywara@arm.com>, <soc@kernel.org>
Cc: Rob Herring <robh@kernel.org>, Chanho Min <chanho.min@lge.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 6/6] ARM: dts: hisilicon: Fix SP805 clocks
Date: Wed, 16 Sep 2020 09:42:42 +0800 [thread overview]
Message-ID: <5F616D92.3070201@hisilicon.com> (raw)
In-Reply-To: <20200907121831.242281-7-andre.przywara@arm.com>
On 2020/9/7 20:18, Andre Przywara wrote:
> The SP805 DT binding requires two clocks to be specified, but
> Hisilicon platform DTs currently only specify one clock.
>
> In practice, Linux would pick a clock named "apb_pclk" for the bus
> clock, and the Linux and U-Boot SP805 driver would use the first clock
> to derive the actual watchdog counter frequency.
>
> Since currently both are the very same clock, we can just double the
> clock reference, and add the correct clock-names, to match the binding.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Thanks!
Applied to the hisilicon arm32 dt tree.
Best Regards,
Wei
> ---
> arch/arm/boot/dts/hisi-x5hd2.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi
> index 3ee7967c202d..e2dbf1d8a67b 100644
> --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi
> +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi
> @@ -370,8 +370,9 @@
> arm,primecell-periphid = <0x00141805>;
> reg = <0xa2c000 0x1000>;
> interrupts = <0 29 4>;
> - clocks = <&clock HIX5HD2_WDG0_RST>;
> - clock-names = "apb_pclk";
> + clocks = <&clock HIX5HD2_WDG0_RST>,
> + <&clock HIX5HD2_WDG0_RST>;
> + clock-names = "wdog_clk", "apb_pclk";
> };
> };
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Wei Xu <xuwei5@hisilicon.com>
To: Andre Przywara <andre.przywara@arm.com>, <soc@kernel.org>
Cc: Rob Herring <robh@kernel.org>, <devicetree@vger.kernel.org>,
Chanho Min <chanho.min@lge.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 6/6] ARM: dts: hisilicon: Fix SP805 clocks
Date: Wed, 16 Sep 2020 09:42:42 +0800 [thread overview]
Message-ID: <5F616D92.3070201@hisilicon.com> (raw)
In-Reply-To: <20200907121831.242281-7-andre.przywara@arm.com>
On 2020/9/7 20:18, Andre Przywara wrote:
> The SP805 DT binding requires two clocks to be specified, but
> Hisilicon platform DTs currently only specify one clock.
>
> In practice, Linux would pick a clock named "apb_pclk" for the bus
> clock, and the Linux and U-Boot SP805 driver would use the first clock
> to derive the actual watchdog counter frequency.
>
> Since currently both are the very same clock, we can just double the
> clock reference, and add the correct clock-names, to match the binding.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Thanks!
Applied to the hisilicon arm32 dt tree.
Best Regards,
Wei
> ---
> arch/arm/boot/dts/hisi-x5hd2.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi
> index 3ee7967c202d..e2dbf1d8a67b 100644
> --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi
> +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi
> @@ -370,8 +370,9 @@
> arm,primecell-periphid = <0x00141805>;
> reg = <0xa2c000 0x1000>;
> interrupts = <0 29 4>;
> - clocks = <&clock HIX5HD2_WDG0_RST>;
> - clock-names = "apb_pclk";
> + clocks = <&clock HIX5HD2_WDG0_RST>,
> + <&clock HIX5HD2_WDG0_RST>;
> + clock-names = "wdog_clk", "apb_pclk";
> };
> };
>
>
next prev parent reply other threads:[~2020-09-16 1:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 12:18 [PATCH v3 0/6] ARM/arm64: dts: Fix SP804/SP805 users Andre Przywara
2020-09-07 12:18 ` Andre Przywara
2020-09-07 12:18 ` [PATCH v3 1/6] ARM: dts: hisilicon: Fix SP804 users Andre Przywara
2020-09-07 12:18 ` Andre Przywara
2020-09-16 1:44 ` Wei Xu
2020-09-16 1:44 ` Wei Xu
2020-09-07 12:18 ` [PATCH v3 2/6] ARM: dts: nspire: " Andre Przywara
2020-09-07 12:18 ` Andre Przywara
2020-09-07 12:18 ` [PATCH v3 3/6] arm64: dts: lg: " Andre Przywara
2020-09-07 12:18 ` Andre Przywara
2020-09-07 12:18 ` [PATCH v3 4/6] arm64: dts: hisilicon: Fix SP805 clocks Andre Przywara
2020-09-07 12:18 ` Andre Przywara
2020-09-16 1:45 ` Wei Xu
2020-09-16 1:45 ` Wei Xu
2020-09-07 12:18 ` [PATCH v3 5/6] arm64: dts: lg: " Andre Przywara
2020-09-07 12:18 ` Andre Przywara
2020-09-07 12:18 ` [PATCH v3 6/6] ARM: dts: hisilicon: " Andre Przywara
2020-09-07 12:18 ` Andre Przywara
2020-09-16 1:42 ` Wei Xu [this message]
2020-09-16 1:42 ` Wei Xu
2020-10-03 19:57 ` [PATCH v3 0/6] ARM/arm64: dts: Fix SP804/SP805 users Olof Johansson
2020-10-03 19:57 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F616D92.3070201@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=andre.przywara@arm.com \
--cc=chanho.min@lge.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.