From: AlexChen <alex.chen@huawei.com>
To: <alex.bennee@linaro.org>, <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>
Cc: <qemu-devel@nongnu.org>, <qemu-trivial@nongnu.org>,
<zhang.zhanghailiang@huawei.com>, <zhengchuan@huawei.com>
Subject: Re: [PATCH 1/2] plugins: Fix resource leak in connect_socket()
Date: Thu, 5 Nov 2020 14:53:48 +0800 [thread overview]
Message-ID: <5FA3A17C.30108@huawei.com> (raw)
In-Reply-To: <5F9975E7.6030509@huawei.com>
Kindly ping.
On 2020/10/28 21:45, AlexChen wrote:
> Close the fd when connect() fails.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
> contrib/plugins/lockstep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
> index a696673dff..319bd44b83 100644
> --- a/contrib/plugins/lockstep.c
> +++ b/contrib/plugins/lockstep.c
> @@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
>
> if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
> perror("failed to connect");
> + close(fd);
> return false;
> }
>
WARNING: multiple messages have this Message-ID (diff)
From: AlexChen <alex.chen@huawei.com>
To: <alex.bennee@linaro.org>, <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>
Cc: qemu-trivial@nongnu.org, zhengchuan@huawei.com,
qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com
Subject: Re: [PATCH 1/2] plugins: Fix resource leak in connect_socket()
Date: Thu, 5 Nov 2020 14:53:48 +0800 [thread overview]
Message-ID: <5FA3A17C.30108@huawei.com> (raw)
In-Reply-To: <5F9975E7.6030509@huawei.com>
Kindly ping.
On 2020/10/28 21:45, AlexChen wrote:
> Close the fd when connect() fails.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
> contrib/plugins/lockstep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
> index a696673dff..319bd44b83 100644
> --- a/contrib/plugins/lockstep.c
> +++ b/contrib/plugins/lockstep.c
> @@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
>
> if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
> perror("failed to connect");
> + close(fd);
> return false;
> }
>
next prev parent reply other threads:[~2020-11-05 6:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 13:45 [PATCH 1/2] plugins: Fix resource leak in connect_socket() AlexChen
2020-10-28 13:45 ` AlexChen
2020-11-05 6:53 ` AlexChen [this message]
2020-11-05 6:53 ` AlexChen
2020-11-05 10:37 ` Alex Bennée
2020-11-05 10:37 ` Alex Bennée
2020-11-06 1:40 ` AlexChen
2020-11-06 1:40 ` AlexChen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5FA3A17C.30108@huawei.com \
--to=alex.chen@huawei.com \
--cc=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.