All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2 2/2] plugins: Fix two resource leaks in setup_socket()
@ 2020-11-06  1:59 ` AlexChen
  0 siblings, 0 replies; 2+ messages in thread
From: AlexChen @ 2020-11-06  1:59 UTC (permalink / raw)
  To: Alex Bennée, Michael Tokarev, Laurent Vivier
  Cc: QEMU, QEMU Trivial, zhang.zhanghailiang

Either accept() fails or exits normally, we need to close the fd.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
---
 contrib/plugins/lockstep.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index 319bd44b83..5aad50869d 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -268,11 +268,13 @@ static bool setup_socket(const char *path)
     socket_fd = accept(fd, NULL, NULL);
     if (socket_fd < 0 && errno != EINTR) {
         perror("accept socket");
+        close(fd);
         return false;
     }

     qemu_plugin_outs("setup_socket::ready\n");

+    close(fd);
     return true;
 }

-- 
2.19.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-06  2:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-06  1:59 [PATCH V2 2/2] plugins: Fix two resource leaks in setup_socket() AlexChen
2020-11-06  1:59 ` AlexChen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.