All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mao Jinlong <quic_jinlmao@quicinc.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	James Clark <james.clark@arm.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	Tingwei Zhang <quic_tingweiz@quicinc.com>,
	Yuanfang Zhang <quic_yuanfang@quicinc.com>,
	Tao Zhang <quic_taozha@quicinc.com>,
	songchai <quic_songchai@quicinc.com>
Subject: Re: [PATCH v1 1/3] dt-bindings: arm: Add trace-id for coresight dummy source
Date: Sun, 19 May 2024 19:46:44 +0200	[thread overview]
Message-ID: <5a4dd2ce-0724-4a54-8909-149ab4b614c6@kernel.org> (raw)
In-Reply-To: <20240516025644.4383-2-quic_jinlmao@quicinc.com>

On 16/05/2024 04:56, Mao Jinlong wrote:
> Add trace-id for static id support to coresight dummy source.
> 
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
>  .../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
> index 6745b4cc8f1c..9adf34ea450e 100644
> --- a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
> @@ -38,6 +38,12 @@ properties:
>      enum:
>        - arm,coresight-dummy-source
>  
> +  trace-id:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      If dummy source needs static id support, use this to set trace id.
> +      The range is 1 to 127.

Missing constraints... and then no need to repeat constraints in free
form text.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mao Jinlong <quic_jinlmao@quicinc.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	James Clark <james.clark@arm.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	Tingwei Zhang <quic_tingweiz@quicinc.com>,
	Yuanfang Zhang <quic_yuanfang@quicinc.com>,
	Tao Zhang <quic_taozha@quicinc.com>,
	songchai <quic_songchai@quicinc.com>
Subject: Re: [PATCH v1 1/3] dt-bindings: arm: Add trace-id for coresight dummy source
Date: Sun, 19 May 2024 19:46:44 +0200	[thread overview]
Message-ID: <5a4dd2ce-0724-4a54-8909-149ab4b614c6@kernel.org> (raw)
In-Reply-To: <20240516025644.4383-2-quic_jinlmao@quicinc.com>

On 16/05/2024 04:56, Mao Jinlong wrote:
> Add trace-id for static id support to coresight dummy source.
> 
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
>  .../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
> index 6745b4cc8f1c..9adf34ea450e 100644
> --- a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
> @@ -38,6 +38,12 @@ properties:
>      enum:
>        - arm,coresight-dummy-source
>  
> +  trace-id:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      If dummy source needs static id support, use this to set trace id.
> +      The range is 1 to 127.

Missing constraints... and then no need to repeat constraints in free
form text.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-05-19 17:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16  2:56 [PATCH v1 0/3] coresight: Add reserve trace id support Mao Jinlong
2024-05-16  2:56 ` Mao Jinlong
2024-05-16  2:56 ` [PATCH v1 1/3] dt-bindings: arm: Add trace-id for coresight dummy source Mao Jinlong
2024-05-16  2:56   ` Mao Jinlong
2024-05-16 13:41   ` James Clark
2024-05-16 13:41     ` James Clark
2024-05-19 17:46   ` Krzysztof Kozlowski [this message]
2024-05-19 17:46     ` Krzysztof Kozlowski
2024-05-16  2:56 ` [PATCH v1 2/3] coresight: Add reserve trace id support Mao Jinlong
2024-05-16  2:56   ` Mao Jinlong
2024-05-16 13:23   ` James Clark
2024-05-16 13:23     ` James Clark
2024-05-16 13:56     ` James Clark
2024-05-16 13:56       ` James Clark
2024-05-20  6:03     ` Jinlong Mao
2024-05-20  6:03       ` Jinlong Mao
2024-05-16  2:56 ` [PATCH v1 3/3] coresight: dummy: Add reserve atid support for dummy source Mao Jinlong
2024-05-16  2:56   ` Mao Jinlong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a4dd2ce-0724-4a54-8909-149ab4b614c6@kernel.org \
    --to=krzk@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=conor+dt@kernel.org \
    --cc=coresight@lists.linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=james.clark@arm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.leach@linaro.org \
    --cc=quic_jinlmao@quicinc.com \
    --cc=quic_songchai@quicinc.com \
    --cc=quic_taozha@quicinc.com \
    --cc=quic_tingweiz@quicinc.com \
    --cc=quic_yuanfang@quicinc.com \
    --cc=robh@kernel.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.