From: Marek Vasut <marek.vasut@gmail.com>
To: Simon Horman <horms@verge.net.au>, Wolfram Sang <wsa@the-dreams.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH] ARM: dts: alt: Add DA9063 PMIC node
Date: Fri, 8 Mar 2019 14:52:50 +0100 [thread overview]
Message-ID: <5a7b34bf-8ae7-a8a0-c1fc-911a9941dae9@gmail.com> (raw)
In-Reply-To: <20190308134043.alpxgnujj6ppmczc@verge.net.au>
On 3/8/19 2:40 PM, Simon Horman wrote:
> On Mon, Mar 04, 2019 at 12:13:49PM +0100, Wolfram Sang wrote:
>> On Mon, Mar 04, 2019 at 11:59:48AM +0100, Marek Vasut wrote:
>>> On 3/4/19 11:57 AM, Wolfram Sang wrote:
>>>>
>>>>>> Add DA9063 PMIC node to the I2C bus.
>>>>>>
>>>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>>>>>
>>>>> Thanks for your patch!
>>>>>
>>>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>>
>>>> Thanks for CCing me, I didn't get and missed the original patch.
>>>>
>>>>>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts
>>>>>> @@ -377,6 +377,27 @@
>>>>>> pinctrl-names = "i2c-exio4";
>>>>>> };
>>>>>>
>>>>>> +&i2c7 {
>>>>>> + status = "okay";
>>>>>> + clock-frequency = <100000>;
>>>>>
>>>>> According to the DA9063 datasheet, the PMIC supports up to 400 kHz.
>>>>> It looks like there are no other devices on the bus.
>>>>>
>>>>> Wolfram, what's your stance on this?
>>>>
>>>> Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but
>>>> seems not. Probably it slipped through the cracks.
>>>
>>> Do we want to update all of the other boards too ?
>>>
>>> I'd be cautious about the DVFS I2C, running faster while talking to the
>>> PMIC and reading/writing a few registers brings little benefit, while
>>> the signal integrity might be impacted.
>>
>> Can be argued. I think if we would apply some testing on top of this
>> change, we will find that it will work. But we would in deed need this
>> testing as verification, and this is not our top priority project. But
>> if someone feels like running some i2c dumping over night, well,
>> why not..
>
> Thanks,
>
> I've applied this patch for v5.2.
> We can do a sweep of frequency updates as a follow-up if we decide
> that is the right way to go.
Do we really want to speed up the PMIC I2C bus ? What are the pros
(none?) and cons (might be unstable) ?
--
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marek.vasut@gmail.com>
To: Simon Horman <horms@verge.net.au>, Wolfram Sang <wsa@the-dreams.de>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>
Subject: Re: [PATCH] ARM: dts: alt: Add DA9063 PMIC node
Date: Fri, 8 Mar 2019 14:52:50 +0100 [thread overview]
Message-ID: <5a7b34bf-8ae7-a8a0-c1fc-911a9941dae9@gmail.com> (raw)
In-Reply-To: <20190308134043.alpxgnujj6ppmczc@verge.net.au>
On 3/8/19 2:40 PM, Simon Horman wrote:
> On Mon, Mar 04, 2019 at 12:13:49PM +0100, Wolfram Sang wrote:
>> On Mon, Mar 04, 2019 at 11:59:48AM +0100, Marek Vasut wrote:
>>> On 3/4/19 11:57 AM, Wolfram Sang wrote:
>>>>
>>>>>> Add DA9063 PMIC node to the I2C bus.
>>>>>>
>>>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>>>>>
>>>>> Thanks for your patch!
>>>>>
>>>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>>
>>>> Thanks for CCing me, I didn't get and missed the original patch.
>>>>
>>>>>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts
>>>>>> @@ -377,6 +377,27 @@
>>>>>> pinctrl-names = "i2c-exio4";
>>>>>> };
>>>>>>
>>>>>> +&i2c7 {
>>>>>> + status = "okay";
>>>>>> + clock-frequency = <100000>;
>>>>>
>>>>> According to the DA9063 datasheet, the PMIC supports up to 400 kHz.
>>>>> It looks like there are no other devices on the bus.
>>>>>
>>>>> Wolfram, what's your stance on this?
>>>>
>>>> Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but
>>>> seems not. Probably it slipped through the cracks.
>>>
>>> Do we want to update all of the other boards too ?
>>>
>>> I'd be cautious about the DVFS I2C, running faster while talking to the
>>> PMIC and reading/writing a few registers brings little benefit, while
>>> the signal integrity might be impacted.
>>
>> Can be argued. I think if we would apply some testing on top of this
>> change, we will find that it will work. But we would in deed need this
>> testing as verification, and this is not our top priority project. But
>> if someone feels like running some i2c dumping over night, well,
>> why not..
>
> Thanks,
>
> I've applied this patch for v5.2.
> We can do a sweep of frequency updates as a follow-up if we decide
> that is the right way to go.
Do we really want to speed up the PMIC I2C bus ? What are the pros
(none?) and cons (might be unstable) ?
--
Best regards,
Marek Vasut
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-08 13:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 19:00 [PATCH] ARM: dts: alt: Add DA9063 PMIC node marek.vasut
2019-03-03 19:00 ` marek.vasut
2019-03-04 10:35 ` Geert Uytterhoeven
2019-03-04 10:35 ` Geert Uytterhoeven
2019-03-04 10:57 ` Wolfram Sang
2019-03-04 10:57 ` Wolfram Sang
2019-03-04 10:59 ` Marek Vasut
2019-03-04 10:59 ` Marek Vasut
2019-03-04 11:13 ` Wolfram Sang
2019-03-04 11:13 ` Wolfram Sang
2019-03-08 13:40 ` Simon Horman
2019-03-08 13:40 ` Simon Horman
2019-03-08 13:52 ` Marek Vasut [this message]
2019-03-08 13:52 ` Marek Vasut
2019-03-08 14:53 ` Wolfram Sang
2019-03-08 14:53 ` Wolfram Sang
2019-03-08 17:46 ` Marek Vasut
2019-03-08 17:46 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a7b34bf-8ae7-a8a0-c1fc-911a9941dae9@gmail.com \
--to=marek.vasut@gmail.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.