From: Segher Boessenkool <segher@kernel.crashing.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org, linux-pcmcia@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [POWERPC] 8xx: mpc885ads pcmcia support
Date: Thu, 3 May 2007 17:43:38 +0200 [thread overview]
Message-ID: <5a7e02f6d1520d8ad02e28ace218981c@kernel.crashing.org> (raw)
In-Reply-To: <200705030948.03984.arnd@arndb.de>
>> + pcmcia@0080 {
>> + compatible = "8xx";
> The compatible property should be a little more specific, imho. Since
> there
> are differences in how things are done depending on the board, it
> would be
> good to tell the exact method from the pcmcia node itself.
Just "8xx" isn't good enough -- at a very minimum it
needs to say this is a PCMCIA controller!
> For example, you could make this
>
> compatible = "8xx\0mpc885ads";
"mpc885ads-pcmcia\0mpc8xx-pcmcia" or something like that.
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
linux-pcmcia@lists.infradead.org
Subject: Re: [PATCH] [POWERPC] 8xx: mpc885ads pcmcia support
Date: Thu, 3 May 2007 17:43:38 +0200 [thread overview]
Message-ID: <5a7e02f6d1520d8ad02e28ace218981c@kernel.crashing.org> (raw)
In-Reply-To: <200705030948.03984.arnd@arndb.de>
>> + pcmcia@0080 {
>> + compatible = "8xx";
> The compatible property should be a little more specific, imho. Since
> there
> are differences in how things are done depending on the board, it
> would be
> good to tell the exact method from the pcmcia node itself.
Just "8xx" isn't good enough -- at a very minimum it
needs to say this is a PCMCIA controller!
> For example, you could make this
>
> compatible = "8xx\0mpc885ads";
"mpc885ads-pcmcia\0mpc8xx-pcmcia" or something like that.
Segher
next prev parent reply other threads:[~2007-05-03 15:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 6:54 [PATCH] [POWERPC] 8xx: mpc885ads pcmcia support Vitaly Bordug
2007-05-03 6:54 ` Vitaly Bordug
2007-05-03 7:48 ` Arnd Bergmann
2007-05-03 7:48 ` Arnd Bergmann
2007-05-03 15:43 ` Segher Boessenkool [this message]
2007-05-03 15:43 ` Segher Boessenkool
2007-05-03 19:03 ` Arnd Bergmann
2007-05-03 19:03 ` Arnd Bergmann
2007-05-03 22:17 ` Segher Boessenkool
2007-05-03 22:17 ` Segher Boessenkool
-- strict thread matches above, loose matches on Subject: below --
2007-05-03 23:57 Vitaly Bordug
2007-05-03 23:57 ` Vitaly Bordug
2007-05-04 0:01 ` Arnd Bergmann
2007-05-04 0:01 ` Arnd Bergmann
2007-05-04 19:35 ` Andrew Morton
2007-05-04 19:35 ` Andrew Morton
2007-05-05 23:27 ` Vitaly Bordug
2007-05-05 23:27 ` Vitaly Bordug
2007-05-06 0:47 Vitaly Bordug
2007-05-06 0:47 ` Vitaly Bordug
2007-05-06 1:04 ` Segher Boessenkool
2007-05-06 1:04 ` Segher Boessenkool
2007-05-06 2:04 ` David Gibson
2007-05-06 2:04 ` David Gibson
2007-05-06 9:48 ` Vitaly Bordug
2007-05-06 9:48 ` Vitaly Bordug
2007-05-06 7:44 ` Vitaly Bordug
2007-05-06 7:44 ` Vitaly Bordug
2007-05-06 13:26 ` Segher Boessenkool
2007-05-06 13:26 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a7e02f6d1520d8ad02e28ace218981c@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.