From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien.grall@linaro.org>, xen-devel@lists.xen.org
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 6/7] xen/tmem: Convert the file common/tmem_xen.c to use typesafe MFN
Date: Wed, 4 Oct 2017 23:46:09 +0100 [thread overview]
Message-ID: <5ac0341e-19c7-e652-eafb-2b056dc69eeb@citrix.com> (raw)
In-Reply-To: <20171004181526.9405-7-julien.grall@linaro.org>
On 04/10/2017 19:15, Julien Grall wrote:
> @@ -68,16 +72,16 @@ static inline void *cli_get_page(xen_pfn_t cmfn, unsigned long *pcli_mfn,
>
> *pcli_mfn = page_to_mfn(page);
> *pcli_pfp = page;
Newline.
> - return map_domain_page(_mfn(*pcli_mfn));
> + return map_domain_page(*pcli_mfn);
> }
>
> static inline void cli_put_page(void *cli_va, struct page_info *cli_pfp,
> - unsigned long cli_mfn, bool mark_dirty)
> + mfn_t cli_mfn, bool mark_dirty)
> {
> if ( mark_dirty )
> {
> put_page_and_type(cli_pfp);
> - paging_mark_dirty(current->domain, _mfn(cli_mfn));
> + paging_mark_dirty(current->domain, cli_mfn);
> }
> else
> put_page(cli_pfp);
> @@ -165,7 +169,7 @@ int tmem_copy_to_client(xen_pfn_t cmfn, struct page_info *pfp,
> return -EFAULT;
> }
> tmem_mfn = page_to_mfn(pfp);
> - tmem_va = map_domain_page(_mfn(tmem_mfn));
> + tmem_va = map_domain_page(tmem_mfn);
Newline.
Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> if ( cli_va )
> {
> memcpy(cli_va, tmem_va, PAGE_SIZE);
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-04 22:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 18:15 [PATCH 0/7] xen: Convert __page_to_mfn and __mfn_to_page to use typesafe MFN Julien Grall
2017-10-04 18:15 ` [PATCH 1/7] xen/arm: domain_build: Clean-up insert_11_bank Julien Grall
2017-10-04 22:39 ` Andrew Cooper
2017-10-05 11:08 ` Julien Grall
2017-10-04 18:15 ` [PATCH 2/7] xen/arm32: mm: Rework is_xen_heap_page to avoid nameclash Julien Grall
2017-10-04 18:15 ` [PATCH 3/7] xen/x86: Use maddr_to_page and maddr_to_mfn to avoid open-coded >> PAGE_SHIFT Julien Grall
2017-10-04 22:41 ` Andrew Cooper
2017-10-04 18:15 ` [PATCH 4/7] xen/kimage: Remove defined but unused variables Julien Grall
2017-10-04 22:42 ` Andrew Cooper
2017-10-04 18:15 ` [PATCH 5/7] xen/xenoprof: Convert the file to use typesafe MFN Julien Grall
2017-10-04 22:43 ` Andrew Cooper
2017-10-04 18:15 ` [PATCH 6/7] xen/tmem: Convert the file common/tmem_xen.c " Julien Grall
2017-10-04 22:46 ` Andrew Cooper [this message]
2017-10-04 18:15 ` [PATCH 7/7] xen: Convert __page_to_mfn and __mfn_to_page " Julien Grall
2017-10-04 19:38 ` Razvan Cojocaru
2017-10-04 22:10 ` Tamas K Lengyel
2017-10-04 23:27 ` Andrew Cooper
2017-10-05 9:34 ` Jan Beulich
2017-10-05 14:54 ` Julien Grall
2017-10-06 17:31 ` [PATCH 0/7] " Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ac0341e-19c7-e652-eafb-2b056dc69eeb@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=julien.grall@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.