From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien.grall@linaro.org>, xen-devel@lists.xen.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 1/7] xen/arm: domain_build: Clean-up insert_11_bank
Date: Wed, 4 Oct 2017 23:39:43 +0100 [thread overview]
Message-ID: <732a038e-cd72-9be0-8754-285cda12c66a@citrix.com> (raw)
In-Reply-To: <20171004181526.9405-2-julien.grall@linaro.org>
On 04/10/2017 19:15, Julien Grall wrote:
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 3723dc3f78..093ebf1a8e 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -109,11 +109,11 @@ static bool insert_11_bank(struct domain *d,
>
> spfn = page_to_mfn(pg);
> start = pfn_to_paddr(spfn);
> - size = pfn_to_paddr((1 << order));
> + size = pfn_to_paddr(1UL << order);
>
> D11PRINT("Allocated %#"PRIpaddr"-%#"PRIpaddr" (%ldMB/%ldMB, order %d)\n",
> start, start + size,
> - 1UL << (order+PAGE_SHIFT-20),
> + 1UL << (order + PAGE_SHIFT - 20),
If you are looking to be picky, you've got a double space between the
minus and the 20. I'm sure this would be trivial to fix on commit.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-04 22:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 18:15 [PATCH 0/7] xen: Convert __page_to_mfn and __mfn_to_page to use typesafe MFN Julien Grall
2017-10-04 18:15 ` [PATCH 1/7] xen/arm: domain_build: Clean-up insert_11_bank Julien Grall
2017-10-04 22:39 ` Andrew Cooper [this message]
2017-10-05 11:08 ` Julien Grall
2017-10-04 18:15 ` [PATCH 2/7] xen/arm32: mm: Rework is_xen_heap_page to avoid nameclash Julien Grall
2017-10-04 18:15 ` [PATCH 3/7] xen/x86: Use maddr_to_page and maddr_to_mfn to avoid open-coded >> PAGE_SHIFT Julien Grall
2017-10-04 22:41 ` Andrew Cooper
2017-10-04 18:15 ` [PATCH 4/7] xen/kimage: Remove defined but unused variables Julien Grall
2017-10-04 22:42 ` Andrew Cooper
2017-10-04 18:15 ` [PATCH 5/7] xen/xenoprof: Convert the file to use typesafe MFN Julien Grall
2017-10-04 22:43 ` Andrew Cooper
2017-10-04 18:15 ` [PATCH 6/7] xen/tmem: Convert the file common/tmem_xen.c " Julien Grall
2017-10-04 22:46 ` Andrew Cooper
2017-10-04 18:15 ` [PATCH 7/7] xen: Convert __page_to_mfn and __mfn_to_page " Julien Grall
2017-10-04 19:38 ` Razvan Cojocaru
2017-10-04 22:10 ` Tamas K Lengyel
2017-10-04 23:27 ` Andrew Cooper
2017-10-05 9:34 ` Jan Beulich
2017-10-05 14:54 ` Julien Grall
2017-10-06 17:31 ` [PATCH 0/7] " Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=732a038e-cd72-9be0-8754-285cda12c66a@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=julien.grall@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.