Re: [RFC PATCH 2/8] dt-bindings: display: add versilicon,dc

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh@kernel.org>, Icenowy Zheng <uwu@icenowy.me>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Drew Fustini <fustini@kernel.org>, Guo Ren <guoren@kernel.org>,
	Fu Wei <wefu@redhat.com>, Philipp Zabel <p.zabel@pengutronix.de>,
	Heiko Stuebner <heiko@sntech.de>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Michal Wilczynski <m.wilczynski@samsung.com>,
	Han Gao <rabenda.cn@gmail.com>, Yao Zi <ziyao@disroot.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [RFC PATCH 2/8] dt-bindings: display: add versilicon,dc
Date: Fri, 15 Aug 2025 11:09:36 +0200	[thread overview]
Message-ID: <5af90b60-d65b-4e80-9a27-44938bbd450b@kernel.org> (raw)
In-Reply-To: <20250814220444.GA3988176-robh@kernel.org>

On 15/08/2025 00:04, Rob Herring wrote:
>> +
>> +maintainers:
>> +  - Icenowy Zheng <uwu@icenowy.me>
>> +
>> +properties:
>> +  $nodename:
>> +    pattern: "^display@[0-9a-f]+$"
>> +
>> +  compatible:
>> +    const: verisilicon,dc
> 
> If the clocks or resets varies by platform, then you need an SoC 
> specific compatible still. If these clocks/resets are straight from the 
> RTL and any other number of clocks/resets is wrong, then we can stick 
> with just this compatible.

Shouldn't we have here always SoC compatible? Can it be ever used alone,
outside of given SoC?

I could imagine now:

items:
  - {}
  - const: verisilicon,dc

Best regards,
Krzysztof

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv