From: Akash Asthana <akashast@codeaurora.org>
To: Wolfram Sang <wsa@kernel.org>
Cc: "Barry Song" <song.bao.hua@hisilicon.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linuxarm@huawei.com,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Mukesh Savaliya" <msavaliy@codeaurora.org>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>
Subject: Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
Date: Mon, 21 Sep 2020 17:14:59 +0530 [thread overview]
Message-ID: <5b1ee0bb-c496-fe48-e7ea-7d89377ae60d@codeaurora.org> (raw)
In-Reply-To: <20200921093433.GH1840@ninjato>
Hi Wolfram,
On 9/21/2020 3:04 PM, Wolfram Sang wrote:
> On Thu, Sep 10, 2020 at 05:10:20PM +0530, Akash Asthana wrote:
>> On 9/9/2020 9:40 AM, Barry Song wrote:
>>> The code has been in a irq-disabled context since it is hard IRQ. There
>>> is no necessity to do it again.
>>>
>>> Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
>>> Cc: "Andreas Färber" <afaerber@suse.de>
>>> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>>> Cc: Akash Asthana <akashast@codeaurora.org>
>>> Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
>>> Cc: Andy Gross <agross@kernel.org>
>>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>>> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
>>> ---
>> Reviewed-by: Akash Asthana <akashast@codeaurora.org>
> Thanks! Did you review the whole patch or only the qcom-geni part?
I reviewed the whole patch.
> (and please don't include the full message when you only reply to a part
> of it).
Sure thanks.
Regards,
Akash
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Akash Asthana <akashast@codeaurora.org>
To: Wolfram Sang <wsa@kernel.org>
Cc: "Barry Song" <song.bao.hua@hisilicon.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
linuxarm@huawei.com,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Andy Gross" <agross@kernel.org>,
linux-i2c@vger.kernel.org,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Mukesh Savaliya" <msavaliy@codeaurora.org>,
"Andreas Färber" <afaerber@suse.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ
Date: Mon, 21 Sep 2020 17:14:59 +0530 [thread overview]
Message-ID: <5b1ee0bb-c496-fe48-e7ea-7d89377ae60d@codeaurora.org> (raw)
In-Reply-To: <20200921093433.GH1840@ninjato>
Hi Wolfram,
On 9/21/2020 3:04 PM, Wolfram Sang wrote:
> On Thu, Sep 10, 2020 at 05:10:20PM +0530, Akash Asthana wrote:
>> On 9/9/2020 9:40 AM, Barry Song wrote:
>>> The code has been in a irq-disabled context since it is hard IRQ. There
>>> is no necessity to do it again.
>>>
>>> Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
>>> Cc: "Andreas Färber" <afaerber@suse.de>
>>> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>>> Cc: Akash Asthana <akashast@codeaurora.org>
>>> Cc: Mukesh Savaliya <msavaliy@codeaurora.org>
>>> Cc: Andy Gross <agross@kernel.org>
>>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>>> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
>>> ---
>> Reviewed-by: Akash Asthana <akashast@codeaurora.org>
> Thanks! Did you review the whole patch or only the qcom-geni part?
I reviewed the whole patch.
> (and please don't include the full message when you only reply to a part
> of it).
Sure thanks.
Regards,
Akash
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-21 11:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 4:10 [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ Barry Song
2020-09-09 4:10 ` Barry Song
2020-09-10 11:40 ` Akash Asthana
2020-09-10 11:40 ` Akash Asthana
2020-09-10 18:18 ` Mukesh, Savaliya
2020-09-10 18:18 ` Mukesh, Savaliya
[not found] ` <24424594-963c-c744-846f-cf79b6024b1c@codeaurora.org>
2020-09-21 9:34 ` Wolfram Sang
2020-09-21 9:34 ` Wolfram Sang
2020-09-21 11:44 ` Akash Asthana [this message]
2020-09-21 11:44 ` Akash Asthana
[not found] ` <268c12c2-c72d-809c-9ecc-520ef274c1c3@codeaurora.org>
2020-09-21 9:39 ` Wolfram Sang
2020-09-21 9:39 ` Wolfram Sang
2020-09-29 19:42 ` Wolfram Sang
2020-09-29 19:42 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b1ee0bb-c496-fe48-e7ea-7d89377ae60d@codeaurora.org \
--to=akashast@codeaurora.org \
--cc=afaerber@suse.de \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=msavaliy@codeaurora.org \
--cc=song.bao.hua@hisilicon.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.