All of lore.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] add strncmp to PowerPC
Date: Wed, 5 Mar 2008 08:01:20 +0100	[thread overview]
Message-ID: <5b485b22fcd97d89ee82f1fa5c1940db@kernel.crashing.org> (raw)
In-Reply-To: <18382.12838.527446.325768@cargo.ozlabs.ibm.com>

>> Anyway, this asm code has bugs, as do both the current C version in 
>> the
>> kernel, and the code I posted.  We need to do better :-)
>
> The only bug I know of in the asm code is the behaviour when the count
> is zero.  Do you know of any other?

No, that's the bug I meant.  Sorry for using such inexact language.


Segher

WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: benh@kernel.crashing.org, LKML <linux-kernel@vger.kernel.org>,
	linuxppc-dev@ozlabs.org, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] add strncmp to PowerPC
Date: Wed, 5 Mar 2008 08:01:20 +0100	[thread overview]
Message-ID: <5b485b22fcd97d89ee82f1fa5c1940db@kernel.crashing.org> (raw)
In-Reply-To: <18382.12838.527446.325768@cargo.ozlabs.ibm.com>

>> Anyway, this asm code has bugs, as do both the current C version in 
>> the
>> kernel, and the code I posted.  We need to do better :-)
>
> The only bug I know of in the asm code is the behaviour when the count
> is zero.  Do you know of any other?

No, that's the bug I meant.  Sorry for using such inexact language.


Segher


  reply	other threads:[~2008-03-05  7:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-29 16:04 [PATCH] add strncmp to PowerPC Steven Rostedt
2008-03-01  3:04 ` Benjamin Herrenschmidt
2008-03-01  3:04   ` Benjamin Herrenschmidt
2008-03-01  3:56   ` Steven Rostedt
2008-03-01  3:56     ` Steven Rostedt
2008-03-03  9:54     ` Gabriel Paubert
2008-03-03  9:54       ` Gabriel Paubert
2008-03-03 10:10       ` Andreas Schwab
2008-03-03 10:10         ` Andreas Schwab
2008-03-03 19:08       ` Segher Boessenkool
2008-03-03 19:08         ` Segher Boessenkool
2008-03-05  4:03   ` Paul Mackerras
2008-03-05  4:03     ` Paul Mackerras
2008-03-05  5:26     ` Segher Boessenkool
2008-03-05  5:26       ` Segher Boessenkool
2008-03-05  5:39       ` Paul Mackerras
2008-03-05  5:39         ` Paul Mackerras
2008-03-05  7:01         ` Segher Boessenkool [this message]
2008-03-05  7:01           ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b485b22fcd97d89ee82f1fa5c1940db@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.