From: Marc Zyngier <maz@kernel.org>
To: Anup Patel <Anup.Patel@wdc.com>
Cc: Jason Cooper <jason@lakedaemon.net>,
Anup Patel <anup@brainfault.org>,
linux-kernel@vger.kernel.org, Atish Patra <Atish.Patra@wdc.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 3/4] irqchip/sifive-plic: Separate irq_chip for muiltiple PLIC instances
Date: Mon, 18 May 2020 09:14:30 +0100 [thread overview]
Message-ID: <5bc4010161af7bef8e3c30e08888ec82@kernel.org> (raw)
In-Reply-To: <MN2PR04MB62078C2854FE33CE81186FA88DBA0@MN2PR04MB6207.namprd04.prod.outlook.com>
On 2020-05-16 17:38, Anup Patel wrote:
>> -----Original Message-----
>> From: Marc Zyngier <maz@kernel.org>
[...]
>> I *have* given you a way to implement that in a better way. But again,
>> I'd
>> rather you *don't* do it for the reason I have outlined above.
>
> I explored kernel/irq/proc.c and we can achieve what this patch does
> by implementing irq_print_chip() callback of "struct irq_chip" so we
> certainly don't need separate "struct irq_chip" for each PLIC instance.
>
> I will implement irq_print_chip() callback in v2 series.
You still haven't explained *why* you need to have this change.
As it stands, I'm not prepared to take it.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Anup Patel <Anup.Patel@wdc.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Atish Patra <Atish.Patra@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Anup Patel <anup@brainfault.org>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] irqchip/sifive-plic: Separate irq_chip for muiltiple PLIC instances
Date: Mon, 18 May 2020 09:14:30 +0100 [thread overview]
Message-ID: <5bc4010161af7bef8e3c30e08888ec82@kernel.org> (raw)
In-Reply-To: <MN2PR04MB62078C2854FE33CE81186FA88DBA0@MN2PR04MB6207.namprd04.prod.outlook.com>
On 2020-05-16 17:38, Anup Patel wrote:
>> -----Original Message-----
>> From: Marc Zyngier <maz@kernel.org>
[...]
>> I *have* given you a way to implement that in a better way. But again,
>> I'd
>> rather you *don't* do it for the reason I have outlined above.
>
> I explored kernel/irq/proc.c and we can achieve what this patch does
> by implementing irq_print_chip() callback of "struct irq_chip" so we
> certainly don't need separate "struct irq_chip" for each PLIC instance.
>
> I will implement irq_print_chip() callback in v2 series.
You still haven't explained *why* you need to have this change.
As it stands, I'm not prepared to take it.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-05-18 8:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 6:38 [PATCH 0/4] More improvements for multiple PLICs Anup Patel
2020-05-16 6:38 ` Anup Patel
2020-05-16 6:38 ` [PATCH 1/4] irqchip/sifive-plic: Setup cpuhp once after current handler is present Anup Patel
2020-05-16 6:38 ` Anup Patel
2020-05-16 12:11 ` Marc Zyngier
2020-05-16 12:11 ` Marc Zyngier
2020-05-16 12:52 ` Anup Patel
2020-05-16 12:52 ` Anup Patel
2020-05-16 13:30 ` Marc Zyngier
2020-05-16 13:30 ` Marc Zyngier
2020-05-16 16:28 ` Anup Patel
2020-05-16 16:28 ` Anup Patel
2020-05-17 8:02 ` Anup Patel
2020-05-17 8:02 ` Anup Patel
2020-05-16 6:38 ` [PATCH 2/4] irqchip/sifive-plic: Improve boot prints for multiple PLIC instances Anup Patel
2020-05-16 6:38 ` Anup Patel
2020-05-16 12:20 ` Marc Zyngier
2020-05-16 12:20 ` Marc Zyngier
2020-05-16 12:53 ` Anup Patel
2020-05-16 12:53 ` Anup Patel
2020-05-16 6:39 ` [PATCH 3/4] irqchip/sifive-plic: Separate irq_chip for muiltiple " Anup Patel
2020-05-16 6:39 ` Anup Patel
2020-05-16 12:29 ` Marc Zyngier
2020-05-16 12:29 ` Marc Zyngier
2020-05-16 13:01 ` Anup Patel
2020-05-16 13:01 ` Anup Patel
2020-05-16 13:16 ` Marc Zyngier
2020-05-16 13:16 ` Marc Zyngier
2020-05-16 16:38 ` Anup Patel
2020-05-16 16:38 ` Anup Patel
2020-05-18 8:14 ` Marc Zyngier [this message]
2020-05-18 8:14 ` Marc Zyngier
2020-05-18 9:00 ` Anup Patel
2020-05-18 9:00 ` Anup Patel
2020-05-16 6:39 ` [PATCH 4/4] irqchip/sifive-plic: Set default irq affinity in plic_irqdomain_map() Anup Patel
2020-05-16 6:39 ` Anup Patel
2020-05-16 12:30 ` Marc Zyngier
2020-05-16 12:30 ` Marc Zyngier
2020-05-16 12:53 ` Anup Patel
2020-05-16 12:53 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bc4010161af7bef8e3c30e08888ec82@kernel.org \
--to=maz@kernel.org \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=anup@brainfault.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.