* Re: [alsa-devel] [PATCH] ASoC: Intel: bytcr_rt5640: Update quirk for Acer Switch 10 SW5-012 2-in-1
2019-11-19 14:51 [alsa-devel] [PATCH] ASoC: Intel: bytcr_rt5640: Update quirk for Acer Switch 10 SW5-012 2-in-1 Hans de Goede
@ 2019-11-19 15:03 ` Andy Shevchenko
2019-11-19 15:18 ` Pierre-Louis Bossart
2019-11-20 17:18 ` [alsa-devel] Applied "ASoC: Intel: bytcr_rt5640: Update quirk for Acer Switch 10 SW5-012 2-in-1" to the asoc tree Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2019-11-19 15:03 UTC (permalink / raw)
To: Hans de Goede
Cc: Cezary Rojewski, alsa-devel, Takashi Iwai, Jie Yang,
Pierre-Louis Bossart, Liam Girdwood, Mark Brown
On Tue, Nov 19, 2019 at 03:51:38PM +0100, Hans de Goede wrote:
> When the Acer Switch 10 SW5-012 quirk was added we did not have
> jack-detection support yet; and the builtin microphone selection of
> the original quirk is wrong too.
>
> Fix the microphone-input quirk and add jack-detection info so that the
> internal-microphone and headphone/set jack on the Switch 10 work properly.
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> sound/soc/intel/boards/bytcr_rt5640.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 9c1aa4ec9cba..dd2b5ad08659 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -405,10 +405,12 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
> DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> DMI_MATCH(DMI_PRODUCT_NAME, "Aspire SW5-012"),
> },
> - .driver_data = (void *)(BYT_RT5640_IN1_MAP |
> - BYT_RT5640_MCLK_EN |
> - BYT_RT5640_SSP0_AIF1),
> -
> + .driver_data = (void *)(BYT_RT5640_DMIC1_MAP |
> + BYT_RT5640_JD_SRC_JD2_IN4N |
> + BYT_RT5640_OVCD_TH_2000UA |
> + BYT_RT5640_OVCD_SF_0P75 |
> + BYT_RT5640_SSP0_AIF1 |
> + BYT_RT5640_MCLK_EN),
> },
> {
> .matches = {
> --
> 2.23.0
>
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [alsa-devel] [PATCH] ASoC: Intel: bytcr_rt5640: Update quirk for Acer Switch 10 SW5-012 2-in-1
2019-11-19 14:51 [alsa-devel] [PATCH] ASoC: Intel: bytcr_rt5640: Update quirk for Acer Switch 10 SW5-012 2-in-1 Hans de Goede
2019-11-19 15:03 ` Andy Shevchenko
@ 2019-11-19 15:18 ` Pierre-Louis Bossart
2019-11-20 17:18 ` [alsa-devel] Applied "ASoC: Intel: bytcr_rt5640: Update quirk for Acer Switch 10 SW5-012 2-in-1" to the asoc tree Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Pierre-Louis Bossart @ 2019-11-19 15:18 UTC (permalink / raw)
To: Hans de Goede, Cezary Rojewski, Liam Girdwood, Jie Yang,
Mark Brown
Cc: alsa-devel, Andy Shevchenko, Takashi Iwai
On 11/19/19 8:51 AM, Hans de Goede wrote:
> When the Acer Switch 10 SW5-012 quirk was added we did not have
> jack-detection support yet; and the builtin microphone selection of
> the original quirk is wrong too.
>
> Fix the microphone-input quirk and add jack-detection info so that the
> internal-microphone and headphone/set jack on the Switch 10 work properly.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Thanks Hans,
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/intel/boards/bytcr_rt5640.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 9c1aa4ec9cba..dd2b5ad08659 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -405,10 +405,12 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
> DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> DMI_MATCH(DMI_PRODUCT_NAME, "Aspire SW5-012"),
> },
> - .driver_data = (void *)(BYT_RT5640_IN1_MAP |
> - BYT_RT5640_MCLK_EN |
> - BYT_RT5640_SSP0_AIF1),
> -
> + .driver_data = (void *)(BYT_RT5640_DMIC1_MAP |
> + BYT_RT5640_JD_SRC_JD2_IN4N |
> + BYT_RT5640_OVCD_TH_2000UA |
> + BYT_RT5640_OVCD_SF_0P75 |
> + BYT_RT5640_SSP0_AIF1 |
> + BYT_RT5640_MCLK_EN),
> },
> {
> .matches = {
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* [alsa-devel] Applied "ASoC: Intel: bytcr_rt5640: Update quirk for Acer Switch 10 SW5-012 2-in-1" to the asoc tree
2019-11-19 14:51 [alsa-devel] [PATCH] ASoC: Intel: bytcr_rt5640: Update quirk for Acer Switch 10 SW5-012 2-in-1 Hans de Goede
2019-11-19 15:03 ` Andy Shevchenko
2019-11-19 15:18 ` Pierre-Louis Bossart
@ 2019-11-20 17:18 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2019-11-20 17:18 UTC (permalink / raw)
To: Hans de Goede
Cc: Pierre-Louis Bossart, alsa-devel, Takashi Iwai, Jie Yang,
Cezary Rojewski, Liam Girdwood, Mark Brown, Andy Shevchenko
The patch
ASoC: Intel: bytcr_rt5640: Update quirk for Acer Switch 10 SW5-012 2-in-1
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 0bb887709eb16bdc4b5baddd8337abf3de72917f Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdegoede@redhat.com>
Date: Tue, 19 Nov 2019 15:51:38 +0100
Subject: [PATCH] ASoC: Intel: bytcr_rt5640: Update quirk for Acer Switch 10
SW5-012 2-in-1
When the Acer Switch 10 SW5-012 quirk was added we did not have
jack-detection support yet; and the builtin microphone selection of
the original quirk is wrong too.
Fix the microphone-input quirk and add jack-detection info so that the
internal-microphone and headphone/set jack on the Switch 10 work properly.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20191119145138.59162-1-hdegoede@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/boards/bytcr_rt5640.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index 9c1aa4ec9cba..dd2b5ad08659 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -405,10 +405,12 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
DMI_MATCH(DMI_PRODUCT_NAME, "Aspire SW5-012"),
},
- .driver_data = (void *)(BYT_RT5640_IN1_MAP |
- BYT_RT5640_MCLK_EN |
- BYT_RT5640_SSP0_AIF1),
-
+ .driver_data = (void *)(BYT_RT5640_DMIC1_MAP |
+ BYT_RT5640_JD_SRC_JD2_IN4N |
+ BYT_RT5640_OVCD_TH_2000UA |
+ BYT_RT5640_OVCD_SF_0P75 |
+ BYT_RT5640_SSP0_AIF1 |
+ BYT_RT5640_MCLK_EN),
},
{
.matches = {
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread