Re: [bug report] platform/x86: asus-armoury: move existing tunings to asus-armoury module

[Denis Benato <denis.benato@linux.dev>]

On 11/19/25 08:46, luke@ljones.dev wrote:
> I’m not working on this. CCing Denis.
>
>> On 19 Nov 2025, at 20:27, Dan Carpenter <dan.carpenter@linaro.org> wrote:
>>
>> Hello Luke D. Jones,
>>
>> Commit f99eb098090e ("platform/x86: asus-armoury: move existing
>> tunings to asus-armoury module") from Nov 2, 2025 (linux-next), leads
>> to the following Smatch static checker warning:
>>
>> 	drivers/platform/x86/asus-armoury.c:429 mini_led_mode_current_value_show()
>> 	warn: iterator 'i' not incremented
>>
>> drivers/platform/x86/asus-armoury.c
>>    399 static ssize_t mini_led_mode_current_value_show(struct kobject *kobj,
>>    400                                                 struct kobj_attribute *attr, char *buf)
>>    401 {
>>    402         u32 *mini_led_mode_map;
>>    403         size_t mini_led_mode_map_size;
>>    404         u32 i, mode;
>>    405         int err;
>>    406 
>>    407         switch (asus_armoury.mini_led_dev_id) {
>>    408         case ASUS_WMI_DEVID_MINI_LED_MODE:
>>    409                 mini_led_mode_map = mini_led_mode1_map;
>>    410                 mini_led_mode_map_size = ARRAY_SIZE(mini_led_mode1_map);
>>    411                 break;
>>    412 
>>    413         case ASUS_WMI_DEVID_MINI_LED_MODE2:
>>    414                 mini_led_mode_map = mini_led_mode2_map;
>>    415                 mini_led_mode_map_size = ARRAY_SIZE(mini_led_mode2_map);
>>    416                 break;
>>    417 
>>    418         default:
>>    419                 pr_err("Unrecognized mini-LED device: %u\n", asus_armoury.mini_led_dev_id);
>>    420                 return -ENODEV;
>>    421         }
>>    422 
>>    423         err = armoury_get_devstate(attr, &mode, asus_armoury.mini_led_dev_id);
>>    424         if (err)
>>    425                 return err;
>>    426 
>>    427         mode = FIELD_GET(ASUS_MINI_LED_MODE_MASK, 0);
>>    428 
>> --> 429         for (i = 0; i < mini_led_mode_map_size; i++)
>>    430                 return sysfs_emit(buf, "%u\n", mini_led_mode_map[i]);
>>
>> This loop doesn't make sense.  It just prints the first element in
>> the mini_led_mode_map[] array and returns.
Thank you both for this.

Fix available here: https://lore.kernel.org/all/20251120024059.1341326-1-denis.benato@linux.dev/
>>
>>    431 
>>    432         pr_warn("Unrecognized mini-LED mode: %u", mode);
>>    433         return -EINVAL;
>>    434 }
>>
>> regards,
>> dan carpenter