All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Luke D. Jones" <luke@ljones.dev>
Cc: platform-driver-x86@vger.kernel.org
Subject: [bug report] platform/x86: asus-armoury: move existing tunings to asus-armoury module
Date: Mon, 24 Nov 2025 14:53:40 +0300	[thread overview]
Message-ID: <aSRHRCgoKxxmw4bt@stanley.mountain> (raw)

Hello Luke D. Jones,

Commit f99eb098090e ("platform/x86: asus-armoury: move existing
tunings to asus-armoury module") from Nov 2, 2025 (linux-next), leads
to the following Smatch static checker warning:

	drivers/platform/x86/asus-armoury.c:147 armoury_has_devstate()
	error: uninitialized symbol 'retval'.

drivers/platform/x86/asus-armoury.c
    141 static bool armoury_has_devstate(u32 dev_id)
    142 {
    143         u32 retval;
    144         int status;
    145 
    146         status = asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS, dev_id, 0, &retval);
--> 147         pr_debug("%s called (0x%08x), retval: 0x%08x\n", __func__, dev_id, retval);
                                                                                   ^^^^^^
"retval" is uninitialized if asus_wmi_evaluate_method() returns negative.

    148 
    149         return status == 0 && (retval & ASUS_WMI_DSTS_PRESENCE_BIT);
    150 }

regards,
dan carpenter

             reply	other threads:[~2025-11-24 11:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24 11:53 Dan Carpenter [this message]
2025-12-01  5:16 ` [bug report] platform/x86: asus-armoury: move existing tunings to asus-armoury module luke
  -- strict thread matches above, loose matches on Subject: below --
2025-11-19  7:27 Dan Carpenter
2025-11-19  7:46 ` luke
2025-11-20  2:44   ` Denis Benato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aSRHRCgoKxxmw4bt@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.